Control Command Newbie Question

[Ibike2]

Newbie's First post. I have reviewed the forums but unfortunately have not found a solution.

I am writing a script to automate some repetitive tasks in a hydraulic modeling program called HEC-RAS. What I would like to happen is for the script to prompt the user to select a river and reach (each which has its own combobox). After the user makes their selection and presses ok to leave the screen, I would like the script to remember the selections to be called later during future iterations. I have done this successfully in another window in a listbox, but am not having success with the combobox. I would like the text of the combobox that is displayed to be stored to $River and $Reach for the appropriate control ID. Occasionally this will run and store the correct information in the correct variable and display it in the message box, but occasionally the $Reach value is 0 instead of the Reach name selected.

It seems impractical to include the entire code and HEC-RAS, so the portion of code that seems to have errors is as follows (I understand you will not be able to replicate my problem though).

Is there a more appropriate way to store this information upon close of the window than to keep storing the current selection until the window that opens following the user pressing ok (Steady Flow Analysis) appears?

Thanks so much.

MsgBox(0, "User input required", "Please select River and Reach to Optimize and press OK to continue with script")
WinWaitActive("Encroachments")

While 1
    If WinActive("Steady Flow Analysis") Then
        ExitLoop
    EndIf
    $River= ControlCommand("Encroachments", "", "[ID:12]", "GetCurrentSelection", "")
    $Reach= ControlCommand("Encroachments", "", "[ID:11]", "GetCurrentSelection", "")
    sleep(10)
WEnd

MsgBox(0, "River and Reach", $River & "," & $Reach)

[Melba23]

Ibike2,

Welcome to the AutoIt forum.

One thing that immediately strikes me is the use of [iD:##] to identify the control in your ControlCommand lines.

Some apps give controls different IDs each time they are created - are you sure that the relevant combo is always [iD:11]? Is there anything else that the AU3 Window Info tool gives you which could help identify that combo?

Sorry I cannot be of more help, but the fact that the error is only occasional makes me suspicious of the ID method as I have run into this problem myself in the past.

M23

[Ibike2]

Thanks for the response Melba23.

I noticed that the handle changes each time the "Encroachments" window is opened as I had tried to use the handle to identify the comboboxes, so I switched to ID, but so far every time I've had it opened the ID's remained 11 and 12 for these two comboboxes. Would the classnamenn be more stable (called ThunderRT6ComboBox4 and ThunderRT6ComboBox5) or would it be possible for these to be dynamic as well?

Thanks

[Ibike2]

I changed the code slightly and no longer get the occasional '0' return. I'm not sure why this worked, someone more experiences may wish to lend some insight.

I changed $River and $Reach to Global instead of Dim when initializing.

I added the line WinActivate("Encroachments")

Thanks for such a great forum.

While 1     WinActivate("Encroachments")    If WinActive("Steady Flow Analysis") Then       ExitLoop    EndIf   $River= ControlCommand("Encroachments", "", "[ID:12]", "GetCurrentSelection", "")   $Reach= ControlCommand("Encroachments", "", "[ID:11]", "GetCurrentSelection", "")   sleep(10) WEnd

[Melba23]

Ibike2,

You should always use Global/Local rather than Dim. AutoIt tries to give you the scope it thinks you need but it is best to be specific.

As to WinActivate - it is probably that that did the trick.

Sounds like an interesting application! Delighted that it works now.

M23