E1M1 Posted February 4, 2010 Share Posted February 4, 2010 Does anyone know why _memoryread returns me 0? strange is that cheat engine shows the value.#include <GUIConstants.au3> #include <NomadMemory.au3> ;because you need this for _memread functions GUICreate("My GUI Button") $Button_1 = GUICtrlCreateButton ("Check Memory Address", 10, 30, 150) $Label_1 = GUICtrlCreateLabel("life",20, 60) GUISetState () $Mem_Address = 0x04FC2F25 $Process1 = WinGetProcess("Diablo II") ;the window to get PID While 1 $msg = GUIGetMsg() Select Case $msg = $GUI_EVENT_CLOSE ExitLoop Case $msg = $Button_1 $Mem_Open = _MemoryOpen($Process1) ;must open before you can read address $Mem_Read = _MemoryRead($Mem_Address, $Mem_Open) ;reads value at memory address _MemoryClose($Mem_Open) ;close it afterwards GUICtrlSetData($Label_1,$Mem_Read) ; sets label to value of read memory EndSelect WendAs u can see from picture, it cant be wrong memory address problem. edited Link to comment Share on other sites More sharing options...
darkjohn20 Posted February 4, 2010 Share Posted February 4, 2010 I believe it returns an array? Not quite sure. Link to comment Share on other sites More sharing options...
E1M1 Posted February 4, 2010 Author Share Posted February 4, 2010 i dont thing that. here's udf expandcollapse popup#include-once #region _Memory ;================================================================================== ; AutoIt Version: 3.1.127 (beta) ; Language: English ; Platform: All Windows ; Author: Nomad ; Requirements: These functions will only work with beta. ;================================================================================== ; Credits: wOuter - These functions are based on his original _Mem() functions. ; But they are easier to comprehend and more reliable. These ; functions are in no way a direct copy of his functions. His ; functions only provided a foundation from which these evolved. ;================================================================================== ; ; Functions: ; ;================================================================================== ; Function: _MemoryOpen($iv_Pid[, $iv_DesiredAccess[, $iv_InheritHandle]]) ; Description: Opens a process and enables all possible access rights to the ; process. The Process ID of the process is used to specify which ; process to open. You must call this function before calling ; _MemoryClose(), _MemoryRead(), or _MemoryWrite(). ; Parameter(s): $iv_Pid - The Process ID of the program you want to open. ; $iv_DesiredAccess - (optional) Set to 0x1F0FFF by default, which ; enables all possible access rights to the ; process specified by the Process ID. ; $iv_InheritHandle - (optional) If this value is TRUE, all processes ; created by this process will inherit the access ; handle. Set to 1 (TRUE) by default. Set to 0 ; if you want it FALSE. ; Requirement(s): None. ; Return Value(s): On Success - Returns an array containing the Dll handle and an ; open handle to the specified process. ; On Failure - Returns 0 ; @Error - 0 = No error. ; 1 = Invalid $iv_Pid. ; 2 = Failed to open Kernel32.dll. ; 3 = Failed to open the specified process. ; Author(s): Nomad ; Note(s): ;================================================================================== Func _MemoryOpen($iv_Pid, $iv_DesiredAccess = 0x1F0FFF, $iv_InheritHandle = 1) If Not ProcessExists($iv_Pid) Then SetError(1) Return 0 EndIf Local $ah_Handle[2] = [DllOpen('kernel32.dll')] If @Error Then SetError(2) Return 0 EndIf Local $av_OpenProcess = DllCall($ah_Handle[0], 'int', 'OpenProcess', 'int', $iv_DesiredAccess, 'int', $iv_InheritHandle, 'int', $iv_Pid) If @Error Then DllClose($ah_Handle[0]) SetError(3) Return 0 EndIf $ah_Handle[1] = $av_OpenProcess[0] Return $ah_Handle EndFunc ;================================================================================== ; Function: _MemoryRead($iv_Address, $ah_Handle[, $sv_Type]) ; Description: Reads the value located in the memory address specified. ; Parameter(s): $iv_Address - The memory address you want to read from. It must ; be in hex format (0x00000000). ; $ah_Handle - An array containing the Dll handle and the handle ; of the open process as returned by _MemoryOpen(). ; $sv_Type - (optional) The "Type" of value you intend to read. ; This is set to 'dword'(32bit(4byte) signed integer) ; by default. See the help file for DllStructCreate ; for all types. An example: If you want to read a ; word that is 15 characters in length, you would use ; 'char[16]' since a 'char' is 8 bits (1 byte) in size. ; Return Value(s): On Success - Returns the value located at the specified address. ; On Failure - Returns 0 ; @Error - 0 = No error. ; 1 = Invalid $ah_Handle. ; 2 = $sv_Type was not a string. ; 3 = $sv_Type is an unknown data type. ; 4 = Failed to allocate the memory needed for the DllStructure. ; 5 = Error allocating memory for $sv_Type. ; 6 = Failed to read from the specified process. ; Author(s): Nomad ; Note(s): Values returned are in Decimal format, unless specified as a ; 'char' type, then they are returned in ASCII format. Also note ; that size ('char[size]') for all 'char' types should be 1 ; greater than the actual size. ;================================================================================== Func _MemoryRead($iv_Address, $ah_Handle, $sv_Type = 'dword') If Not IsArray($ah_Handle) Then SetError(1) Return 0 EndIf Local $v_Buffer = DllStructCreate($sv_Type) If @Error Then SetError(@Error + 1) Return 0 EndIf DllCall($ah_Handle[0], 'int', 'ReadProcessMemory', 'int', $ah_Handle[1], 'int', $iv_Address, 'ptr', DllStructGetPtr($v_Buffer), 'int', DllStructGetSize($v_Buffer), 'int', '') If Not @Error Then Local $v_Value = DllStructGetData($v_Buffer, 1) Return $v_Value Else SetError(6) Return 0 EndIf EndFunc ;================================================================================== ; Function: _MemoryWrite($iv_Address, $ah_Handle, $v_Data[, $sv_Type]) ; Description: Writes data to the specified memory address. ; Parameter(s): $iv_Address - The memory address which you want to write to. ; It must be in hex format (0x00000000). ; $ah_Handle - An array containing the Dll handle and the handle ; of the open process as returned by _MemoryOpen(). ; $v_Data - The data to be written. ; $sv_Type - (optional) The "Type" of value you intend to write. ; This is set to 'dword'(32bit(4byte) signed integer) ; by default. See the help file for DllStructCreate ; for all types. An example: If you want to write a ; word that is 15 characters in length, you would use ; 'char[16]' since a 'char' is 8 bits (1 byte) in size. ; Return Value(s): On Success - Returns 1 ; On Failure - Returns 0 ; @Error - 0 = No error. ; 1 = Invalid $ah_Handle. ; 2 = $sv_Type was not a string. ; 3 = $sv_Type is an unknown data type. ; 4 = Failed to allocate the memory needed for the DllStructure. ; 5 = Error allocating memory for $sv_Type. ; 6 = $v_Data is not in the proper format to be used with the ; "Type" selected for $sv_Type, or it is out of range. ; 7 = Failed to write to the specified process. ; Author(s): Nomad ; Note(s): Values sent must be in Decimal format, unless specified as a ; 'char' type, then they must be in ASCII format. Also note ; that size ('char[size]') for all 'char' types should be 1 ; greater than the actual size. ;================================================================================== Func _MemoryWrite($iv_Address, $ah_Handle, $v_Data, $sv_Type = 'dword') If Not IsArray($ah_Handle) Then SetError(1) Return 0 EndIf Local $v_Buffer = DllStructCreate($sv_Type) If @Error Then SetError(@Error + 1) Return 0 Else DllStructSetData($v_Buffer, 1, $v_Data) If @Error Then SetError(6) Return 0 EndIf EndIf DllCall($ah_Handle[0], 'int', 'WriteProcessMemory', 'int', $ah_Handle[1], 'int', $iv_Address, 'ptr', DllStructGetPtr($v_Buffer), 'int', DllStructGetSize($v_Buffer), 'int', '') If Not @Error Then Return 1 Else SetError(7) Return 0 EndIf EndFunc ;================================================================================== ; Function: _MemoryClose($ah_Handle) ; Description: Closes the process handle opened by using _MemoryOpen(). ; Parameter(s): $ah_Handle - An array containing the Dll handle and the handle ; of the open process as returned by _MemoryOpen(). ; Return Value(s): On Success - Returns 1 ; On Failure - Returns 0 ; @Error - 0 = No error. ; 1 = Invalid $ah_Handle. ; 2 = Unable to close the process handle. ; Author(s): Nomad ; Note(s): ;================================================================================== Func _MemoryClose($ah_Handle) If Not IsArray($ah_Handle) Then SetError(1) Return 0 EndIf DllCall($ah_Handle[0], 'int', 'CloseHandle', 'int', $ah_Handle[1]) If Not @Error Then DllClose($ah_Handle[0]) Return 1 Else DllClose($ah_Handle[0]) SetError(2) Return 0 EndIf EndFunc ;================================================================================== ; Function: SetPrivilege( $privilege, $bEnable ) ; Description: Enables (or disables) the $privilege on the current process ; (Probably) requires administrator privileges to run ; ; Author(s): Larry (from autoitscript.com's Forum) ; Notes(s): ; http://www.autoitscript.com/forum/index.php?s=&showtopic=31248&view=findpost&p=223999 ;================================================================================== Func SetPrivilege( $privilege, $bEnable ) Const $TOKEN_ADJUST_PRIVILEGES = 0x0020 Const $TOKEN_QUERY = 0x0008 Const $SE_PRIVILEGE_ENABLED = 0x0002 Local $hToken, $SP_auxret, $SP_ret, $hCurrProcess, $nTokens, $nTokenIndex, $priv $nTokens = 1 $LUID = DLLStructCreate("dword;int") If IsArray($privilege) Then $nTokens = UBound($privilege) $TOKEN_PRIVILEGES = DLLStructCreate("dword;dword[" & (3 * $nTokens) & "]") $NEWTOKEN_PRIVILEGES = DLLStructCreate("dword;dword[" & (3 * $nTokens) & "]") $hCurrProcess = DLLCall("kernel32.dll","hwnd","GetCurrentProcess") $SP_auxret = DLLCall("advapi32.dll","int","OpenProcessToken","hwnd",$hCurrProcess[0], _ "int",BitOR($TOKEN_ADJUST_PRIVILEGES,$TOKEN_QUERY),"int_ptr",0) If $SP_auxret[0] Then $hToken = $SP_auxret[3] DLLStructSetData($TOKEN_PRIVILEGES,1,1) $nTokenIndex = 1 While $nTokenIndex <= $nTokens If IsArray($privilege) Then $priv = $privilege[$nTokenIndex-1] Else $priv = $privilege EndIf $ret = DLLCall("advapi32.dll","int","LookupPrivilegeValue","str","","str",$priv, _ "ptr",DLLStructGetPtr($LUID)) If $ret[0] Then If $bEnable Then DLLStructSetData($TOKEN_PRIVILEGES,2,$SE_PRIVILEGE_ENABLED,(3 * $nTokenIndex)) Else DLLStructSetData($TOKEN_PRIVILEGES,2,0,(3 * $nTokenIndex)) EndIf DLLStructSetData($TOKEN_PRIVILEGES,2,DllStructGetData($LUID,1),(3 * ($nTokenIndex-1)) + 1) DLLStructSetData($TOKEN_PRIVILEGES,2,DllStructGetData($LUID,2),(3 * ($nTokenIndex-1)) + 2) DLLStructSetData($LUID,1,0) DLLStructSetData($LUID,2,0) EndIf $nTokenIndex += 1 WEnd $ret = DLLCall("advapi32.dll","int","AdjustTokenPrivileges","hwnd",$hToken,"int",0, _ "ptr",DllStructGetPtr($TOKEN_PRIVILEGES),"int",DllStructGetSize($NEWTOKEN_PRIVILEGES), _ "ptr",DllStructGetPtr($NEWTOKEN_PRIVILEGES),"int_ptr",0) $f = DLLCall("kernel32.dll","int","GetLastError") EndIf $NEWTOKEN_PRIVILEGES=0 $TOKEN_PRIVILEGES=0 $LUID=0 If $SP_auxret[0] = 0 Then Return 0 $SP_auxret = DLLCall("kernel32.dll","int","CloseHandle","hwnd",$hToken) If Not $ret[0] And Not $SP_auxret[0] Then Return 0 return $ret[0] EndFunc ;==>SetPrivilege #endregion edited Link to comment Share on other sites More sharing options...
Cuervo Posted February 4, 2010 Share Posted February 4, 2010 (edited) On windows 7, maybe vista as well, I have to add #RequireAdmin to get any memory functions to work. What OS are you using? Edited February 4, 2010 by Cuervo -Tim Link to comment Share on other sites More sharing options...
darkjohn20 Posted February 4, 2010 Share Posted February 4, 2010 Nevermind, I was thinking of the Pointer one. Yes, it could be because of Vista+. If not try putting your address in quotes, not that I think it matters. Link to comment Share on other sites More sharing options...
Cuervo Posted February 4, 2010 Share Posted February 4, 2010 Nevermind, I was thinking of the Pointer one.Yes, it could be because of Vista+. If not try putting your address in quotes, not that I think it matters.$Mem_Address = "0x04FC2F25" <---- this would be wrong, he has it correct as is. If you put it in quotes it fails to _MemoryWrite for sure. -Tim Link to comment Share on other sites More sharing options...
darkjohn20 Posted February 4, 2010 Share Posted February 4, 2010 Nevermind then. Link to comment Share on other sites More sharing options...
E1M1 Posted February 4, 2010 Author Share Posted February 4, 2010 What OS are you using? win 7 i tried that admin stuff, no effect edited Link to comment Share on other sites More sharing options...
darkjohn20 Posted February 4, 2010 Share Posted February 4, 2010 I have no problems with Windows 7 Ultimate 32-bit. Link to comment Share on other sites More sharing options...
E1M1 Posted February 4, 2010 Author Share Posted February 4, 2010 I use win 7 ultimate 64 bit but CheatEngine is 32 bit app and Diablo II is 32 bit game and autoit I use is 32 bit version. I don't think bits are problem, but who knows. edited Link to comment Share on other sites More sharing options...
darkjohn20 Posted February 4, 2010 Share Posted February 4, 2010 What does _MemoryOpen return? Link to comment Share on other sites More sharing options...
darkjohn20 Posted February 4, 2010 Share Posted February 4, 2010 These also don't look like static addresses so every time you open the game again they could possibly change. Link to comment Share on other sites More sharing options...
E1M1 Posted February 4, 2010 Author Share Posted February 4, 2010 how u get static addresses? I thought i would try get working code 1st and then i can play with addresses. edited Link to comment Share on other sites More sharing options...
darkjohn20 Posted February 4, 2010 Share Posted February 4, 2010 You have to understand how to scan for pointers. Look at some tutorials on their forum. As long as you keep the game open the whole time you find an address and try reading with AutoIt, it won't change, but if you re-open the game, it will. Link to comment Share on other sites More sharing options...
Cuervo Posted February 4, 2010 Share Posted February 4, 2010 I don't know why, but I always assume that when people post they already know what address or offset they are dealing with. Given that, I then assume the issue is not with the address or offset and thus must be an issue with the code or permissions. -Tim Link to comment Share on other sites More sharing options...
gononono64 Posted January 6, 2011 Share Posted January 6, 2011 Added: -Privileges and admin -Changed how it _MemoryOpen() a process (this is where i think your problem was) #Don't Forget To Change The Process As Said In Code# -Reorganized your code (put them in functions) -Made $Mem_Address a constant -And added a lot of comments to help you and other people out If it doesn't work... let me know expandcollapse popup#include <GUIConstants.au3> #include <NomadMemory.au3> ;because you need this for _memread functions ;~~~~~~~~~~~~~~~~~~Important for Nomad~~~~~~~~~~~~~~~~~~~~~~~~~~ #RequireAdmin ;Asks for admin rights SetPrivilege("SeDebugPrivilege", 1) ; Sets privilege ;~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Global Const $Mem_Address = 0x04FC2F25 ; <--Assumed is correct ~ if not Fix it!~ ;~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~Handle :ATTENTION!!!:~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Global $Mem_Open = _MemoryOpen(ProcessExists("Put game process here by holding CTRL ALT DEL and searching for the .exe")) ; ~cuz i dont know what it is~ if @error Then ; @error for handle MsgBox (48, "Error", "The returned @error : " & @error) Exit ; 1 = Invalid $iv_Pid. ; 2 = Failed to open Kernel32.dll. ; 3 = Failed to open the specified process. EndIf ;~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ;~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~GUI~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ GUICreate("My GUI Button") $Button_1 = GUICtrlCreateButton ("Check Memory Address", 10, 30, 150) $Label_1 = GUICtrlCreateLabel("life",20, 60) GUISetState () ;~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ While 1 $msg = GUIGetMsg() Select Case $msg = $GUI_EVENT_CLOSE ExitLoop Case $msg = $Button_1 ReadMem() CloseMem() EndSelect WEnd ;~~~~~~Made funcitons because its easier for people to see whats going on~~~~~~~~~~ Func ReadMem() $Mem_Read = _MemoryRead($Mem_Address, $Mem_Open) ;reads value at memory address GUICtrlSetData($Label_1,$Mem_Read) ; sets label to value of read memory EndFunc ; ------------ Func CloseMem() _MemoryClose($Mem_Open) ;close it afterwards EndFunc ;~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Link to comment Share on other sites More sharing options...
kaotkbliss Posted January 6, 2011 Share Posted January 6, 2011 I use win 7 ultimate 64 bit but CheatEngine is 32 bit app and Diablo II is 32 bit game and autoit I use is 32 bit version. I don't think bits are problem, but who knows.E1M1...You know better 010101000110100001101001011100110010000001101001011100110010000 001101101011110010010000001110011011010010110011100100001 My Android cat and mouse gamehttps://play.google.com/store/apps/details?id=com.KaosVisions.WhiskersNSqueek We're gonna need another Timmy! Link to comment Share on other sites More sharing options...
Recommended Posts