how to end func within func ?

[dirty]

Stuck with my code and need to end function if @error

expandcollapse popup

#include <GUIConstantsEx.au3>
#include <WindowsConstants.au3>
#RequireAdmin
Opt("TrayOnEventMode",1)
Opt("TrayMenuMode",1)
IsAdmin ( )


$Form1 = GUICreate("hosts Editor",200,440)
$hosts = (@WindowsDir & "\System32\drivers\etc\hosts")
$OpenFile = FileOpen (@ScriptDir & "\Saved\hosts", 0+1)
$fileLocalRead = FileRead(@ScriptDir & "\Saved\hosts")
GUICtrlCreateLabel ('Example:',0,6,42)
GUICtrlCreateinput ("127.0.0.1 www.google.com",43,3,157)
$Input = GUICtrlCreateEdit ($fileLocalRead,0,30,200,370)
$Button = GUICtrlCreateButton ("Save",0,400,100,40)
$ButtonCancel = GUICtrlCreateButton ("Close",100,400,100,40)

TrayCreateItem('Modify "HOSTS"')
TrayItemSetOnEvent(-1,"ModifyFunction") ;function name
TrayCreateItem('Exit')
TrayItemSetOnEvent(-1,"ExitFunction") ;function name
TraySetState()

While 1
;empty loop
WEnd

Func ModifyFunction() ;check if file exist localy. If not, copy it to local and only then start reading it and displaying it in edit box
$checkIfLocalExist = FileExists (@ScriptDir & "\Saved\hosts") ;Check if hosts is previously saved into saved folder
If $checkIfLocalExist = 0 Then ;if not, then
$CopyHostsToLocal = FileCopy ($hosts,@ScriptDir & "\Saved\hosts",0+8) ;copy hosts from system to saved folder
If @error Then MsgBox (16,"ERROR","Error Copying hosts File, it must be in use")
Escape() ;Go to end of the function is error
EndIf

$hosts = (@WindowsDir & "\System32\drivers\etc\hosts")
$fileLocalRead = FileRead(@ScriptDir & "\Saved\hosts")
GUICtrlSetData ($Input, $fileLocalRead)
$OpenFile = FileOpen (@ScriptDir & "\Saved\hosts", 0+1)
GUISetState(@SW_SHOW, $Form1)

While 1
   $msg   = GUIGetMsg()
   Switch $msg
       Case $GUI_EVENT_CLOSE
           GUISetState(@SW_HIDE, $Form1)
           ExitLoop
       Case $Button
           FileOpen (@ScriptDir & "\Saved\hosts", 2)
           $readAgain = GUICtrlRead ($Input)
           $write = FileWrite ($OpenFile, $readAgain)
        FileClose ($OpenFile)
        $replacehost = FileCopy (@ScriptDir & "\Saved\hosts", @WindowsDir & "\System32\drivers\etc\hosts", 1)
        If $write = 1 and $replacehost = 1 Then
        MsgBox(0,'','Saved')
        Else
        MsgBox(0,'','Error writing')
        Endif
            Case $ButtonCancel
        GUISetState(@SW_HIDE, $Form1)
           ExitLoop
   EndSwitch
WEnd

Func Escape() ;end of the function
    MsgBox(0,'','Try Again')
EndFunc

EndFunc

Func ExitFunction()
Exit
EndFunc

As soon as i added

If @error
Escape() ;Go to end of the function is error
Endif

Func Escape() ;end of the function
    MsgBox(0,'','Try Again')
EndFunc

i get error saying: syntax error

Func

Why ? Do i have limits naming functions or something ?

[omikron48]

You can't define functions in a function. You should bring the Func declaration outside.

expandcollapse popup

#include <GUIConstantsEx.au3>
#include <WindowsConstants.au3>
#RequireAdmin
Opt("TrayOnEventMode",1)
Opt("TrayMenuMode",1)
IsAdmin ( )


$Form1 = GUICreate("hosts Editor",200,440)
$hosts = (@WindowsDir & "\System32\drivers\etc\hosts")
$OpenFile = FileOpen (@ScriptDir & "\Saved\hosts", 0+1)
$fileLocalRead = FileRead(@ScriptDir & "\Saved\hosts")
GUICtrlCreateLabel ('Example:',0,6,42)
GUICtrlCreateinput ("127.0.0.1 www.google.com",43,3,157)
$Input = GUICtrlCreateEdit ($fileLocalRead,0,30,200,370)
$Button = GUICtrlCreateButton ("Save",0,400,100,40)
$ButtonCancel = GUICtrlCreateButton ("Close",100,400,100,40)

TrayCreateItem('Modify "HOSTS"')
TrayItemSetOnEvent(-1,"ModifyFunction") ;function name
TrayCreateItem('Exit')
TrayItemSetOnEvent(-1,"ExitFunction") ;function name
TraySetState()

While 1
;empty loop
WEnd

Func ModifyFunction() ;check if file exist localy. If not, copy it to local and only then start reading it and displaying it in edit box
    $checkIfLocalExist = FileExists (@ScriptDir & "\Saved\hosts") ;Check if hosts is previously saved into saved folder
    If $checkIfLocalExist = 0 Then ;if not, then
        $CopyHostsToLocal = FileCopy ($hosts,@ScriptDir & "\Saved\hosts",0+8) ;copy hosts from system to saved folder
        If @error Then MsgBox (16,"ERROR","Error Copying hosts File, it must be in use")
        Escape() ;Go to end of the function is error
    EndIf

    $hosts = (@WindowsDir & "\System32\drivers\etc\hosts")
    $fileLocalRead = FileRead(@ScriptDir & "\Saved\hosts")
    GUICtrlSetData ($Input, $fileLocalRead)
    $OpenFile = FileOpen (@ScriptDir & "\Saved\hosts", 0+1)
    GUISetState(@SW_SHOW, $Form1)

    While 1
        $msg   = GUIGetMsg()
        Switch $msg
            Case $GUI_EVENT_CLOSE
                GUISetState(@SW_HIDE, $Form1)
                ExitLoop
            Case $Button
                FileOpen (@ScriptDir & "\Saved\hosts", 2)
                $readAgain = GUICtrlRead ($Input)
                $write = FileWrite ($OpenFile, $readAgain)
                FileClose ($OpenFile)
                $replacehost = FileCopy (@ScriptDir & "\Saved\hosts", @WindowsDir & "\System32\drivers\etc\hosts", 1)
                If $write = 1 and $replacehost = 1 Then
                    MsgBox(0,'','Saved')
                Else
                    MsgBox(0,'','Error writing')
                Endif
            Case $ButtonCancel
                GUISetState(@SW_HIDE, $Form1)
                ExitLoop
        EndSwitch
    WEnd
EndFunc

Func Escape() ;end of the function
    MsgBox(0,'','Try Again')
EndFunc

Func ExitFunction()
    Exit
EndFunc

EDIT: Also learn to use proper indentation for nested statements so your code is not an eyesore to look at and a brain twister to read.

Edited February 5, 2010 by omikron48

[Minikori]

If @error Then Return 0

[BrettF]

Even better

If @error Return SetError (1, 2, 3)

[Minikori]

Either way, much simpler than what you tried :|

Edited February 5, 2010 by Minikori

[dirty]

EDIT: Also learn to use proper indentation for nested statements so your code is not an eyesore to look at and a brain twister to read.

What do you mean, variable names or what ? I thought variable names can be anything i want

Then where do i get appropriate names ? or am i doing something else wrong ?

If @error Return SetError (1, 2, 3) ?

then what happens ? Would it jump to the end of current function ?

Thanks guys

Edited February 5, 2010 by dirty

[Jos]

If @error Return SetError (1, 2, 3) ?

then what happens ? Would it jump to the end of current function ?

It returns to the statement that called this Func. Edited February 5, 2010 by Jos

[omikron48]

I meant follow coding convention when you post code online, like indenting lines depending on their nest level in the code so it's easier to follow.

Kinda like:

If <condition> Then
    <statement1>
    ...
    <statementn>
EndIf

Or

If <condition1> Then
    <statement1>
    If <condition2> Then
        <statementA>
        ...
        <statementZ>
    EndIf
    ...
    <statementn>
EndIf

Doing so makes it clear which lines of code are inside conditionals, loops or function declarations.

Edited February 5, 2010 by omikron48

[dirty]

I meant follow coding convention when you post code online, like indenting lines depending on their nest level in the code so it's easier to follow.Doing so makes it clear which lines of code are inside conditionals, loops or function declarations.

Ah ok, i thought something else was wrong.

Its just the way i like thing, all aligned to the left but OK

[GEOSoft]

It returns to the statement that called this Func.

Actually it would fail entirely with an error because of the missing "Then"

[dirty]

Actually it would fail entirely with an error because of the missing "Then"

hhmm interestin.

You mean it would jump back to

If @error Then MsgBox (16,"ERROR","Error Copying hosts File, it must be in use")

? sorry im not sure what statement is

[GEOSoft]

hhmm interestin.

You mean it would jump back to

If @error Then MsgBox (16,"ERROR","Error Copying hosts File, it must be in use")

? sorry im not sure what statement is

What you wrote in this post is correct. Your first post had left out the "Then" keyword as in

if @Error Return..Which will fail and throw a syntax error