Jump to content

Stuck in an Infinite Loop!!


Recommended Posts

Hi All!

I've come to a stop on working on one of my scripts, due to a Infinite loop I can't figure out. To make it simpler I've made an example script, so I don't have to post the whole thing..

#Include <string.au3>
#Include <Array.au3>
#include <IE.au3>

$oIE = _IE_Example ("form")

$Bodytext = _IEBodyReadHTML ( $oIE )
$Bodytextproper = _StringProper ($Bodytext)

$MainArray = _StringExplode ($Bodytextproper, "<Br>")
$TempString = _ArrayToString($MainArray, @CRLF,0 ,0)
$MainArray = _StringExplode ($TempString, "<Td>")
$TempString = _ArrayToString($MainArray, @CRLF,0 ,0)
$MainArray = _StringExplode ($TempString, "<Tr>")
$TempString = _ArrayToString($MainArray, @CRLF,0 ,0)
$MainArray = _StringExplode ($TempString, @CRLF)
$TempString = _ArrayToString($MainArray, @CRLF,0 ,0)
$MainArray = _StringExplode ($TempString, @CRLF)
$size= Ubound($Mainarray)

_ArrayDisplay ($MainArray)


For $Step = 1 to $size 

    ConsoleWrite($Step & @CRLF)
    $Todo = _ArrayToString($Mainarray, @CRLF, $Step, $Step)
    ConsoleWrite($Todo & @CRLF)
    $Check = StringLen($Todo)
    ConsoleWrite($Check & @CRLF)
    If $Check < 9 Then
        _ArrayDelete( $MainArray, $Step)
        $Step = -1
    Endif
    $Step = +1
        _ArrayDisplay ($MainArray)
Next
_ArrayDisplay ($MainArray)

This code Should "clean up" this HTML source code, but instead, it get's stuck. It shows the Array the first time (before the loop), with a lot of Non entries (entries containing 8 or less characters). The point of the loop is to check each array entry if it's too short, after wich it deletes it from the array. The array decreases in size after deleting, so that's where the $Step = -1 comes in.. It work's fine until, the scripts checks the entrie ExampleForm, on position 2. For some reason it does show it's longer then <9, but it won't go to the next step.. So it doesn't delete the entry, it just subtracts 1 from the $Step..

Also, if I change the If $Check < 9 Then to $Check < 5, it has the same problem with the array entry <body>, wich is 7 characters long, and should be skipped as well..

Many thanks in advance!

Thomas

Link to comment
Share on other sites

  • Moderators

ThomasQ,

If you want to delete elements from an array while actually running through it, you MUST start at the bottom and work up - otherwise you get into all sorts of problems (as I know from bitter personal experience until someone showed me what to do!) :)

This works nicely for me:

#Include <string.au3>
#Include <Array.au3>
#include <IE.au3>

$oIE = _IE_Example ("form")

$Bodytext = _IEBodyReadHTML ( $oIE )
$Bodytextproper = _StringProper ($Bodytext)

$MainArray = _StringExplode ($Bodytextproper, "<Br>")
$TempString = _ArrayToString($MainArray, @CRLF,0 ,0)
$MainArray = _StringExplode ($TempString, "<Td>")
$TempString = _ArrayToString($MainArray, @CRLF,0 ,0)
$MainArray = _StringExplode ($TempString, "<Tr>")
$TempString = _ArrayToString($MainArray, @CRLF,0 ,0)
$MainArray = _StringExplode ($TempString, @CRLF)
$TempString = _ArrayToString($MainArray, @CRLF,0 ,0)
$MainArray = _StringExplode ($TempString, @CRLF)
$size= Ubound($Mainarray)

_ArrayDisplay ($MainArray)

For $i = $size - 1 To 0 Step -1
    If StringLen($MainArray[$i]) < 9 Then _ArrayDelete($MainArray, $i)
Next

_ArrayDisplay ($MainArray)

I hope it does for you too. :(

M23

Public_Domain.png.2d871819fcb9957cf44f4514551a2935.png Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind

Open spoiler to see my UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...