Were i'm i going wrong with this script?

[mfurman]

I'm exploring and learning more of Autoit and i'm writing a script that will return the type of windows the customer has. The variable is being passed to the IF statement but it is crashing on comparison to the value in the variable

$os = @OSVersion

IF $os == WIN_XP Then
    MsgBox ( 1, "version of windows", "You have: Windows XP")
ElseIf $os == WIN_VISTA Then
    MsgBox ( 1, "version of windows", "You have: Windows Vista")
ElseIF $0s == WIN_7 Then
    MsgBox ( 1, "version of windows", "You have: Windows 7")
EndIf

[PsaltyDS]

Put quotes around your literal strings:

IF $os == "WIN_XP" Then

[Tvern]

And $0s should be $os (line 7)

[GEOSoft]

Another method

$os = StringRegExpReplace(@OSVersion, "^.+_(.+)$", "$1")
MsgBox ( 1, "version of windows", "You have: Windows " & $os)

[mfurman]

thank you everyone for your help

[mfurman]

Geosoft, that looks pretty cool I just have no idea what that means yet i'm fairly new to programming and scripting in general

[GEOSoft]

Geosoft, that looks pretty cool I just have no idea what that means yet i'm fairly new to programming and scripting in general

It takes @OSVersion apart as follows

^ = Start at the beginning of the string (not really required in this case)

.+_ = match but don't capture anything up to and including the underscore

(.+) = match and capture everything up to..

$ = the end of the string (again, this time it's not required but better to use it)

$1 = Replace the whole string with the captured group.

So in the case of Win_Vista, it won't bother capturing Win_ but it will capture Vista and then it replaces the whole string with Vista and that's what gets returned as $os.

RegEx and RegExReplace are powerfull (even if overused) tools and are ideal for this situation.

I could have done the same thing with

$os = StringMid(@OSVersion, StringInStr(@OSVersion, "_") +1)