Exit loop without running a line of code

[WundaGirl]

Hello I found this code and I want it to run a command when the timer is at the end of the countdown or cancel if the button is pressed. I was wondering if someone could help me understand how to make that happen currently if the user hits cancel the countdown timer is stopped but the script continues execute the run command. How can I make so that when someone hits cancel.

thanks

Obviously I a new to this.

Thanks

#include <GUIConstants.au3>
#include <WindowsConstants.au3>
#include <StaticConstants.au3>
#include <EditConstants.au3
;milliseconds for timer, start the timer and label text
$ms = 10000 ;3601000
$timer = TimerInit()
$labeltext = "The  IT department is applying updates to your computer..."
;
;gui window with text, Install Now button and timer window
GUICreate("Software Updates", 350, 330, -1, -1, $WS_DLGFRAME, $WS_EX_TOPMOST)
$Cancel = GUICtrlCreateButton ("Cancel", 100, 250, 150, 50)
$Label = GUICtrlCreateLabel($labeltext, 10, 10, 330, 200)
$Input = GUICtrlCreateInput("", 140, 225, 75, 20, BitOr($SS_CENTER, $ES_READONLY))
GUISetState (@SW_SHOW)
;
;wait for timer to expire or for Install Now button to be clicked
;each time around the loop, it will update the timer displayed on the screen
;
While (TimerDiff($timer) < $ms) and (GUIGetMsg() <> $Cancel)
;
$seconds = TimerDiff($timer)/1000
$diff = $seconds - ($ms/1000)
;
$minutes = Int($diff / 60)
$secondsRem = $diff - ($minutes * 60)
;
$minutes = $minutes * -1
$secondsRem = $secondsRem * -1
$time = StringFormat("%02d", $minutes) & ":" & StringFormat("%02d", $secondsRem)
 If GUIGetMsg() = $Cancel then ExitLoop
GUICtrlSetData($Input, $time)
;

WEnd
Run("calc.exe")

[anixon]

Hello I found this code and I want it to run a command when the timer is at the end of the countdown or cancel if the button is pressed. I was wondering if someone could help me understand how to make that happen currently if the user hits cancel the countdown timer is stopped but the script continues execute the run command. How can I make so that when someone hits cancel.

thanks

Obviously I a new to this.

Thanks

#include <GUIConstants.au3>
#include <WindowsConstants.au3>
#include <StaticConstants.au3>
#include <EditConstants.au3
;milliseconds for timer, start the timer and label text
$ms = 10000 ;3601000
$timer = TimerInit()
$labeltext = "The  IT department is applying updates to your computer..."
;
;gui window with text, Install Now button and timer window
GUICreate("Software Updates", 350, 330, -1, -1, $WS_DLGFRAME, $WS_EX_TOPMOST)
$Cancel = GUICtrlCreateButton ("Cancel", 100, 250, 150, 50)
$Label = GUICtrlCreateLabel($labeltext, 10, 10, 330, 200)
$Input = GUICtrlCreateInput("", 140, 225, 75, 20, BitOr($SS_CENTER, $ES_READONLY))
GUISetState (@SW_SHOW)
;
;wait for timer to expire or for Install Now button to be clicked
;each time around the loop, it will update the timer displayed on the screen
;
While (TimerDiff($timer) < $ms) and (GUIGetMsg() <> $Cancel)
;
$seconds = TimerDiff($timer)/1000
$diff = $seconds - ($ms/1000)
;
$minutes = Int($diff / 60)
$secondsRem = $diff - ($minutes * 60)
;
$minutes = $minutes * -1
$secondsRem = $secondsRem * -1
$time = StringFormat("%02d", $minutes) & ":" & StringFormat("%02d", $secondsRem)
If GUIGetMsg() = $Cancel then ExitLoop
GUICtrlSetData($Input, $time)
;

WEnd
Run("calc.exe")

[GEOSoft]

Hello I found this code and I want it to run a command when the timer is at the end of the countdown or cancel if the button is pressed. I was wondering if someone could help me understand how to make that happen currently if the user hits cancel the countdown timer is stopped but the script continues execute the run command. How can I make so that when someone hits cancel.

thanks

Obviously I a new to this.

Thanks

#include <GUIConstants.au3>
#include <WindowsConstants.au3>
#include <StaticConstants.au3>
#include <EditConstants.au3
;milliseconds for timer, start the timer and label text
$ms = 10000 ;3601000
$timer = TimerInit()
$labeltext = "The  IT department is applying updates to your computer..."
;
;gui window with text, Install Now button and timer window
GUICreate("Software Updates", 350, 330, -1, -1, $WS_DLGFRAME, $WS_EX_TOPMOST)
$Cancel = GUICtrlCreateButton ("Cancel", 100, 250, 150, 50)
$Label = GUICtrlCreateLabel($labeltext, 10, 10, 330, 200)
$Input = GUICtrlCreateInput("", 140, 225, 75, 20, BitOr($SS_CENTER, $ES_READONLY))
GUISetState (@SW_SHOW)
;
;wait for timer to expire or for Install Now button to be clicked
;each time around the loop, it will update the timer displayed on the screen
;
While (TimerDiff($timer) < $ms) and (GUIGetMsg() <> $Cancel)
;
$seconds = TimerDiff($timer)/1000
$diff = $seconds - ($ms/1000)
;
$minutes = Int($diff / 60)
$secondsRem = $diff - ($minutes * 60)
;
$minutes = $minutes * -1
$secondsRem = $secondsRem * -1
$time = StringFormat("%02d", $minutes) & ":" & StringFormat("%02d", $secondsRem)
 If GUIGetMsg() = $Cancel then ExitLoop
GUICtrlSetData($Input, $time)
;

WEnd
Run("calc.exe")

expandcollapse popup

#include <GUIConstants.au3>
#include <WindowsConstants.au3>
#include <StaticConstants.au3>
#include <EditConstants.au3
;milliseconds for timer, start the timer and label text
$ms = 10000 ;3601000
$timer = TimerInit()
Local $iRun = True
$labeltext = "The  IT department is applying updates to your computer..."
;
;gui window with text, Install Now button and timer window
GUICreate("Software Updates", 350, 330, -1, -1, $WS_DLGFRAME, $WS_EX_TOPMOST)
$Cancel = GUICtrlCreateButton ("Cancel", 100, 250, 150, 50)
$Label = GUICtrlCreateLabel($labeltext, 10, 10, 330, 200)
$Input = GUICtrlCreateInput("", 140, 225, 75, 20, BitOr($SS_CENTER, $ES_READONLY))
GUISetState (@SW_SHOW)
;
;wait for timer to expire or for Install Now button to be clicked
;each time around the loop, it will update the timer displayed on the screen
;
While (TimerDiff($timer) < $ms) and (GUIGetMsg() <> $Cancel)
;
$seconds = TimerDiff($timer)/1000
$diff = $seconds - ($ms/1000)
;
$minutes = Int($diff / 60)
$secondsRem = $diff - ($minutes * 60)
;
$minutes = $minutes * -1
$secondsRem = $secondsRem * -1
$time = StringFormat("%02d", $minutes) & ":" & StringFormat("%02d", $secondsRem)
 If GUIGetMsg() = $Cancel then
    $iRun = False
    ExitLoop
 EndIf
GUICtrlSetData($Input, $time)
;

WEnd
If $iRun Then Run("calc.exe")

[JohnOne]

At first glance I would say

While (TimerDiff($timer) < $ms) and (GUIGetMsg() <> $Cancel)

needs to be

While (TimerDiff($timer) < $ms) Or (GUIGetMsg() <> $Cancel)

[anixon]

You can simply set a variable flag set by the cancel process and then have the 'Run' conditional upon the process flag as set.

..........

Local $SetFlag = 0

If GUIGetMsg() = $Cancel then

$SetFlag = 1

Exitloop

Endif

Wend

If $SetFlag = 0 Then Run("Calc.exe)"

Ant..

Edited June 14, 2010 by anixon

[WundaGirl]

HI anixon

I tried adding this

Local $SetFlag = 0

If GUIGetMsg() = $Cancel then

$SetFlag = 1

Exitloop

Endif

Wend

If $SetFlag = 0 Then Run("Calc.exe)"

I got this message

(39) : ==> Error parsing function call.

[czardas]

At a glance: this line is badly formatted =>

If $SetFlag = 0 Then Run("Calc.exe)"

Should be =>

If $SetFlag = 0 Then Run("Calc.exe")

Whether it solves your problem, I'm not sure.

[czardas]

GEOSofts solution works fine. It just misses a closing (>) tag on the 4th line. =>

#include <EditConstants.au3>

[WundaGirl]

Geosoft

Your solution works perfectly thank you.

[GEOSoft]

You're most welcome

[GEOSoft]

GEOSofts solution works fine. It just misses a closing (>) tag on the 4th line. =>

#include <EditConstants.au3>

You thought you caught me didn't you?

Actually I should have noticed it mising in the original code but all I did was a C&P and then made the obvious changes.

[czardas]

Not really. I noticed that after I looked for a second time. There still seems to be some odd behaviour though. It intermittently seems to not be working. That could have something to do with hitting the cancel button at an inconvenient moment. Or it could just be my computer, but I doubt that. I'm trying to figure out why, or if it's just me. Run it a few times hitting the cancel button at different time intervals and see if the calculator starts.

I think I've figured it out.

This line => While (TimerDiff($timer) < $ms) and (GUIGetMsg() <> $Cancel)

expandcollapse popup

#include <GUIConstants.au3>
#include <WindowsConstants.au3>
#include <StaticConstants.au3>
#include <EditConstants.au3>
;milliseconds for timer, start the timer and label text
$ms = 10000 ;3601000
$timer = TimerInit()
Local $iRun = True
$labeltext = "The  IT department is applying updates to your computer..."
;
;gui window with text, Install Now button and timer window
GUICreate("Software Updates", 350, 330, -1, -1, $WS_DLGFRAME, $WS_EX_TOPMOST)
$Cancel = GUICtrlCreateButton ("Cancel", 100, 250, 150, 50)
$Label = GUICtrlCreateLabel($labeltext, 10, 10, 330, 200)
$Input = GUICtrlCreateInput("", 140, 225, 75, 20, BitOr($SS_CENTER, $ES_READONLY))
GUISetState (@SW_SHOW)
;
;wait for timer to expire or for Install Now button to be clicked
;each time around the loop, it will update the timer displayed on the screen
;
While (TimerDiff($timer) < $ms)
;
$seconds = TimerDiff($timer)/1000
$diff = $seconds - ($ms/1000)
;
$minutes = Int($diff / 60)
$secondsRem = $diff - ($minutes * 60)
;
$minutes = $minutes * -1
$secondsRem = $secondsRem * -1
$time = StringFormat("%02d", $minutes) & ":" & StringFormat("%02d", $secondsRem)
 If GUIGetMsg() = $Cancel then
    $iRun = False
    ExitLoop
 EndIf
GUICtrlSetData($Input, $time)
;

WEnd
If $iRun Then Run("calc.exe")

Update: Also added the line => Local $iRun = True

Edited June 14, 2010 by czardas

[GEOSoft]

Not really. I noticed that after I looked for a second time. There still seems to be some odd behaviour though. It intermittently seems to not be working. That could have something to do with hitting the cancel button at an inconvenient moment. Or it could just be my computer, but I doubt that. I'm trying to figure out why, or if it's just me. Run it a few times hitting the cancel butten at different time intervals and see if the calculator starts.

I think I've figured it out.

No time to play with it at the moment. I'm busy uploading a bug fix version of the PCRE Toolkit. Maybe later.

I suspect that if either of us was to sit and re-write the whole thing, there wouldn't be a problem. It's easy to overlook something when you're just reading someone elses code.

[czardas]

I suspect that if either of us was to sit and re-write the whole thing, there wouldn't be a problem. It's easy to overlook something when you're just reading someone elses code.

It's nice of you to show confidence in me. Anyway I just changed one line of code above, and it seems stable.

[GEOSoft]

It's nice of you to show confidence in me. Anyway I just changed one line of code above, and it seems stable.

And why wouldn't I be confident? You've been around for 6 years and I've had ample opportunity to see what you can do.

Good to see it's stable now.

Edit: BTW, some of that credit should go to JohnOne as well since he is the first to point out that bad line.

Edited June 14, 2010 by GEOSoft

[czardas]

Thanks, I was just tinkering again with it. Broke it and fixed it again.

Edit: BTW, some of that credit should go to JohnOne as well since he is the first to point out that bad line.

So he did! I hadn't noticed that. Edited June 14, 2010 by czardas