A big problem

[bravojohhny]

Hello, I've got this big problem with this piece of code:

Case $Button3
        $open1 = FileOPen($file1, 0)
        $read1 = FileReadLine($open1)
        $a1= StringSplit($read1, ",")
        $open2 = FileOpen($file2, 0)
        $read2= FileReadLine($open2)
        $a2= StringSplit($read2, ",")
        $i=0
        Do
            $i = $i+1
            _ArraySearch($a1, $a2[$i])
            MsgBox(64, "", "Now searching for: "&$a2[$i])
            If @error Then
                MsgBox(64,"", "Couldn't find "&$a2[$i]&" continue")
            Else 
                MsgBox(64,"","Found: "&$a2[$i]&" - now erasing")
            _ArrayDelete($a1, $a2[$i])
            EndIf
        Until $i = UBound($a2)
        _ArrayDisplay($a1)

The code works but when it finishes the deleting I get this error:

C:\Documents and Settings\Admin\Local Settings\Temp\test.au3 (40) : ==> Array variable has incorrect number of subscripts or subscript dimension range exceeded.:

_ArraySearch($a1, $a2[$i])

_ArraySearch($a1, ^ ERROR

>Exit code: 1 Time: 6.034

How can I fix this?

[Melba23]

bravojohhny,

Your problem lies in this line:

Until $i = UBound($a2)

Remember that AutoIt arrays start at 0, so a 4 element array has the indices 0, 1, 2, 3.

UBound returns the number of elements in the array (4), not the highest index (3) - and yes I agree it should have been called something else when it was introduced into the language.

So if you wait until the count reaches the number of elements, you are one over the highest index and when you try to access it, you get an error.

Try using

Until $i = UBound($a2) - 1

All clear?

M23

[bravojohhny]

^Hei thanks, you're a life saver!