While > Wend and Case

[Chimaera]

Hi all

Working on a script and i have a large while > wend and i wondered if there was a maximum amount of case allowed within it?

Ive prob got about 100 Case statements in it all for button presses to excute a file or webpage etc

Since i added last dew its gone pear shaped giving me undefined function errors

If i #cs the last lot all is fine, so i was wondering if i had hit a limit?

Ive checked and rechecked and all seems fine on the text side

Is it possible to split them into smaller wends maybe?

The last time i tried the while =1 on both conflicted, unless im doing it wrong which is very possible

[JohnOne]

I'm going to assume you you mean Switch...Case...EndSwitch.

There is nothing in the helpfile to indicate a limit.

If you are fetting an undefined function error, I would imagine the problem is just that.

[Melba23]

Chimaera,

Ive prob got about 100 Case statements in it

Although I do not believe you have hit a limit, I would suggest that you are not coding in the most efficient manner.

Perhaps if you posted the script so we could offer a different (and possibly better) way?

M23

[Chimaera]

Ok it goes a bit like this

in the gui

$install_but_1 = GUICtrlCreateButton("Full Install", 40, 300, 120)

then lower down

While 1
    Switch GUIGetMsg()
        Case $GUI_EVENT_CLOSE
            _Exit()
;==> Tab 1
        Case $install_but_1
            _install_but_1()
        Case $install_but_2
            _install_but_2()
;etc etc until
        Case $install_but_25
            _install_but_25()
        Case $install_but_26
            _install_but_26()
; then a few of these
        Case $tech_but_1
            _tech_but_1()
        Case $tech_but_2

; and so on till about 100 buttons
;and each one of them has one of these that it represents

Func _install_but_1() ;==; Start VLC Install
        RunWait(@ScriptDir & "\file_includes\install\install_vlc.exe")
EndFunc   ;==> End VLC Install

that should give you the rough idea, the gui has 3 tabs and a lot of buttons

Chimaera

Edited November 5, 2010 by Chimaera

[BrewManNH]

You could change all of your buttons into check boxes that have the installs you want to do tied to them. Then all you'd have to do is check off the ones that you wanted to use, scan all of the checked ones into an array, and parse the array one element at a time to find out which to install. Might make it a little easier for the user instead of hitting one button at a time and one install at a time.

[Melba23]

Chimaera,

BrewManNH has taken the words right out of my mouth!

M23

[cageman]

Other option is to just make some excel code that generates the required code for all cases. Just an idea if you don't want the check boxes. This idea takes you 5 minutes max although its depending on your excel skills.

[ProgAndy]

Other option is to just make some excel code that generates the required code for all cases. Just an idea if you don't want the check boxes. This idea takes you 5 minutes max although its depending on your excel skills.

What is excel code? Do you mean VBA? Then you could create an AutoIt-Script for the same task, too

[Chimaera]

Ok thats a possibility it might reduce the overall size of the tool as well because the checkboxes take less room.

Can you give an example how to tie a install to a checkbox plz?

;==> Tab 1
        Case $install_but_1
            _install_but_1()
;--;
Func _install_but_1() ;==; Start VLC Install
        RunWait(@ScriptDir & "\file_includes\install\install_vlc.exe")
EndFunc   ;==> End VLC Install

Does the checkbox still use the same function call?

#include <GUIConstants.au3>

GUICreate("My GUI Checkbox")  ; will create a dialog box that when displayed is centered

GUICtrlCreateCheckbox ("Antivirus", 10, 10, 120, 20)
GUICtrlCreateCheckbox ("Malware", 10, 30, 120, 20)

GUISetState ()       ; will display an  dialog box with 1 checkbox

; Run the GUI until the dialog is closed
While 1
    $msg = GUIGetMsg()

    If $msg = $GUI_EVENT_CLOSE Then ExitLoop
Wend

found this bit, why does it need the while > wend is it for the detection of which boxes are ticked?

Btw ive never used a checkbox or array before

Thanks for the answers

Chimaera

[BrewManNH]

Here's something I whipped up that should help you in understanding a part of what you can do with check boxes and arrays.

The $CBR array isn't really needed because you could directly access the check box state using GUICtrlRead but you could use this as an example and use the $CBR array later in the script to store the state of the check boxes in case something gets changed after clicking the read button. You can see that for yourself by changing the state of one or more of the checked boxes after you have hit the read button and the MsgBox is showing, the Array will keep the state of the checked box regardless of whether it gets changed later or not.

Here's the example script.

#include <guiconstants.au3>
Global $CB[10], $CBR[10]
$Main = GUICreate("Test", 300, 300, -1, -1)
For $I = 0 To 9
    $CB[$I] = GUICtrlCreateCheckbox("Check box " & $I + 1, 10, 20 * $I)
Next
$Read = GUICtrlCreateButton(" Read ", 200, 50)
GUISetState()
While 1
    $msg = GUIGetMsg()
    Switch $msg
        Case $Read
            _ReadCheckboxes()
        Case $GUI_EVENT_CLOSE
            Exit
    EndSwitch
    Sleep(20)
WEnd
Func _ReadCheckBoxes()
    For $I = 0 To 9
        $CBR[$I] = GUICtrlRead($CB[$I])
    Next
    For $I = 0 To 9
        If $CBR[$I] = 1 Then
            MsgBox(64, "Check box " & $I + 1, "Check box #" & $I + 1 & " is checked")
        Else
            MsgBox(64, "Check box " & $I + 1, "Check box #" & $I + 1 & " is not checked")
        EndIf
    Next
EndFunc   ;==>_ReadCheckBoxes

[Chimaera]

Thanks for trying to help BrewManNH

I will go and try and understand but based on what you have written very little of it makes sense i apologise but im not the sharpest tool in the box with code.

The reason i was as far as i was was more down to previous questions and help from Melba23 than anything else.

I will go and decipher as i can

Thanks for taking the trouble to write that piece

and thanks for the replys from everyone else

Chimaera