my case(s) are running by themselves

[supadodger]

expandcollapse popup

$top = 10
for $r = 1 to 35
$Label[$r] = GUICtrlCreateLabel("http://www.google.com", 30), 0, $top, 209, 20)
$Link[$r] = "http://www.google.com"
$top = $top + 15
Next
While 1
$nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit
        Case $Label[1]
            ShellExecute($Link[1])
        Case $Label[2]
            ShellExecute($Link[2])
        Case $Label[3]
            ShellExecute($Link[3])
        Case $Label[4]
            ShellExecute($Link[4])
        Case $Label[5]
            ShellExecute($Link[5])
        Case $Label[6]
            ShellExecute($Link[6])
        Case $Label[7]
            ShellExecute($Link[7])
        Case $Label[8]
            ShellExecute($Link[8])
        Case $Label[9]
            ShellExecute($Link[9])
        Case $Label[10]
            ShellExecute($Link[10])
        Case $Label[11]
            ShellExecute($Link[11])
        Case $Label[12]
            ShellExecute($Link[12])
        Case $Label[13]
            ShellExecute($Link[13])
        Case $Label[14]
            ShellExecute($Link[14])
        Case $Label[15]
            ShellExecute($Link[15])
        Case $Label[16]
            ShellExecute($Link[16])
        Case $Label[17]
            ShellExecute($Link[17])
        Case $Label[18]
            ShellExecute($Link[18])
        Case $Label[19]
            ShellExecute($Link[19])
        Case $Label[20]
            ShellExecute($Link[20])
        Case $Label[21]
            ShellExecute($Link[21])
        Case $Label[22]
            ShellExecute($Link[22])
        Case $Label[23]
            ShellExecute($Link[23])
        Case $Label[24]
            ShellExecute($Link[24])
        Case $Label[25]
            ShellExecute($Link[25])
        Case $Label[26]
            ShellExecute($Link[26])
        Case $Label[27]
            ShellExecute($Link[27])
        Case $Label[28]
            ShellExecute($Link[28])
        Case $Label[29]
            ShellExecute($Link[29])
        Case $Label[30]
            ShellExecute($Link[30])
        Case $Label[31]
            ShellExecute($Link[31])
        Case $Label[32]
            ShellExecute($Link[32])
        Case $Label[33]
            ShellExecute($Link[33])
        Case $Label[34]
            ShellExecute($Link[34])
        Case $Label[35]
            ShellExecute($Link[35])
    EndSwitch
Wend

during this loop its constantly shell executing even if i dont click anything...

Edited November 21, 2010 by supadodger

[taietel]

You have to exit from the function or put an ExitLoop at the end of the statement.

[supadodger]

You have to exit from the function or put an ExitLoop at the end of the statement.

they shouldnt shellexecute unless i click one of them though...

[taietel]

Something like this?

expandcollapse popup

#include <GUIConstantsEx.au3>


#include <WindowsConstants.au3>
#include <StaticConstants.au3>
GUICreate("Form", 625, 443, 192, 124)
Global $Label[11], $Link[11]
$top = 10
for $r = 1 to 10
    $Link[$r]="http://www.google.com"
$Label[$r] = GUICtrlCreateLabel($Link[$r], 30, $top, 209, 20,$SS_NOTIFY)
$top = $top + 25
Next
GUISetState(@SW_SHOW)
While 1
    Sleep(10)
$nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit
        Case $Label[1]
            ShellExecute($Link[1])
        Case $Label[2]
            ShellExecute($Link[2])
        Case $Label[3]
            ShellExecute($Link[3])
        Case $Label[4]
            ShellExecute($Link[4])
        Case $Label[5]
            ShellExecute($Link[5])
        Case $Label[6]
            ShellExecute($Link[6])
        Case $Label[7]
            ShellExecute($Link[7])
        Case $Label[8]
            ShellExecute($Link[8])
        Case $Label[9]
            ShellExecute($Link[9])
        Case $Label[10]
            ShellExecute($Link[10])
    EndSwitch
Wend

[BrewManNH]

Does that piece of code even work for you? As it's written, your label create line is written wrong you have a rogue parentheses in it, and your $top variable is in the wrong place. Adding this snippet to a GUI and declaring the arrays, and it works just fine for me. Except I get an error for some reason, that it's trying to find a file with the name of your link, even though the link opens in my browser.

[taietel]

For me, not at first time. After correcting/adding the GUI stuff, fixing the arrays, it worked. BrewManNH, the error was from the $Link array (wasn't declared either). 

supadodger, it is much easier for other users that you post a functional code and see why it's not working, than adding variables etc.

[BrewManNH]

@taietel

I was referring to the OP, your's was posted while I was responding to him.

[taietel]

@BrewManNH, I know you were referring to the OP.  That error with the link took me some time to figure it out.

M.I.

[MvGulik]

General: If your using a lot of cases in a gui-msgloop you might like to add a empty "case 0" at the top of it. (little cpu saver)

[GEOSoft]

General: If your using a lot of cases in a gui-msgloop you might like to add a empty "case 0" at the top of it. (little cpu saver)

Or a "Case Else" at the bottom of it. Also don't forget that the Msg moop has a built in delay to save the cpu usage anyway.

[MvGulik]

Or a "Case Else" at the bottom of it.

No. As zero is the most common return value the point is to cut the switch process short when there is nothing to do in the first place. Edited November 21, 2010 by MvGulik

[Mat]

The most common reason for a case in a message loop being triggered when you don't want it to is when creating a control fails. As a result, zero is returned. As a result, whenever there is no message, it triggers the code for that control.

In this case I won't even bother pointing out all the improvements that can be made in the code, other than to say that i'd use a FOR loop in a Case Else for all the labels.