Rabbitman Posted December 16, 2010 Share Posted December 16, 2010 Ok this really annoys me. So i have an error, but the thing is it says While Statement with no WEnd statement. Well look at my script:Notice how i do have it right? 2 Whiles and 2 WEnds... I wish they would make it so it ACTUALLY TELLS YOU A CORRECT ERROR! I HAVE WASTED 2 HOURS TRYING TO FIGURE OUT MY ERROR!!! Anyways, could someone please correct my script? i have a gui but im not showing it cuz its too big... expandcollapse popupHotKeySet("{Esc}", "ExitProg") HotKeySet("{F3}", "StartStop") HotKeySet("{PAUSE}", "Click") Dim $On, $click $click = False $On = False While 1 $msg = GUIGetMsg() If $msg = $Button2 Then MsgBox(0, "Help", "Read the README") EndIf While 1 If $click = True Then MouseClick("left") EndIf If $On = True Then Send("{Z down}") Sleep(10) Send("{Z up}") Sleep(10) EndIf WEnd Func StartStop() If $On = False Then $On = True Else $On = False EndIf EndFunc Func Click() If $click = False Then $click = True Else $click = False EndIf EndFunc Func ExitProg() Exit 0;;Exits the program EndFunc WEndThanks Link to comment Share on other sites More sharing options...
Developers Jos Posted December 16, 2010 Developers Share Posted December 16, 2010 (edited) Learn to format your script correctly... run Tidy to help you and see the errors it finds. Tidy is part of the Full SciTE4AutoIt3 installer. (Ctrl+T) Jos Edited December 16, 2010 by Jos SciTE4AutoIt3 Full installer Download page - Beta files Read before posting How to post scriptsource Forum etiquette Forum Rules Live for the present, Dream of the future, Learn from the past. Link to comment Share on other sites More sharing options...
guinness Posted December 16, 2010 Share Posted December 16, 2010 You have to remove those 2 Functions outside of the main While..WEnd Loop. As Jos said use his brilliant program and this will point out the problem.Plus if you do use the Full Version of SciTE add this #AutoIt3Wrapper_Au3Check_Parameters=-d -w 1 -w 2 -w 3 -w 4 -w 5 -w 6 to the top of Script to find all problems, including not declaring Variables.New Code:expandcollapse popupHotKeySet("{Esc}", "ExitProg") HotKeySet("{F3}", "StartStop") HotKeySet("{PAUSE}", "Click") Global $On, $click, $Button2 ; I tend to use only Local (in a Function) & Global (where the Variable is required multiple times.) $click = False $On = False While 1 $msg = GUIGetMsg() If $msg = $Button2 Then MsgBox(0, "Help", "Read the README") EndIf While 1 If $click = True Then MouseClick("left") EndIf If $On = True Then Send("{Z down}") Sleep(10) Send("{Z up}") Sleep(10) EndIf WEnd WEnd Func StartStop() If $On = False Then $On = True Else $On = False EndIf EndFunc ;==>StartStop Func Click() If $click = False Then $click = True Else $click = False EndIf EndFunc ;==>Click Func ExitProg() Exit 0;;Exits the program EndFunc ;==>ExitProg UDF List: _AdapterConnections() • _AlwaysRun() • _AppMon() • _AppMonEx() • _ArrayFilter/_ArrayReduce • _BinaryBin() • _CheckMsgBox() • _CmdLineRaw() • _ContextMenu() • _ConvertLHWebColor()/_ConvertSHWebColor() • _DesktopDimensions() • _DisplayPassword() • _DotNet_Load()/_DotNet_Unload() • _Fibonacci() • _FileCompare() • _FileCompareContents() • _FileNameByHandle() • _FilePrefix/SRE() • _FindInFile() • _GetBackgroundColor()/_SetBackgroundColor() • _GetConrolID() • _GetCtrlClass() • _GetDirectoryFormat() • _GetDriveMediaType() • _GetFilename()/_GetFilenameExt() • _GetHardwareID() • _GetIP() • _GetIP_Country() • _GetOSLanguage() • _GetSavedSource() • _GetStringSize() • _GetSystemPaths() • _GetURLImage() • _GIFImage() • _GoogleWeather() • _GUICtrlCreateGroup() • _GUICtrlListBox_CreateArray() • _GUICtrlListView_CreateArray() • _GUICtrlListView_SaveCSV() • _GUICtrlListView_SaveHTML() • _GUICtrlListView_SaveTxt() • _GUICtrlListView_SaveXML() • _GUICtrlMenu_Recent() • _GUICtrlMenu_SetItemImage() • _GUICtrlTreeView_CreateArray() • _GUIDisable() • _GUIImageList_SetIconFromHandle() • _GUIRegisterMsg() • _GUISetIcon() • _Icon_Clear()/_Icon_Set() • _IdleTime() • _InetGet() • _InetGetGUI() • _InetGetProgress() • _IPDetails() • _IsFileOlder() • _IsGUID() • _IsHex() • _IsPalindrome() • _IsRegKey() • _IsStringRegExp() • _IsSystemDrive() • _IsUPX() • _IsValidType() • _IsWebColor() • _Language() • _Log() • _MicrosoftInternetConnectivity() • _MSDNDataType() • _PathFull/GetRelative/Split() • _PathSplitEx() • _PrintFromArray() • _ProgressSetMarquee() • _ReDim() • _RockPaperScissors()/_RockPaperScissorsLizardSpock() • _ScrollingCredits • _SelfDelete() • _SelfRename() • _SelfUpdate() • _SendTo() • _ShellAll() • _ShellFile() • _ShellFolder() • _SingletonHWID() • _SingletonPID() • _Startup() • _StringCompact() • _StringIsValid() • _StringRegExpMetaCharacters() • _StringReplaceWholeWord() • _StringStripChars() • _Temperature() • _TrialPeriod() • _UKToUSDate()/_USToUKDate() • _WinAPI_Create_CTL_CODE() • _WinAPI_CreateGUID() • _WMIDateStringToDate()/_DateToWMIDateString() • Au3 script parsing • AutoIt Search • AutoIt3 Portable • AutoIt3WrapperToPragma • AutoItWinGetTitle()/AutoItWinSetTitle() • Coding • DirToHTML5 • FileInstallr • FileReadLastChars() • GeoIP database • GUI - Only Close Button • GUI Examples • GUICtrlDeleteImage() • GUICtrlGetBkColor() • GUICtrlGetStyle() • GUIEvents • GUIGetBkColor() • Int_Parse() & Int_TryParse() • IsISBN() • LockFile() • Mapping CtrlIDs • OOP in AutoIt • ParseHeadersToSciTE() • PasswordValid • PasteBin • Posts Per Day • PreExpand • Protect Globals • Queue() • Resource Update • ResourcesEx • SciTE Jump • Settings INI • SHELLHOOK • Shunting-Yard • Signature Creator • Stack() • Stopwatch() • StringAddLF()/StringStripLF() • StringEOLToCRLF() • VSCROLL • WM_COPYDATA • More Examples... Updated: 22/04/2018 Link to comment Share on other sites More sharing options...
enaiman Posted December 16, 2010 Share Posted December 16, 2010 @guinnessYou should have taken your cue from Jos. He was trying to get the OP to think about what he was doing, not giving him a complete solution.Well, now it's done. SNMP_UDF ... for SNMPv1 and v2c so far, GetBulk and a new example script wannabe "Unbeatable" Tic-Tac-Toe Paper-Scissor-Rock ... try to beat it anyway :) Link to comment Share on other sites More sharing options...
guinness Posted December 16, 2010 Share Posted December 16, 2010 I wasn't going to post the code initially, but I was in a helping mood. And hopefully the OP now understands/appreciates what the problem was. I didn't mean to tread on anyone's toes I am still learning with the AutoIt Forum code of conduct! UDF List: _AdapterConnections() • _AlwaysRun() • _AppMon() • _AppMonEx() • _ArrayFilter/_ArrayReduce • _BinaryBin() • _CheckMsgBox() • _CmdLineRaw() • _ContextMenu() • _ConvertLHWebColor()/_ConvertSHWebColor() • _DesktopDimensions() • _DisplayPassword() • _DotNet_Load()/_DotNet_Unload() • _Fibonacci() • _FileCompare() • _FileCompareContents() • _FileNameByHandle() • _FilePrefix/SRE() • _FindInFile() • _GetBackgroundColor()/_SetBackgroundColor() • _GetConrolID() • _GetCtrlClass() • _GetDirectoryFormat() • _GetDriveMediaType() • _GetFilename()/_GetFilenameExt() • _GetHardwareID() • _GetIP() • _GetIP_Country() • _GetOSLanguage() • _GetSavedSource() • _GetStringSize() • _GetSystemPaths() • _GetURLImage() • _GIFImage() • _GoogleWeather() • _GUICtrlCreateGroup() • _GUICtrlListBox_CreateArray() • _GUICtrlListView_CreateArray() • _GUICtrlListView_SaveCSV() • _GUICtrlListView_SaveHTML() • _GUICtrlListView_SaveTxt() • _GUICtrlListView_SaveXML() • _GUICtrlMenu_Recent() • _GUICtrlMenu_SetItemImage() • _GUICtrlTreeView_CreateArray() • _GUIDisable() • _GUIImageList_SetIconFromHandle() • _GUIRegisterMsg() • _GUISetIcon() • _Icon_Clear()/_Icon_Set() • _IdleTime() • _InetGet() • _InetGetGUI() • _InetGetProgress() • _IPDetails() • _IsFileOlder() • _IsGUID() • _IsHex() • _IsPalindrome() • _IsRegKey() • _IsStringRegExp() • _IsSystemDrive() • _IsUPX() • _IsValidType() • _IsWebColor() • _Language() • _Log() • _MicrosoftInternetConnectivity() • _MSDNDataType() • _PathFull/GetRelative/Split() • _PathSplitEx() • _PrintFromArray() • _ProgressSetMarquee() • _ReDim() • _RockPaperScissors()/_RockPaperScissorsLizardSpock() • _ScrollingCredits • _SelfDelete() • _SelfRename() • _SelfUpdate() • _SendTo() • _ShellAll() • _ShellFile() • _ShellFolder() • _SingletonHWID() • _SingletonPID() • _Startup() • _StringCompact() • _StringIsValid() • _StringRegExpMetaCharacters() • _StringReplaceWholeWord() • _StringStripChars() • _Temperature() • _TrialPeriod() • _UKToUSDate()/_USToUKDate() • _WinAPI_Create_CTL_CODE() • _WinAPI_CreateGUID() • _WMIDateStringToDate()/_DateToWMIDateString() • Au3 script parsing • AutoIt Search • AutoIt3 Portable • AutoIt3WrapperToPragma • AutoItWinGetTitle()/AutoItWinSetTitle() • Coding • DirToHTML5 • FileInstallr • FileReadLastChars() • GeoIP database • GUI - Only Close Button • GUI Examples • GUICtrlDeleteImage() • GUICtrlGetBkColor() • GUICtrlGetStyle() • GUIEvents • GUIGetBkColor() • Int_Parse() & Int_TryParse() • IsISBN() • LockFile() • Mapping CtrlIDs • OOP in AutoIt • ParseHeadersToSciTE() • PasswordValid • PasteBin • Posts Per Day • PreExpand • Protect Globals • Queue() • Resource Update • ResourcesEx • SciTE Jump • Settings INI • SHELLHOOK • Shunting-Yard • Signature Creator • Stack() • Stopwatch() • StringAddLF()/StringStripLF() • StringEOLToCRLF() • VSCROLL • WM_COPYDATA • More Examples... Updated: 22/04/2018 Link to comment Share on other sites More sharing options...
MvGulik Posted December 16, 2010 Share Posted December 16, 2010 (edited) nevermind. Edited June 28, 2011 by iEvKI3gv9Wrkd41u "Straight_and_Crooked_Thinking" : A "classic guide to ferreting out untruths, half-truths, and other distortions of facts in political and social discussions.""The Secrets of Quantum Physics" : New and excellent 2 part documentary on Quantum Physics by Jim Al-Khalili. (Dec 2014) "Believing what you know ain't so" ... Knock Knock ... Link to comment Share on other sites More sharing options...
Rabbitman Posted December 17, 2010 Author Share Posted December 17, 2010 Ohhh that makes more sense now!! Thanks for the corrected code! Oh and it was working with that code before and then It just stopped working! Thanks and sorry, I will try to do it more by myself Link to comment Share on other sites More sharing options...
Rabbitman Posted December 17, 2010 Author Share Posted December 17, 2010 My button doesnt work Link to comment Share on other sites More sharing options...
JohnOne Posted December 17, 2010 Share Posted December 17, 2010 What button? you havent got a button. I cannot even see a gui to have a button. AutoIt Absolute Beginners Require a serial Pause Script Video Tutorials by Morthawt ipify Monkey's are, like, natures humans. Link to comment Share on other sites More sharing options...
Rabbitman Posted December 17, 2010 Author Share Posted December 17, 2010 Nvm fixed. Thanks all for the help Link to comment Share on other sites More sharing options...
Rabbitman Posted December 17, 2010 Author Share Posted December 17, 2010 The button is $Button2 Link to comment Share on other sites More sharing options...
JohnOne Posted December 17, 2010 Share Posted December 17, 2010 Where do you suppose that "line 697" error is from, youe script clearly dosent have that many lines in it. AutoIt Absolute Beginners Require a serial Pause Script Video Tutorials by Morthawt ipify Monkey's are, like, natures humans. Link to comment Share on other sites More sharing options...
JohnOne Posted December 17, 2010 Share Posted December 17, 2010 When getting help to debug code, you should post at least the relevant code (A gui creation would fall under that) Your button wont work because your code is stuck in the inner while loop and the button is not being checked. AutoIt Absolute Beginners Require a serial Pause Script Video Tutorials by Morthawt ipify Monkey's are, like, natures humans. Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now