What's the wrong in this script?

[Darknight1366]

$answer = MsgBox(4, "!!!!!", "Running a lot applications together you task manager has corrupted, Would you like to restart now?")

If $answer = 7 Then
    MsgBox(0, "!!!!!", "Restart soon or your computer will corrupt")
EndIf
Exit
If $answer - 6 Then
    Shutdown(2)
Exit
EndIf

When I pressed "No" My computer rebooted!

Did I type anything wrong in this script?

[Kalin]

Eh, I'm lazy. So I'll let my code do the talking.

$answer = MsgBox(4, "!!!!!", "Running a lot applications together you task manager has corrupted, Would you like to restart now?")

If $answer = 7 Then MsgBox(0, "!!!!!", "Restart soon or your computer will corrupt")

If $answer = 6 Then MsgBox(0, "", "Computer shut down") ; ShutDown(2)

Edited January 9, 2011 by Kalin

[Darknight1366]

@ Kalin Where's Exit or EndIf??

[Kalin]

@ Kalin Where's Exit or EndIf??

Run it and see, they aren't required.

[timsta97]

I think there are a couple things wrong with your script.

Did you mean to put Exit before the first EndIf Statement? The rest of your script will be unreachable.

You could also use the Else statement instead of another if statement. It isn't necessary when there are only two buttons.

Here are my adjustments:

$answer = MsgBox(4, "!!!!!", "Running a lot applications together you task manager has corrupted, Would you like to restart now?") 
If $answer == 7 Then
     MsgBox(0, "!!!!!", "Restart soon or your computer will corrupt")
Else
     Shutdown(2)
EndIf

Also, the Exit command is not required.

Edited January 9, 2011 by timsta97

[shanet]

@ Kalin Where's Exit or EndIf??

With single line if statements, they are not required. Have a look:

If 1 Then MsgBox(0, "Single Line Statement", "This is a single line statement")

If 0 Then
    MsgBox(0, "Multi Line Statement", "This if statement will do more than one thing," & @CRLF & "therefore more than one
    line" & @CRLF $ "will be used."
    ;This is 'another function'
EndIf

I hope this makes it clearer?

shanet

[shanet]

You could also use the Else statement instead of another if statement. It isn't necessary when there are only two buttons.

Here are my adjustments:

$answer = MsgBox(4, "!!!!!", "Running a lot applications together you task manager has corrupted, Would you like to restart now?") 
If $answer == 7 Then
     MsgBox(0, "!!!!!", "Restart soon or your computer will corrupt")
Else
     Shutdown(2)
EndIf

Also, the Exit command is not required.

This is a good solution to the one above

However I would personally do it another way in case it doesnt end with a value of -6

Here is how I would do it:

$answer = MsgBox(4, "!!!!!", "Running a lot applications together you task manager has corrupted, Would you like to restart now?") 
If $answer = 7 Then
     MsgBox(0, "!!!!!", "Restart soon or your computer will corrupt")
Elseif $answer = 6 Then
     Shutdown(2)
EndIf
Exit

You may notice that in timsta97's version, the if statement condition was:

$answer == 7

However mine is

$answer = 7

Unlike programming languages such as C++, you do not need to check the value of the variable with ==.

Its like magic You can set the variable value with its own line.

$var1 = 10

;lines of code

$var1 = 9

There you go

if $var1 = 10 Then MsgBox(0, "Hello", "Hello!")

Hope this helps a bit more?

shanet

[Darknight1366]

Thanks a lot you everyone, I understood it. I am a novice to autoit. So please don't laugh at me! lol.

[Kalin]

With single line if statements, they are not required. Have a look:

If 1 Then MsgBox(0, "Single Line Statement", "This is a single line statement")

If 0 Then
    MsgBox(0, "Multi Line Statement", "This if statement will do more than one thing," & @CRLF & "therefore more than one
    line" & @CRLF $ "will be used."
    ;This is 'another function'
EndIf

I hope this makes it clearer?

shanet

Uh, are you implying I already didn't know that?

You wouldn't need to use more than one line in the code snippet I gave.

Exit is useless in this script. A good replacement of Exit would of just been to set a timeout for the MsgBox.

[ripdad]

$answer = MsgBox(4, "!!!!!", "Running a lot applications together you task manager has corrupted, Would you like to restart now?")

I don't think I've ever seen Task Manager corrupted. How is that done? <grin>

[shanet]

Uh, are you implying I already didn't know that?

No I am not. I did it to try and explain to DarkNight1366 how it works. I was not inferring that you dont already know that, especially considering that is in your code already.

[shanet]

I don't think I've ever seen Task Manager corrupted. How is that done? <grin>

I think its meant to be a bit of a joke script?

As long as its not dangerous, its not a problem agreed?

[shanet]

I don't think I've ever seen Task Manager corrupted. How is that done? <grin>

I think its meant to be a bit of a joke script?

As long as its not dangerous (keylogger, virii) or bots and stuff, its not a problem agreed?

We all love playing jokes on people

[ripdad]

The Data Protection virus likes to play jokes too - it's hard to know the difference ..

[Darknight1366]

ripdad,

Hey did you use ToolTip or something??? Would you please tell me??

[Kalin]

ripdad,

Hey did you use ToolTip or something??? Would you please tell me??

lul...

$timeout = 40 ; 40 seconds
$iconID = 2 ; warning icon

TrayTip("WARNING!!!!!!!!!", "OMG U R GETTING HAXED", $timeout, $iconID)

Oh, forgot to add. When using TrayTips you should control the delay with the Sleep() command instead of relying on the timeout alone. It'll still close too fast. So use sleep to add additional time.

Edited January 9, 2011 by Kalin

[timsta97]

Unlike programming languages such as C++, you do not need to check the value of the variable with ==.

Its like magic You can set the variable value with its own line.

$var1 = 10

;lines of code

$var1 = 9

You're right; it isn't necessary, before I learned C++ and C# I never used the double equals, but I always put it in because I now use C# mostly. It doesn't hurt to put it in; it affects the code in no way whatsoever.

[Melba23]

timsta97,

It doesn't hurt to put it in; it affects the code in no way whatsoever.

Actually it does.

Using the == operator forces a case-sensitive comparison between the 2 operands converted to strings, which takes considerable more processing than the = operator.

So the recommendation is to use the == operator only when you need the case sensitive comparison. In all other cases you should use the = operator.

I hope that clears up any misconceptions.

M23

[Darknight1366]

@Kalin I know how to do the traytip, but I wanted to know how do you change the autoit icon?? (Tick)

[bo8ster]

timsta97,

Actually it does.

Using the == operator forces a case-sensitive comparison between the 2 operands converted to strings, which takes considerable more processing than the = operator.

So the recommendation is to use the == operator only when you need the case sensitive comparison. In all other cases you should use the = operator.

I hope that clears up any misconceptions.

M23

I remember reading the thread on the usage of the two. It was related to bug or enhancement, too hard to find.

By convention I use == for strings and = for numbers. I thought it forced the conversion to string, wasn't sure it was case sensitivity. Thanks