cant get array to work properly

[mrstinky]

Hey all,

im trying to get this array to work but it will just read the first value of the array and copy that into my output.

ive been looking around the forum and in the helpfile either im blind or just not seeing the solution, so hope someone can help me with it

what i basicly want is that my array looks at the username where ill be using @username for the current logged in user, if the user starts with anything like a 01234...it should go to the folder \users0-f\ if the username starts with a ghijkl...etc.. i want it to go to the \usersg-t\ folder.

i just made the output will msgbox but will later make this drivemapadd to map a drive.

below is my test script used.

#Include <Array.au3>

#include <String.au3>

$share = "\\sharename\folder"

;we grab the first letter of the username

$username = "example"

$firstlet = StringLeft($username,1)

Dim $array[2]

$array[0] = "0123456789abcdef;\users0-f\"

$array[1] = "ghijklmnopqrst;\usersg-t\"

For $firstletter in $array

$hds = StringSplit($firstletter,";")

$hdslet = $hds[0]

$hdt = $hds[2]

If StringInstr($hdslet,$firstlet) > 1 then

$hd = $share & $hdt & $username & @CRLF

EndIf

exitloop

Next

$hd = $share & $hdt & $username

Msgbox(0,"testing","Result is: " & $hd)

Edited February 17, 2011 by mrstinky

[Melba23]

mrstinky,

Welcome to the AutoIt forum.

You are setting $hdslet to the wrong element of the StringSplit array. [0] is a count - you need [1] to get the letters:

$hds = StringSplit($firstletter, ";")
$hdslet = $hds[1] ; $hds[0] <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
$hdt = $hds[2]
If StringInStr($hdslet, $firstlet) > 1 Then

All clear?

M23

[mrstinky]

thanks for the welcome

and for the blazing fast reply!! i changed the 0 to 1 for the "hdslet" however i still get the output of array0, i changed the username to ghij so it should give output of array1 however i still get the output of array0. any other points?

With kind regards,

Harry

[hannes08]

Hi mrstinky,

just put the "ExitLoop" in your conditional statement:

If StringInstr($hdslet,$firstlet) > 1 then
    $hd = $share & $hdt & $username & @CRLF
    ExitLoop
EndIf

That should do the trick.

Regards,

Hannes

[Melba23]

mrstinky,

Sorry about that - as the test gave the right answer I assumed that I had fixed it! Never assume- check!

Here is a version that does work - take a look at what I changed and ask if you are unsure why I did it:

#include <Array.au3>
#include <String.au3>
$share = "\\sharename\folder"
;we grab the first letter of the username
$username = "9"
$firstlet = StringLeft($username, 1)

Dim $array[2]
$array[0] = "0123456789abcdef;\users0-f\"
$array[1] = "ghijklmnopqrst;\usersg-t\"

; Now loop through the array to check for out leading letter
For $i = 0 To 1
    $hds = StringSplit($array[$i], ";")
    $hdslet = $hds[1] ; This is the letters
    $hdt = $hds[2] ; this is the folder
    ; Now see if out leading letter is in the list for this element
    If StringInStr($hdslet, $firstlet) > 0 Then ; You had >1 so it missed the first letter
        $hd = $share & $hdt & $username & @CRLF
        ExitLoop
    EndIf

Next

; Check we actually matched something
If $i = 2 Then
    MsgBox(0, "Ooops", "Not found")
Else
    MsgBox(0, "testing", "Result is: " & $hd)
EndIf

[mrstinky]

great stuff and explanation guys, well apreciated! it works now i can make it a bit more complex as we have a lot of user folders

Cheers!!

Kind regards,

Harry

[hannes08]

Hey mrstinky,

You're welcome.

Regards,

Hannes