Using And's in an IF statement

[ojef1]

If ($row>0) And ($lastRow>0) And ($lastRow >= $row) Then
    ExitLoop
Else
        MsgBox(48, "ERROR", "You must enter a valid integer and the last rows gotta be greater than or equal to the first row."
EndIf

This statement evaluates to true no matter what I input.

[Mobius]

~

Edited March 2, 2011 by Mobius

[ojef1]

expandcollapse popup

Func input()
    While 1
        GUICreate("Emax", 380, 180, @DesktopWidth / 4 - 160, @DesktopHeight / 4 - 45, -1, 0x00000018)

        GUICtrlCreateLabel("Enter the row to start with: ", 10, 5)
        $input1 = GUICtrlCreateInput("", 10, 25, 100, 20)

        GUICtrlCreateLabel("Enter the last row: ", 10, 50)
        $input2 = GUICtrlCreateInput("", 10, 65, 100, 20)

        GUICtrlCreateLabel("Enter a time delay (in milliseconds) in case the network is running slow: ", 10, 90, 350, 20)
        $input3 = GUICtrlCreateInput("", 10, 105, 100, 20)  ;slows whole program down

        $enterBtn = GUICtrlCreateButton("Enter", 20, 145, 60, 20)
        $cancelBtn = GUICtrlCreateButton("Cancel", 100, 145, 60, 20)
        GUISetState()

        While 1
            $msg = GUIGetMsg()

            If $msg = $GUI_EVENT_CLOSE Then
                Exit
            ElseIf $msg = $enterBtn Then
                $row = Int(GUICtrlRead($input1, 1))
                $lastRow = Int(GUICtrlRead($input2, 1))
                $delay = Int(GUICtrlRead($input3, 1))
                ExitLoop
            ElseIf $msg = $cancelBtn Then
                Exit
            EndIf
        WEnd
        
        If ($row>0) And ($lastRow >= $row) Then
            ExitLoop
        Else
            MsgBox(48, "ERROR", "You must enter a valid integer and the last rows gotta be greater than or equal to the first row."
        EndIf   
    WEnd
EndFunc

This is the full function (you make a valid point Mobius)...but no matter what the inputs are I can't get to the error message

[BrewManNH]

Adding a couple of lines to make this a usable demo script, without changing your code at all, it works for me if I put in 0 for $row, or if $lastRow < $row. I get the MsgBox when I do that.

[ojef1]

That's wierd it works for me now too...I kept entering 'a' in all 3 textboxes and it still exited the loop and bypasses the error message. I can't imagine Mobius' suggestion fixed the problem, even though it was an improvement.....who knows

thanks

[PsaltyDS]

When you enter a string in a native AutoIt parameter that expects an integer, it gets put through Number() first. Since "a" is not a number string, it evaluates to 0. Entering "a" for every integer value is the same as entering 0 for all of them.

It works the same for numeric compare operators like "=", ">", or "<=".

[jchd]

You probably should make the input fields $ES_NUMBER as you only allow numeric values.

[michaelslamet]

If ($row>0) And ($lastRow>0) And ($lastRow >= $row) Then
    ExitLoop
Else
        MsgBox(48, "ERROR", "You must enter a valid integer and the last rows gotta be greater than or equal to the first row."
EndIf

This statement evaluates to true no matter what I input.

Try this:

If (number($row)>0) And (number($lastRow)>0) And (number($lastRow) >= number($row)) Then