Noob Confoooosed

[kevinward13]

Dont want to go into a lot of great detail as to what I am working towards, but it is not, and i repeat, NOT the forbidden subjects. Plus I read somewhere it is a big red flag to ask for code without trying it first.

So i have been doing a lot of digging and reading to get this far, I dont understand it 100% yet, more like 10% but i have been pulling snippets here and there to get what I am looking for. If you see bits and pieces of your code, please let me know so i can give credit where credit is due. By no means is this all my work.

I am trying to get small ammounts to work seperatly before i get them all to fit together. Here is what I have now

expandcollapse popup

Global $ip = "localhost"
If $CmdLine[0] > 0 Then $ip = $CmdLine[1]

$objWMIService = ObjGet("winmgmts:{impersonationLevel = impersonate}!\\" & $ip & "\root\cimv2")

_WMI($ip)

Exit

Func _WMI($srv)
    Local $ping, $colItems, $objItem, $ComputerName, $OS, $SP, $Disk, $Disk_Caption, $Disk_FreeSpace, $Disk_Perc_Free, $Disk_Size
    $ping = Ping($srv)
    If $ping Then
        $colItems = $objWMIService.ExecQuery("Select CSName, Caption, CSDVersion from Win32_OperatingSystem", "WQL", 0x30)
        If IsObj($colItems) Then
            For $objItem In $colItems
                $ComputerName = $objItem.CSName
                $OS = $objItem.Caption
                $SP = $objItem.CSDVersion
            Next
            ConsoleWrite($ComputerName & @CRLF & $os & @CRLF & $SP & @CRLF)
        EndIf
        $colItems = $objWMIService.ExecQuery("Select Caption, FreeSpace, MediaType, Size from Win32_LogicalDisk Where MediaType = '12'", "WQL", 0x30) ;get fixed harddisk media
        If IsObj($colItems) Then
            For $objItem In $colItems
                If $objItem.Size > 0 And $objItem.MediaType <> "" Then
                    $Disk_Caption = $objItem.Caption
                    $Disk_FreeSpace = Round($objItem.FreeSpace / 1024 ^ 3, 2)
                    $Disk_Size = Round($objItem.Size / 1024 ^ 3, 2)
                    $Disk_Perc_Free = Round(100 * $objItem.FreeSpace / $objItem.Size, 2)
                    $Disk &= $Disk_Caption & @CRLF & $Disk_Size & @CRLF & $Disk_FreeSpace & @CRLF
                EndIf
            Next
            ;ConsoleWrite($Disk & @CRLF & $Disk_Size & " GB" & @CRLF & $Disk_Perc_Free & " GB" & @CRLF)
        ConsoleWrite($Disk & @CRLF & @CRLF)
        EndIf
    Else
        Return "Host not reachable"
    EndIf
EndFunc

Just trying to gather small information about the comptuer. easy right? Well here is where the math doesnt add up for me. The above code works like it should. (pulled snippet) But when I tried to make some modifications to it so i can make it display to my likings...the math doesnt add.

$Disk &= $Disk_Caption & @CRLF & $Disk_Size & @CRLF & $Disk_FreeSpace & @CRLF
            EndIf
            Next
            ;ConsoleWrite($Disk & @CRLF & $Disk_Size & " GB" & @CRLF & $Disk_Perc_Free & " GB" & @CRLF)
        ConsoleWrite($Disk & @CRLF & @CRLF)

the above 1st and 5th lines are the original code. outputs the below which is correct.

WLOS07E490
Microsoft Windows XP Professional
Service Pack 3
C:
74.44
34.62

However when i comment out the 1st and 5th lines and un-comment

ConsoleWrite($Disk & @CRLF & $Disk_Size & " GB" & @CRLF & $Disk_Perc_Free & " GB" & @CRLF)

the math does not add up. It gives me this:

WLOS07E490
Microsoft Windows XP Professional
Service Pack 3

74.44 GB
46.51 GB

Any ideas?

[BrewManNH]

$Disk_Perc_Free isn't that the percentage free, and not the free space, going by the variable name you used.

[kevinward13]

you are correct. I just caught that when i looked at and was talking to my self aloud.

I didnt pay my syntax and i got nailed

[kevinward13]

Changed

$Disk_Perc_Free

to this

$Disk_FreeSpace