Problems with Password check

[Makiix3]

So here is what i want to do:

I want to create a password check that shows up for example a message whenever i type in the correct password. After that it should Exit.

Also whenver i press cancel the programm should escape too.

Can any1 tell what´s wrong with my code?

$i = InputBox("Passwordcheck","Insert Password","","*")
If $i = "hlMG83csk" Then
    MsgBox(0,"Sucess","Correct Password")
    Exit
ElseIf $i = 2 Then
    Exit
ElseIf $i <> "hlMG83csk" Or 2 Then
    $x = InputBox("Passwordcheck","Wrong Password.Try Again!","","*")
EndIf
If $x = "hlMG83csk" Then
    MsgBox(0,"Sucess","Correct Password")
    Exit
ElseIf $x <> "hlMG83csk" Or 2 Then
    Do
    Inputbox("Passwordcheck","Wrong Password.Try Again!","","*")
Until $x = "hlMG83csk"
    Msgbox(0,"Sucess","Correct Password")
    Exit
    EndIf

PS: hlMG83csk is the password 2 is stands only for Cancel but I´m not sure if it´s right formulated.

Edited July 13, 2011 by Makiix3

[guinness]

I would read the Forum Rules first as the title of the InputBox is a little suggestive.

[Makiix3]

Sry i did not know about that. It was just some random title.

Thx for your advice.

[hannes08]

Hi Makiix,

first, you don't need two "if .. then .. elseif .. then .. endif" constructs. One should be enough.

Second, strip the last elseif to else, because it already checked whether your input is 2 or the correct password.

Third, storing clear-text passwords is never a good idea. Better would be using hashes or encryption.

[Makiix3]

Thx for your fast response.

But get syntax error if i change the last ElseIf to Else.

C:\Users\Max\****\*******.au3(13,7) : ERROR: syntax error

Else $x

~~~~~^

C:\Users\Max\****\*******.au3 - 1 error(s), 0 warning(s)

[hannes08]

;One time check:
$i = InputBox("Passwordcheck","Insert Password","","*")
If $i = "hlMG83csk" Then
    MsgBox(0,"Sucess","Correct Password")
    Exit
ElseIf $i = 2 Then
    Exit
Else
    $x = InputBox("Passwordcheck","Wrong Password.Try Again!","","*")
EndIf

;Two time check
For $i = 0 To 1
    $i = InputBox("Passwordcheck","Insert Password","","*")
    If $i = "hlMG83csk" Then
        MsgBox(0,"Sucess","Correct Password")
        Exit
    ElseIf $i = 2 Then
        Exit
    Else
        $x = InputBox("Passwordcheck","Wrong Password.Try Again!","","*")
    EndIf   
Next

;Continious check
While 1
    $i = InputBox("Passwordcheck","Insert Password","","*")
    If $i = "hlMG83csk" Then
        MsgBox(0,"Sucess","Correct Password")
        Exit
    ElseIf $i = 2 Then
        Exit
    Else
        $x = InputBox("Passwordcheck","Wrong Password.Try Again!","","*")
    EndIf   
WEnd

I suggest you to read the sections about loops and conditional statements in the helpfile.

[Makiix3]

Still don´t work as it should but I´ll try to fixx it after rereading conditional statements and loops.

Thx anyways

Edited July 13, 2011 by Makiix3