Brimak86 Posted August 29, 2011 Share Posted August 29, 2011 I need help with this script, basically I need to check the registry of multiple machines, check the registry for a match, and then write all the matches to a text file. The code I have will only work for the 1st, 3rd, and 7th. I can't figure out why its not consistent. While $cnt < $num $hostname = FileReadLine($hostnameFile) FileWriteLine($file,$hostname) While not @error $var = RegEnumKey("\\"&$hostname&"\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall", $i) If @error <> 0 then ExitLoop $var2 = RegRead("\\"&$hostname&"\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\"&$var,"DisplayName") If StringRegExp($var2, "(?-i)Redistributable", 0) == 1 Then $var3 = RegEnumKey("\\"&$hostname&"\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall", $i) $outLine = $var&","&$var2&","&$var3 FileWriteLine($file,$outLine) EndIf $i += 1 WEnd $cnt +=1 WEnd Link to comment Share on other sites More sharing options...
rcmaehl Posted August 29, 2011 Share Posted August 29, 2011 1st 3rd and 7th what? Registry Checks? Computers? Tries? My UDFs are generally for me. If they aren't updated for a while, it means I'm not using them myself. As soon as I start using them again, they'll get updated.My Projects WhyNotWin11Cisco Finesse, Github, IRC UDF, WindowEx UDF Link to comment Share on other sites More sharing options...
Brimak86 Posted August 29, 2011 Author Share Posted August 29, 2011 Sorry 1st 3rd and 7th computers. I can change the order in the list its reading from and it still works for in the same positions. It's not that computers are off, its not a security or permissions issue because I can take it out of the loop and put the hostnames in one at a time, and it works for all of them. I'm not sure why trying to loop through the file is messing it up. Thanks Link to comment Share on other sites More sharing options...
BrewManNH Posted August 29, 2011 Share Posted August 29, 2011 I'd look into your second While loop, $i isn't being reset so it's constantly counting up. If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator Link to comment Share on other sites More sharing options...
Brimak86 Posted August 29, 2011 Author Share Posted August 29, 2011 BrewManNH Thanks, That's exactly what it was I can't believe I didn't see it sooner. Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now