AJ6594 Posted October 5, 2011 Share Posted October 5, 2011 (edited) I just received my license to become a home inspector and I created this script to help me create reports. If you read the script, you will see that I am no expert. I'm looking for advice on how to improve my code or shortcuts in general. Thanks for the help ! I have removed the attachment now. Mods can delete this thread if they wish. Edited October 6, 2011 by AJ6594 Link to comment Share on other sites More sharing options...
Moderators Melba23 Posted October 5, 2011 Moderators Share Posted October 5, 2011 AJ6594,Please edit your post to put Code tags around yoru script. You need to add [autoit] before and [/autoit] after your posted code. No-one will look at it if you leave it as it is. M23 Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind Open spoiler to see my UDFs: Spoiler ArrayMultiColSort ---- Sort arrays on multiple columnsChooseFileFolder ---- Single and multiple selections from specified path treeview listingDate_Time_Convert -- Easily convert date/time formats, including the language usedExtMsgBox --------- A highly customisable replacement for MsgBoxGUIExtender -------- Extend and retract multiple sections within a GUIGUIFrame ---------- Subdivide GUIs into many adjustable framesGUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView itemsGUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeViewMarquee ----------- Scrolling tickertape GUIsNoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxesNotify ------------- Small notifications on the edge of the displayScrollbars ----------Automatically sized scrollbars with a single commandStringSize ---------- Automatically size controls to fit textToast -------------- Small GUIs which pop out of the notification area Link to comment Share on other sites More sharing options...
RichardL Posted October 6, 2011 Share Posted October 6, 2011 (edited) AJ6594, There are several to techniques you could learn to use which will make this program easier to maintain. 1. See help on Dim, learn about arrays (and MustDeclareVars). ... $2other_room6_read =BitAnd(GUICtrlRead($2other_room6),$GUI_CHECKED) $2other_room7_read =BitAnd(GUICtrlRead($2other_room7),$GUI_CHECKED) ... Use an array for the control vars, and another for the state vars, 25 lines becomes 3 lines. For $ix = 0 to 24 $2other_room_read[$ix] =BitAnd(GUICtrlRead($2other_room[$ix]),$GUI_CHECKED) Next 2. Put some lines of text into a file and learn to read it into an array. Now the section after the above section will disappear into a loop, 80 carefully edited lines will become a few easy lines. That text is used in several rooms, so the same file can be used for each, and if you need to change it, one change will do them all. Taking that further, make the number of lines in the file set the size of the arrays and the loop counts. If you keep going like that it will all become easier, less effort, fewer possibilities for mistakes. I hope this helps. Richard Edited October 6, 2011 by RichardL Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now