For Next Help

[rcmaehl]

Okay, I'm making a random number generator for IDs using:

For $Num = 0 to 9999
If Random(0, 100, 1) = 1 Then
$Return = $Num
ExitLoop
EndIf
Next

I know I could just use Random(0, 9999) but I want to do it this way for various reasons. So how do I make it so that the same number is not used twice?

[guinness]

I'm not really following your code but this is what I understood you want to do >>

#include <Array.au3>

Global $aArray, $sHold = ""

For $i = 0 To 100
    $iRandom = Random(0, 100, 1)
    If StringInStr($sHold, $iRandom & "|") = 0 Then
        $sHold &= $iRandom & "|"
    EndIf
Next
$sHold = StringTrimRight($sHold, 1)
$aArray = StringSplit($sHold, "|")
_ArrayDisplay($aArray)

[rcmaehl]

Yes kinda like that but all numbers will be used however.

[Ramzes]

Try this:

#include <Array.au3>
Global $Number[1]
For $i = 1 To 100
$Random = Random(0, 100, 1)
If _ArraySearch($Number, $Random) = -1 Then _ArrayAdd($Number, $Random)
Next
_ArrayDisplay($Number)

[rcmaehl]

Try this:

#include <Array.au3>
Global $Number[1]
For $i = 1 To 100
$Random = Random(0, 100, 1)
If _ArraySearch($Number, $Random) = -1 Then _ArrayAdd($Number, $Random)
Next
_ArrayDisplay($Number)

Thanks!

[guinness]

I just did a quick test and this was the time difference.

guinness: 5.45381317243982

Ramzes: 14.1545954168027

Aren't both examples exactly the same idea? Edited October 13, 2011 by guinness

[Ramzes]

Change:

_ArraySearch($Number, $Random)

to

_ArraySearch($Number, $Random, 1)

But if you want get pr0 evo ultra speed you should use ASM code.

[kylomas]

rcmaehl,

Yes kinda like that but all numbers will be used however.

This leads me to believe that you want to generate 100 random numbers between 1 and 100. If that is true then the proposed code may or may not work because you are looping 100 times and may conditionally decide NOT to add to your array.

This code will work but is considerably slower than previously suggested solutions:

#include <Array.au3>
#cs
Global $Number[1]
For $i = 1 To 100
$Random = Random(0, 100, 1)
If _ArraySearch($Number, $Random) = -1 Then _ArrayAdd($Number, $Random)
Next
_ArrayDisplay($Number)
#ce
Global $Number[1]
local $st = timerinit()
while 1
$Random = Random(0, 100, 1)
If _ArraySearch($Number, $Random,1) = -1 Then _ArrayAdd($Number, $Random)
if ubound($number) = 101 then Exitloop
wend
consolewrite("Time to run 100 = " & timerdiff($st) & @crlf)
_arraydisplay($number)
_arraysort($number)
_arraydisplay($number)

Thanks,

Kylomas

P.S. What the hell am I doing wrong when I insert code??? It is losing the indentation....

Edited October 13, 2011 by kylomas

[BrewManNH]

P.S. What the hell am I doing wrong when I insert code??? It is losing the indentation....

I've found out that if you want to add code to a post, you have to click the Editing Mode button (the one at the top left of the reply box), and then manually add the code tags and code. Otherwise this "upgraded" forum software converts tabs to a single space, and multiple spaces to only God knows what.

[kylomas]

BrewManNH,

Thanks..

Kylomas

[VelvetElvis]

This works quite well too. This one's from Yashied. Does 1,000 very quickly.

; Random Array Sort
;
; ---- Original code by Yashied ----
; Works by reassigning array elements one at a time.
; You need a large number of iterations
; 100 isn't enough.. 500 is good, and it's fast as well
#Include <Array.au3>
Global $Data[1000]
Local $st = TimerInit()
For $x = 1 To 1000
$Data[$x-1] = $x
Next
For $i = 1 To 500
    $A = Random(0, UBound($Data) - 1, 1)
    $B = Random(0, UBound($Data) - 1, 1)
    $Temp = $Data[$A]
    $Data[$A] = $Data[$B]
    $Data[$B] = $Temp
Next
ConsoleWrite("Time to run  = " & TimerDiff($st) & @CRLF)
_ArrayDisplay($Data)
; Sort back to original
_ArraySort($Data)
_ArrayDisplay($Data)