Compare problem

[Command3r]

i dont know what's wrong with this script

look:

expandcollapse popup

#include <ButtonConstants.au3>
#include <GUIConstantsEx.au3>
#include <WindowsConstants.au3>
#include <String.au3>
#include <INet.au3>
#Region ### START Koda GUI section ### Form=
$Form1 = GUICreate("program 1.0", 182, 46, 192, 124)
$Button1 = GUICtrlCreateButton("Update", 8, 8, 75, 25, $WS_GROUP)
$Button2 = GUICtrlCreateButton("Exit", 88, 8, 75, 25, $WS_GROUP)
GUISetState(@SW_SHOW)
#EndRegion ### END Koda GUI section ###
Global $ThisVersionFile = @TempDir & "\alrdyVersion.txt"
Global $NewVersionFile = @TempDir & "\newversion.txt"
Global $GetSource, $CheckUpdate
FileWrite($ThisVersionFile, "103")
Func del()
FileDelete(@TempDir & "\alrdyVersion.txt")
FileDelete(@TempDir & "\newversion.txt")
EndFunc   ;==>del
Func Close()
FileClose($ThisVersionFile)
FileClose($NewVersionFile)
EndFunc   ;==>Close
While 1
$nMsg = GUIGetMsg()
Switch $nMsg
  Case $GUI_EVENT_CLOSE
   del()
   Exit
  Case $Button2
   del()
   Exit
  Case $Button1
   $GetSource = _INetGetSource("https://sites.google.com/site/chk4updatetestau")
   FileWrite($NewVersionFile, $GetSource)
   FileOpen($ThisVersionFile, 0)
   FileOpen($NewVersionFile, 0)
   $AlrdyVersion = FileRead($ThisVersionFile)
   $NewVersion = FileRead($NewVersionFile)
   $NewTxt = _StringBetween($NewVersion, "Update", ":")
   $ThisTxt = _StringBetween($AlrdyVersion, "Update", ":")
   $compare = StringCompare($NewTxt, $ThisTxt)
   If $compare <> 0 Then
    MsgBox(0, "New update available", "There is new version for this program.")
    Close()
   ElseIf $compare = 0 Then
    MsgBox(0, "update doesn't available", "There isn't new version for this program.")
    Close()
   EndIf
 
EndSwitch
WEnd

i want to compare with the new version and already version, but it alaways says: new update is available if already version

less than new version or greater than it or equal .

any ideas please?

thanks.

[BrewManNH]

The main problems with this script are that _StringBetween returns an array and you're comparing them like they're strings. Also, that website's source code has the word "Update" in it in 36 times, so your stringbetween array is going to have a lot of hits in it with that comparison.

[Command3r]

umm, okay how can i return it to array, i dont know more about arrays and the "Update" word came just 1time in my page, String between "Update" And ":".... so the problem just returns an array?

may u explain how to returns an array please?

thanks.

[BrewManNH]

You need to look at what is inside the variable $GetSource after you run this line:

$GetSource = _INetGetSource("https://sites.google.com/site/chk4updatetestau")

Because the text file you write from that variable, @TempDir & "\newversion.txt", contains the whole source code from that page. In that text file you'll see that the word Update is in there (by my count) 36 times. Sometimes it's in there as Updates, sometimes it's in there as "chk4updatetestau", _StringBetween is going to see every occurance of the word, whether it's by itself or part of another word, as a hit.

As to how to work with Arrays, I would suggest this Wiki Article on arrays as a start.

[Command3r]

Thanks bro for help

so to resolve this problem i should change "Update" word to any another word??

and returns an array... i'll try and tell u

thanks again.