Need a little help for a Var assignment question

[Damein]

Alright, so I will start out by showing my attempt and then explaining

$PlayListSongNames = IniReadSection("Playlists.ini", $CurrentPlayList)


For $i = 0 To $PlayListSongNames[0][0]
If $PlayListSongNames[$i][0] = $PlaySong Then
$NewSong = $PlayListSongNames[$i+1][0]
If @Error Then
MsgBox(48, "Error", "An error has occured, possibly due to the end of the playlist was reached.")
Else
$UrlOfSong = IniRead("Playlists.ini", $CurrentPlayList, $NewSong, "Error")
EndIf

So I have the song $PlaySong associated with the currently playing song. I want to next find the currently playing song in the INI, and then go +1 into that INI and pass it to the $UrlOfSong INI read.

Now, if there is a second item in the Ini, this works 100%. But the @error isn't catching it if its at the end of the Section. So I want to be able to make it so the script doesn't crash when the array exceeds the subscripts. I want to just create the message box and display the message.

Thanks in advance! I'm almost done with my project

[guinness]

The snippet is missing an EndIf, Next and best practice is check the @error after the function is called. Also why $PlayListSongNames[$i+1] this and not $PlayListSongNames[$i] with starting the variable $i at 1?

[water]

Change

If @Error Then

to

If $i + 1  > $PlayListSongNames[0][0] Then

because a simple assignment never sets @error.

[Damein]

I know its missing some, I omitted them because I thought it wasn't needed. And the reason for starting it at 0 is because I need to check the entire INI to check what position the current song is in the INI to +1 to the next Key.

I'll post the whole function.

Func _NextSong()
$PlayListSongNames = IniReadSection("Playlists.ini", $CurrentPlayList)
For $i = 0 To $PlayListSongNames[0][0]
  If $PlayListSongNames[$i][0] = $PlaySong Then
   $NewSong = $PlayListSongNames[$i+1][0]
   If @Error Then
    MsgBox(48, "Error", "An error has occured, possibly due to the end of the playlist was reached.")
    Else
   $UrlOfSong = IniRead("Playlists.ini", $CurrentPlayList, $NewSong, "Error")
   If $UrlOfSong = "Error" Then
    MsgBox(48, "Error", "An error has occured, possibly at the end of the playlist." & @CRLF & @CRLF & _
    "Select another song in the playlist and click 'Play' to resume playing")
    Else
   _IENavigate ($EmbedIE, $UrlOfSong)
   $PlaySong = $NewSong
   ExitLoop
  EndIf
  EndIf
  Else
   Sleep(10)
   EndIf
  Next
EndFunc

Now, like I said. This works 100% so long as there is a next Key to go to in the INI. But if not, the script crashes due to the $PlayListSongName: Array variable has incorrect number of subscripts or subscript dimension range exceeded.

So I need a way to prevent the crash and just stop the action of the var assignment.

[kylomas]

damein,

You need to test for end of array before you make a $i+1 reference to the array. This can be done any number of ways...

kylomas

Edit: too slow again - always one step behind the experts!!!

Edited November 9, 2011 by kylomas

[Damein]

Ah hah! Thank's Water, that did the trick. Good idea

[guinness]

I know its missing some, I omitted them because I thought it wasn't needed.

OK, you have to understand that in the past code has been mistaken for just a 'snippet' when in actual fact is was the entire code or at least working code that wasn't working! Therefore one can only presume that if you have a problem then first things first is to get the code past Au3Check. Edited November 9, 2011 by guinness

[Damein]

Alright, so that worked fine. But now I am trying to reverse this process with a previous song func.

No matter which item I am on it comes up as being at the start of the INI. All I did was flip the signs and no go

Func _PreviousSong()
  $PlayListSongNames = IniReadSection("Playlists.ini", $CurrentPlayList)
For $i = 0 To $PlayListSongNames[0][0]
  If $PlayListSongNames[$i][0] = $PlaySong Then
      If $i - 1  < $PlayListSongNames[0][0] Then
    MsgBox(48, "Error", "An error has occured, possibly due to the start of the playlist being reached.")
    ExitLoop
    Else
   $NewSong = $PlayListSongNames[$i-1][0]
   $UrlOfSong = IniRead("Playlists.ini", $CurrentPlayList, $NewSong, "Error")
   _IENavigate ($EmbedIE, $UrlOfSong)
   $PlaySong = $NewSong
   ExitLoop
  EndIf
  Else
   Sleep(10)
   EndIf
  Next
EndFunc

[Damein]

Nevermind, I was being dense and forgetting basic arithmetic. ^^;

All resolved!

[BrewManNH]

This:

For $i = 0 To $PlayListSongNames[0][0]

Should probably be like this:

For $i = 1 To $PlayListSongNames[0][0] ; <<<<<<<<<< note the starting number

[Damein]

Yeah, thats what I changed it to. Thanks though

Like I said, I was just being stupid.