Random Error, no clue whats causing it or how to fix

[OneManPen]

So I'm editting a IRC engine I found on a topic made by

I then went ahead and edited it to my needs... Thats pretty much, adding new commands, encrypting all of the messages... I removed most of the custom commands I was using because they're not the cause of the error. I left in part of my encryption code... I left in was the code that I might have been causing the problem, cept /cls... because thats just a usefull command and I'm pretty sure it's not the problem.

Anyway... the bug is triggered when...

• User1 and User2 connect
• User1 private messages User2
• User1 quits and rejoins
• User2 private messages User1
• User2 quits... server crashes

If you're going to try and debug this, unless you change the code in the program... or follow these steps you can't really preform the bug on your local computer

• Start client...
• Change name in settings.ini
• start another client

and that is how you get two accounts on one server...

Source is in attached files...

Thanks in advance

IRC Server.zip

Edited August 8, 2020 by OneManPen

[jaberwacky]

When user1 quits, I receive an error message for line 57 in server.au3:

If $SOCKET[$Cx] <> "" Then

"Error: Array variable has incorrect number of subscripts or subscript dimension range exceeded."

[OneManPen]

-.-

YEAH... I know what the error is... I have no clue how to fix it... because I have no clue whats causing it...

[Robjong]

Hi,

I'm not sure but if it is after disconnecting it seems likely $SOCKET is 'unset' (something like $SOCKET = -1) somehwere and therefor $SOCKET[$Cx] will fail, but I did not look at the code so it's pure speculation.

However if it's this line that's causing the error...

If $SOCKET[$Cx] <> "" Then

...just check if $SOCKET is an array...

If IsArray($SOCKET) And $SOCKET[$Cx] <> "" Then

...or even if element $Cx exists...

If IsArray($SOCKET) And $Cx >= 0 And $Cx < UBound($SOCKET) And $SOCKET[$Cx] <> "" Then

Hope this helps.

[BrewManNH]

The problem is that you're going through the $Socket array forwards, but in some cases you're deleting elements of that array. You need to traverse the $Socket array in reverse so that if you delete elements you don't overshoot the end of your new array with the For...Next loop. Use this in line 48

For $Cx = UBound($SOCKET) - 1 To 0 Step -1

See if that fixes the problem.

[OneManPen]

The problem is that you're going through the $Socket array forwards, but in some cases you're deleting elements of that array. You need to traverse the $Socket array in reverse so that if you delete elements you don't overshoot the end of your new array with the For...Next loop. Use this in line 48

For $Cx = UBound($SOCKET) - 1 To 0 Step -1

See if that fixes the problem.

Yay! that fixed it ( I think)... not sure how or why... but thanks anyway

[BrewManNH]

Think of your array this way, the array holds elements 0,1,2,3,4,5,6. As you go through the For...Next loop it's counting from 0 through 6. If you delete elemnt 3 for example, because that user has disconnected, then your array now holds elements 0,1,2,3,4,5 and when your For...Next loop gets to 6 it's not there any longer and you get a subscript error. Plus, you're skipping element 4 because that's now element 3 because you deleted one of them below it.

If you loop in reverse and you delete element 3, the loop won't care because it's now looking at element 2, instead of element 4 the next time around.