_ScreenCapture_Capture does not always work

[Ontosy]

Because the first work and the second does not?

#include<ScreenCapture.au3>
Local $a1=_ScreenCapture_Capture("c:Downloads1.jpg",1,187,639,500, False)
Local $a2=_ScreenCapture_Capture("c:Downloads2.jpg",9,52,1267,28, False)
msgbox(0,$a1,$a2)

Edited January 6, 2012 by Ontosy

[jvanegmond]

9,52,1267,28

should be:

9,28,1267,52

It's Left, Top, Right, Bottom. Where X and Y is 0,0 at the top left of your screen.

This means the bottom has a higher Y than the top.

[goldenix]

Because the first work and the second does not?

#include<ScreenCapture.au3>
Local $a2=_ScreenCapture_Capture("c:\Downloads\2.jpg",9,52,1267,28, False)
msgbox(0,$a1,$a2)

Looks to me like the UDF is bugged, it wont check for error if Bottom right is smaller than top left.

Basically, it does not work because 28 is smaller than 52.

Make the bottom right bigger than 52 & it should work:

Local $a2=_ScreenCapture_Capture("c:\Downloads\2.jpg",9,52,1267,53, False)

[jvanegmond]

Looks to me like the UDF is bugged, it wont check for error if Bottom right is smaller than top left.

Func _ScreenCapture_Capture($sFileName = "", $iLeft = 0, $iTop = 0, $iRight = -1, $iBottom = -1, $fCursor = True)
    If $iRight = -1 Then $iRight = _WinAPI_GetSystemMetrics($__SCREENCAPTURECONSTANT_SM_CXSCREEN)
    If $iBottom = -1 Then $iBottom = _WinAPI_GetSystemMetrics($__SCREENCAPTURECONSTANT_SM_CYSCREEN)
    If $iRight < $iLeft Then Return SetError(-1, 0, 0)
    If $iBottom < $iTop Then Return SetError(-2, 0, 0)

[goldenix]

Func _ScreenCapture_Capture($sFileName = "", $iLeft = 0, $iTop = 0, $iRight = -1, $iBottom = -1, $fCursor = True)
    If $iRight = -1 Then $iRight = _WinAPI_GetSystemMetrics($__SCREENCAPTURECONSTANT_SM_CXSCREEN)
    If $iBottom = -1 Then $iBottom = _WinAPI_GetSystemMetrics($__SCREENCAPTURECONSTANT_SM_CYSCREEN)
    If $iRight < $iLeft Then Return SetError(-1, 0, 0)
    If $iBottom < $iTop Then Return SetError(-2, 0, 0)

I ran his code, it does not return anything. Help file does not elaorate on this issue.

If it does not tell him why it returned nothing, then this function should be re-written, so user wont have to come hire & ask why it is happening.

therefore I consider this to be a buggy function.

If shit happens, we want to know why.

[BrewManNH]

Looking at the UDF for _ScreenCapture_Capture, there isn't any information as to what the return values mean in the header, but looking at the code, it is quite obvious that if Bottom is less than Top, it returns an error code of -2. The return values should be documented, but if you know what the code says you don't really need much.

[jvanegmond]

I ran his code, it does not return anything. Help file does not elaorate on this issue.

If it does not tell him why it returned nothing, then this function should be re-written, so user wont have to come hire & ask why it is happening.

therefore I consider this to be a buggy function.

If shit happens, we want to know why.

But function already tells user what is happening. Read the code I posted, Return SetError, etc..

I will make sure that documentation is updated. You say "function is buggy" but this is wrong. Open the function and read it.

#include<ScreenCapture.au3>
Local $a1=_ScreenCapture_Capture("c:Downloads1.jpg",1,187,639,500, False)
If @error Then
    ConsoleWrite("1st _ScreenCapture_Capture errored with error code: " & @error & @CRLF)
    Exit
EndIf
Local $a2=_ScreenCapture_Capture("c:Downloads2.jpg",9,52,1267,28, False)
If @error Then
    ConsoleWrite("2nd _ScreenCapture_Capture errored with error code: " & @error & @CRLF)
    Exit
EndIf
msgbox(0,$a1,$a2)

Edited January 6, 2012 by Manadar