Reading a file C++ (solved)

[JohnOne]

I am trying to read a file and output/return it all at once.

I was expecting to do this with this code...

ifstream myReadFile;
        myReadFile.open(sFile);
        char output[40960];
        if (myReadFile.is_open())
     {
            while (!myReadFile.eof())
         {
                myReadFile >> output;
          
                }
            }
  myReadFile.close();
  cout<<output;

But (probably unsurprising to others) it does not do as I expected.

It outputs (returns in my dll) just the last line of the file, and furthermore

ignores all spaces.

I'd appreciate it if someone would be so kind as to steer me toward

a solution.

Edited January 26, 2012 by JohnOne

[jaberwacky]

I think you're paving over output in the loop.

[JohnOne]

oops, of course I was, cheers.

Any idea about why spaces are stripped?

[jaberwacky]

I think you'd use output += myReadFile.Get()

[JohnOne]

Still cannot get my head around this, I have tried 2 approaches, both of which hang.

ifstream myReadFile;
        myReadFile.open(sFile);
  char output[40960];
  char tmp[1024];
  if (myReadFile.is_open())
     {
            while (!myReadFile.eof())
         {
    myReadFile.getline(tmp,1024); // hangs
                //myReadFile >> tmp; // works but strips white space
    //myReadFile >> noskipws >> tmp; // hangs
    strcat(output,tmp); 
            }
        }
  myReadFile.close();
  cout<<output;

EDIT:

Scrap that, as you suggested .get() works, .getline() does not.

Thanks.

One question, when using get(), is this reading one char at a time?

Edited January 26, 2012 by JohnOne

[jaberwacky]

I'll have to fire up codeblocks, been a while since I got my hands dirty.

[JohnOne]

I don't think it is, as if I make

char tmp[1024] any less I do not get the results I require, and if I make it [2], it crashes.

[jaberwacky]

This works for me:

expandcollapse popup

#include <iostream>

#include <fstream>

#include <String>



using namespace std;



int main()

{

    ifstream myReadFile;



    string sFile = "C:UsersMatthewDesktoptest.txt";



    myReadFile.open(sFile.c_str(), ios::in);



    if (myReadFile.is_open())

    {

        string output;



        while (myReadFile.good())

        {

            output += myReadFile.get();

        }



        myReadFile.close();



        cout << output;

    }



    return 0;

}

Edited January 26, 2012 by LaCastiglione

[JohnOne]

Cheers for alternative.