Help with arrays

[Dalex]

Hey guys, I have never really grasped the usage of arrays, and it really bugs me I have read the help notes I have read the wiki but for some reason I can't get it. Anyway, I am trying to check the local machine administrator group for a specific user (to make sure it was added correctly)

I figured I would collect the group, put it in an array and search the array for the value, then display a message if the specific value (User) was not found. I have used some of examples found here in the forums to create what I have below. At the moment I'm writing it in a msgbox just to test that I'm getting the information.

How do you correctkly put it into an array then search it? Also if there is a better way to do this please give me a hint.

(Thanks to spudw2k who posted the code that I have used)

#Include <Array.au3>
_GetLocalAdmins()
Func _GetLocalAdmins($host = @ComputerName)
    Dim $filter[1] = ["group"]
    $colGroups = ObjGet("WinNT://" & $host & "")
    If Not IsObj($colGroups) Then Return 0
    $colGroups.Filter = $filter
    For $objGroup In $colGroups
  Local $string
        If $objGroup.name = "Administrators" Then
            ConsoleWrite($host & @CRLF)
            For $objUser In $objGroup.Members
   $string = $String & $objUser.name & @CRLF
  Next
   msgbox(0,"",$String)
        EndIf
    Next
EndFunc

[hannes08]

#include <array.au3>
Dim $a_admins[1]
For $objUser In $objGroup.Members
   _ArrayAdd($a_admins, $objUser.name)
   $a_admins[0] += 1
Next
_ArrayDisplay($a_admins)

[Dalex]

Thanks for that quick reply! I'm very sorry to be so ignorant, but I get an erro when I attempt to test it

C:Usersremoved my nameDesktopTEST2.au3(59,34) : WARNING: $objGroup: possibly used before declaration.
For $objUser In $objGroup.Members
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
C:Usersremoved my nameDesktopTEST2.au3(59,34) : ERROR: $objGroup: undeclared global variable.
For $objUser In $objGroup.Members
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
C:Usersremoved my nameDesktopTEST2.au3 - 1 error(s), 1 warning(s)

[hannes08]

Well, I only sent you a part of the script.

you'll need to mash it up into what you posted first:

#Include <Array.au3>
_GetLocalAdmins()
Func _GetLocalAdmins($host = @ComputerName)
    Dim $filter[1] = ["group"]
    Dim $a_admins[1]    ;<<<<<<<<<<<<<<<<<<<<<

    $colGroups = ObjGet("WinNT://" & $host & "")
    If Not IsObj($colGroups) Then Return 0
    $colGroups.Filter = $filter
    For $objGroup In $colGroups
  Local $string
        If $objGroup.name = "Administrators" Then
            ConsoleWrite($host & @CRLF)
            For $objUser In $objGroup.Members
                _ArrayAdd($a_admins, $objUser.name)    ;<<<<<<<<<<<<<<<<<<<<<
                $a_admins[0] += 1    ;<<<<<<<<<<<<<<<<<<<<<
            Next
        EndIf
    Next
    _ArrayDisplay($a_admins)  ;<<<<<<<<<<<<<<<<<<<<<
EndFunc

see the Lines marked with "<"

Edit:

But then again, to confuse you even more, "_ArrayAdd" is a slow function, because it re-dims the array on every call. You could then go ahead and count the objects first, then dim your array and fill it at last, or create a string with delimiters in it and split it at the end, and ...

Edited January 27, 2012 by hannes08

[water]

Insert "Global $objGroup" at the top of your script.

[Dalex]

Awesome thank you so much guys! I'm going to study this one for a while to try and get my mind wrapped around "Arrays" and this "$objgroup" thing.

Thanks again!

[jchd]

Also the group names are localized: for instance the name is "Administrateurs" in a french Windows.

[NDog]

You are pretty lucky to get a reply. i asked the to do with arrays and still no answer. I may just have to study this thread eh ;-)