Simplifying multiple 'Or' conditions in a single function

[mtmartis]

I would just like to get some feedback from the gurus.

What would be an alternative to a potentially very long 'Or' statement?

I was thinking, it could be possible to have a file with a list of values that my script could run against, but I can't picture how it would be structured into my code.

Or is having a plethora of Or conditions on one line acceptable?

Thanks!

#Include <File.au3>

$FileList=_FileListToArray("C:\Users","*",2)
For $n = 1 To $FileList[0]
   If StringInStr($FileList[$n],"admin1") or StringInStr($FileList[$n],"user1") or StringInStr($FileList[$n],"user2") Then
  MsgBox(0,'',$FileList[$n] & " is exempt")
   Else
  MsgBox(0,'',$FileList[$n] & " is NOT exempt")
   EndIf
Next

[JLogan3o13]

Hi, mtmartis. How about a Case statement? It may be a little more typing, but it will allow you to easily add and delete entries.

#Include <File.au3>

$FileList=_FileListToArray("C:Users","*",2)

For $n = 1 To $FileList[0]
Select
  Case StringInStr($FileList[$n],"admin1")
    MsgBox(0,'',$FileList[$n] & " is exempt")
  Case StringInStr($FileList[$n],"user1")
    MsgBox(0,'',$FileList[$n] & " is exempt")
  Case StringInStr($FileList[$n],"user2")
    MsgBox(0,'',$FileList[$n] & " is exempt")
  Case Else
    MsgBox(0,'',$FileList[$n] & " is NOT exempt")
EndSelect
Next

Edited February 15, 2012 by JLogan3o13

[JohnQSmith]

Also try adding the ContinueCase statement which allows a Case statement to "fall through" to the next one. Here is a modified version of JLogan3o13's example.

#Include <File.au3>

$FileList=_FileListToArray("C:Users","*",2)

For $n = 1 To $FileList[0]
Select
  Case StringInStr($FileList[$n],"admin1")
    ContinueCase
  Case StringInStr($FileList[$n],"user1")
    ContinueCase
  Case StringInStr($FileList[$n],"user2")
    MsgBox(0,'',$FileList[$n] & " is exempt")
  Case Else
    MsgBox(0,'',$FileList[$n] & " is NOT exempt")
EndSelect
Next

[JLogan3o13]

Much cleaner, JohnQSmith

[Robjong]

Hi,

you could use StringRegExp to match multiple users

#Include <File.au3>

$sStrings = "admin1|user1|user2" ; FileRead('pathtofile.ext') ; save strings, separated by a horizontal bar |, in a file and read that
$aFileList = _FileListToArray(@HomeDrive & "Users", "*", 2)

For $n = 1 To $FileList[0]
    ; simply separate the string with a |, if the string contains special characters just wrap it in QE, e.g. Qfoo(bar)E, but I suspect you don't need it
    If StringRegExp($FileList[$n], "(?i)b" & $sStrings & "b") Then ; (?i) makes matches case insensitive, the b are boundaries to avoid matching user21 as valid if  only user2 is in the list
        MsgBox(0,'',$FileList[$n] & " is exempt")
    Else
        MsgBox(0,'',$FileList[$n] & " is NOT exempt")
    EndIf
Next

Edit: added flag and boundaries

Edited February 15, 2012 by Robjong

[mtmartis]

Thanks, all for the suggestions. Double thanks Robjong for hitting the nail on the head! I never used StringRegExp before.