If..then..else...Do While problem

[prgwkp]

Can someone please tell me what is wrong with this loop? Once it hits the "Else" section and "EndIf", it loops back thru and it runs every command down the line, ignoring the IF statements. Should it not reset the IF statement once it loops back up to "Do"? If not, what is a better option? I need this to loop thru 200 hundred times and compare the arrays and follow the IF commands. .

Global $SourceLocationArray[200] 
Global $SecondaryArray[200]

$SecondaryArray[0] = "1.PDF"
$SecondaryArray[1] = "2.PDF"
$SecondaryArray[2] = "3.PDF"
$SecondaryArray[3] = "4.PDF"
$SecondaryArray[4] = "5.PDF"

$SourceLocationArray[0] = "1.PDF"
$SourceLocationArray[1] = "2.PDF"
$SourceLocationArray[2] = "3.PDF"
$SourceLocationArray[3] = "4.PDF"
$SourceLocationArray[4] = "5.PDF"
$SourceLocationArray[5] = "6.PDF"


$z = 0
$Loop = 0

Do

   If $SecondaryArray[$z] = $SourceLocationArray[$z] Then
       ;MsgBox(0,"Source and Secondary","Will be deleted from both Source and destination " & $SecondaryArray[$z])
       FileDelete("C:ArrayDestination" & $SecondaryArray[$z])
       FileDelete("C:ArraySource" & $SecondaryArray[$z])
       $z = $z + 1
   Else
      ;MsgBox(0,"Secondary Only","Will only be deleted from Secondary")
      FileDelete("C:DesktopArrayDestination" & $SecondaryArray[$z])
      $z = $z + 1
  EndIf

  $Loop = $Loop + 1

Until $Loop = 200

Edited February 20, 2012 by Melba23
Added code tags

[somdcomputerguy]

Increment the $z variable after the If loop, not in it. I think..

[prgwkp]

That should not make a difference. I went ahead and tested that to make sure though, same outcome.

[KaFu]

For me it looks like it does exactly what I would expect, check the console output.

expandcollapse popup

Global $SourceLocationArray[200]
Global $SecondaryArray[200]

$SecondaryArray[0] = "1.PDF"
$SecondaryArray[1] = "2.PDF"
$SecondaryArray[2] = "3.PDF"
$SecondaryArray[3] = "4.PDF"
$SecondaryArray[4] = "5.PDF"

$SourceLocationArray[0] = "1.PDF"
$SourceLocationArray[1] = "2.PDF"
$SourceLocationArray[2] = "3.PDF"
$SourceLocationArray[3] = "4.PDF"
$SourceLocationArray[4] = "5.PDF"
$SourceLocationArray[5] = "6.PDF"

$z = 0
$Loop = 0

Do

    If $SecondaryArray[$z] = $SourceLocationArray[$z] Then
        ;MsgBox(0,"Source and Secondary","Will be deleted from both Source and destination " & $SecondaryArray[$z])
        ConsoleWrite($z & @tab & $Loop & @tab & "Will be deleted from both Source and destination " & $SecondaryArray[$z] & @crlf)
        ;FileDelete("C:ArrayDestination" & $SecondaryArray[$z])
        ;FileDelete("C:ArraySource" & $SecondaryArray[$z])
        $z = $z + 1
    Else
        ;MsgBox(0,"Secondary Only","Will only be deleted from Secondary")
        ConsoleWrite($z & @tab & $Loop & @tab & "Will only be deleted from Secondary" & @crlf)
        ;FileDelete("C:DesktopArrayDestination" & $SecondaryArray[$z])
        $z = $z + 1
    EndIf

    $Loop = $Loop + 1

Until $Loop = 200

[BrewManNH]

A much easier way of accomplishing what you want with only one variable is to use a For...Next loop instead of using $z and $Loop you can do it this way:

For $z = 0 To 199

    If $SecondaryArray[$z] = $SourceLocationArray[$z] Then
        ConsoleWrite('@@ Debug(' & @ScriptLineNumber & ') : $SourceLocationArray[$z] = ' & $SourceLocationArray[$z] & @crlf & '>Error code: ' & @error & @crlf) ;### Debug Console
        ;MsgBox(0,"Source and Secondary","Will be deleted from both Source and destination " & $SecondaryArray[$z])
;~      FileDelete("C:ArrayDestination" & $SecondaryArray[$z])
        ConsoleWrite('@@ Debug(' & @ScriptLineNumber & ') : $SecondaryArray[$z] = ' & $SecondaryArray[$z] & @crlf & '>Error code: ' & @error & @crlf) ;### Debug Console
;~      FileDelete("C:ArraySource" & $SecondaryArray[$z])
;~      $z = $z + 1
        ConsoleWrite('@@ Debug(' & @ScriptLineNumber & ') :         $z = ' &        $z & @crlf & '>Error code: ' & @error & @crlf) ;### Debug Console
    Else
        ;MsgBox(0,"Secondary Only","Will only be deleted from Secondary")
;~      FileDelete("C:DesktopArrayDestination" & $SecondaryArray[$z])
        ConsoleWrite('@@ Debug(' & @ScriptLineNumber & ') : $SecondaryArray[$z] = ' & $SecondaryArray[$z] & @crlf & '>Error code: ' & @error & @crlf) ;### Debug Console
;~      $z = $z + 1
    EndIf

;~  $Loop = $Loop + 1

;~ Until $Loop = 200
Next

[prgwkp]

After seeing the console out, I now see that once it the arrays are empty it then goes into the IF statement and the first statement is true at that point and it goes and deletes all contents of both folders. This is because the the array is empty to it deletes all in the directory because it does not specify a file. I though by adding the line of code ...

If $SecondaryArray[$z] Or $SourceLocationArray[$z] = "" Then
 MsgBox(0,"","Exit Loop")
 ExitLoop
   EndIf

would resolve this, but it did not.

Here is the full updated code, what can I do to say if there is a blank array variable in either array to exit loop?

expandcollapse popup

Global $SourceLocationArray[200] 
Global $SecondaryArray[200]

$SecondaryArray[0] = "1.PDF"
$SecondaryArray[1] = "2.PDF"
$SecondaryArray[2] = "3.PDF"
$SecondaryArray[3] = "4.PDF"
$SecondaryArray[4] = "5.PDF"

$SourceLocationArray[0] = "1.PDF"
$SourceLocationArray[1] = "2.PDF"
$SourceLocationArray[2] = "3.PDF"
$SourceLocationArray[3] = "4.PDF"
$SourceLocationArray[4] = "5.PDF"
$SourceLocationArray[5] = "6.PDF"


$z = 0
$Loop = 0
Do

   If $SecondaryArray[$z] Or $SourceLocationArray[$z] = "" Then
      MsgBox(0,"","Exit Loop")
      ExitLoop
  EndIf


   If $SecondaryArray[$z] = $SourceLocationArray[$z] Then
       MsgBox(0,"Source and Secondary","Will be deleted from both Source and destination " & $SecondaryArray[$z])
       FileDelete("C:Documents and SettingsprgwkpDesktopArrayDestination" & $SecondaryArray[$z])
       FileDelete("C:Documents and SettingsprgwkpDesktopArraySource" & $SecondaryArray[$z])
       ;$z = $z + 1
  Else
       MsgBox(0,"Secondary Only","Will only be deleted from Secondary")
       FileDelete("C:Documents and SettingsprgwkpDesktopArrayDestination" & $SecondaryArray[$z])
       ;$z = $z + 1
   EndIf
   $z = $z + 1

   $Loop = $Loop + 1

Until $Loop = 200

Edited February 20, 2012 by Melba23
Added code tags

[prgwkp]

Thanks, I agree BrewManNH, but that will not solve the problem I am having.

[Melba23]

prgwkp,

If you post code, please use Code tags - put [autoit] before and [/autoit] after your posted code. I will amend the earlier posts in this thread - you do it from now on - deal?

M23

[BrewManNH]

Try adding this line just before your first If/Then statement in the loop in the code I gave you:

If $SecondaryArray[$z] = "" Or $SourceLocationArray[$z] = "" Then ExitLoop

It will exit the loop if either of the array elements are blank.

[prgwkp]

Melba23, I apologize, first time ever posting, I will use the tags you mentioned.

BrewManNH, that worked, thank you for your help!

[KaFu]

Maybe this is of use to you, thought this is what you're after , check every element of array a against every element of array b.

Global $SourceLocationArray[200]
Global $SecondaryArray[200]

$SecondaryArray[0] = "1.PDF"
$SecondaryArray[1] = "2.PDF"
$SecondaryArray[2] = "3.PDF"
$SecondaryArray[3] = "4.PDF"
$SecondaryArray[4] = "5.PDF"

$SourceLocationArray[0] = "1.PDF"
$SourceLocationArray[1] = "2.PDF"
$SourceLocationArray[2] = "3.PDF"
$SourceLocationArray[3] = "4.PDF"
$SourceLocationArray[4] = "5.PDF"
$SourceLocationArray[5] = "6.PDF"

; Use a Buffer

Global $sBuffer
For $i = 0 To UBound($SourceLocationArray) - 1
    $sBuffer &= ";" & $SourceLocationArray[$i] & ";"
Next

For $i = 0 To UBound($SecondaryArray) - 1
    If $SecondaryArray[$i] Then
        If StringInStr($sBuffer, ";" & $SecondaryArray[$i] & ";") Then
            ConsoleWrite("Will be deleted from both Source and destination" & @TAB & $SecondaryArray[$i] & @CRLF)
        Else
            ConsoleWrite("Will only be deleted from Secondary" & @TAB & $SecondaryArray[$i] & @CRLF)
        EndIf
    EndIf
Next