any way to improve this small script?

[royalmarine]

hi guys,

this works, but not as well as id like. is there anyway i can improve it?

I will be replacing the notepad.exe process with another program.

While 1
   Ping("192.168.1.2", 250)
      If @error = 0 And ProcessExists("notepad.exe") Then
      ProcessClose("notepad.exe")
      sleep(1000)
      ElseIf @error = 0 Then
      Sleep(1000)
      Else
      Run("notepad.exe")
      sleep(1000)
     
      EndIf
   sleep(1000)
WEnd

[AlmarM]

This is how I would write it.

While Sleep(1000)
    Ping("192.168.1.2", 250)

    If (Not @error And ProcessExists("notepad.exe")) Then
        ProcessClose("notepad.exe")
        Sleep(1000)
    ElseIf (Not @error) Then
        Sleep(1000)
    Else
        Run("notepad.exe")
        Sleep(1000)
    EndIf
WEnd

But, what do you want to improve? What's "but not as well as I'd like" ?

[royalmarine]

cheers almarM, using the not true statement makes more sense.

ive modified it going on your alteration, and this seems to work a lot better.

While Sleep(3000)
    Ping("192.168.1.2", 250)

   If (Not @error And ProcessExists("notepad.exe")) Then
        ProcessClose("notepad.exe")
        Sleep(3000)
   ElseIf (Not @error) Then
        Sleep(3000)
     Else
         If (Not ProcessExists("notepad.exe")) Then
             Run("notepad.exe")
      Else
             Sleep(500)
      EndIf
   Sleep(500)
   EndIf
WEnd

I think where I was going wrong and thus the "not as id like it to" remark was the final statement I added in which the program doesnt open multiple times, but closes once the condition is met.

cheers for the help!