quick ping question

[royalmarine]

hi guys, trying to set a ping function to check for a device available.

here's my code so far

if Ping($targetIP, 250) = 0 Then
      $NetworkDevice = False
      sleep(3000)
Else
      msgbox(0, '', 'device reachable')
      sleep(3000)
EndIf

however, I'm having mixed results from this, so i want to add in a count.

lets say it tries to ping 5 times. and if less than 3 of these are successful, then it says the device is not reachable.

if 3 or more are successful, then i want it to say the device is reachable.

so, i think something like this would work

Ping($targetIP, 250)
if Not @error Then $Count +=1
     if $count <3 Then
           msgbox(0. ''. 'device not reachable')
     else if $Count >=3 Then
           msgbox(0,'', 'device reachable')
     EndIf
EndIf

but i can't seem to figure out what I'm doing wrong with it..

any suggestions would be amazing!

Edited May 1, 2012 by royalmarine

[royalmarine]

ok, after reading over my code, clearly I'm doing it wrong.

the count will obviously return a fail twice then success after since the count increases etc...

so i think i need a for loop in there to do the ping 5 times, each time increasing the count.

once its done 5 times, return the result, and then reset the count back to 0...

can anyone possibly help a bit with this? I've never used a for loop in auto it

[royalmarine]

ok, this is what I've tried so far, think I'm close as I'm not getting any error's, just it always comes back with a fail.

Local $Count
$TargetIP = "192.168.1.2"
  
While 1  
  
$Count1 = 0
$Count2 = 0
Do
   Ping($targetIP, 250)
If Ping($TargetIP, 250) = 0 Then
  $Count1 +=1
    ElseIf Ping($TargetIP, 250) = 1 Then
  $Count1 +=1
  $Count2 +=1
  EndIf
Until $Count1 = 5
If $Count2 <3 Then
   MsgBox(0, '', 'fail')
Else
   MsgBox(0, '', 'Success')
   EndIf
  
   WEnd

Edited May 1, 2012 by royalmarine

[royalmarine]

ok, think I've fixed this.

I've altered it like this

Local $Count
$TargetIP = "192.168.1.2"
 
While 1 
 
$Count1 = 0
$Count2 = 0
Do
   Ping($targetIP, 250)
If Ping($TargetIP, 250) = 0 Then    ; ping fails
  $Count1 +=1
    Else                                            ; ping doesn't fail
  $Count1 +=1
  $Count2 +=1
  EndIf
Until $Count1 = 5
If $Count2 <3 Then
   MsgBox(0, '', 'fail')
Else
   MsgBox(0, '', 'Success')
   EndIf

it works. when i disconnect the device from network it fails.

when i connect it, msgbox reports success.

I've also added @error to my msgbox and I'm getting a result of 0 when the device is on

and a result of 4 when the device is off.

[royalmarine]

one last thing to add, i forgot to rest the $count1 and $count2 back to 0 once the loop had completed.

once i did this, it works fine

[BrewManNH]

Edit button broken?