5 Digit Number Generator Problem

[PhoenixXL]

added probability check

expandcollapse popup

#include <Array.au3>
Local $iNumbers
Local $iDigits = 3
Local $t = TimerInit()
For $n = 0 To 1000
_RandomEx($iNumbers, $iDigits); Randomize without Repetition
Next
ConsoleWrite('Timer:' & TimerDiff($t) & @CR)
_ArrayDisplay($iNumbers, 'RandomEx | Phoenix XL [' & @ScriptName & ']')

Func _RandomEx(ByRef $aNumbers, $nDigits = 5);Converted from Recursive to Iterative
;All the Possible Numbers have been added return -1 and set @error
If UBound($aNumbers) >= ((10 ^ $nDigits) - 1) - (10 ^ ($nDigits - 1)) + 1 Then Return SetError(1, 0, -1)
Local $vTemp, $nChk = 0
While 1
$vTemp = Random(10 ^ ($nDigits - 1), (10 ^ $nDigits) - 1, 1)
_ArraySearch($aNumbers, $vTemp)
If @error Or $nChk >= (10 ^ ($nDigits/2) ) - 1 Then ExitLoop
$nChk += 1
WEnd
If $nChk >= (10 ^ $nDigits) - 1 Then $vTemp = _ProbabilityCheck($aNumbers, $nDigits)
Switch IsArray($aNumbers)
Case 0
;Make it an Array
Local $n[1] = [$vTemp]
$aNumbers = $n
Case 1
_ArrayAdd($aNumbers, $vTemp)
EndSwitch
Return $vTemp
EndFunc ;==>_RandomEx

Func _ProbabilityCheck(ByRef $aNumbers, $nDigits)
For $n = 10 ^ ($nDigits - 1) To (10 ^ $nDigits) - 1
_ArraySearch($aNumbers, $n)
If @error Then
_ArrayAdd($aNumbers,$n)
Return $n;
EndIf
Next
Return -1
EndFunc ;==>_ProbabilityCheck

[MvGulik]

Just a general random thought:

Think that in general Random() should not be used to generate separate unique numbers on the fly. If the generated amount of numbers will covers more than 50% of the target number set/range (personally I would stop around 25%). In those cases czardas method in post #5 should be the way to go. CQ. Using random() to randomize the whole sequential number set, and then picking off the numbers one by one of that list (Smartly used it can be made to handle pretty big number set's. ... If needed).

For additional code examples ... Taking it to the example section probably not a bad idea.

[Victorique]

­

[Venix]

Dam you Victorique I was waiting for this thread to die.

/Thread.

Edited October 6, 2012 by Venix

[FireFox]

Funny guys.

[Victorique]

Funny guys.

Oh,you ♥ Edited October 7, 2012 by Victorique