User Error or Bug w/ If/ElseIf/Else

[Colyn1337]

Hello Community!

Before I submit a bug report, I wanted to see if maybe my problem is, well, me... Haha.. Anyways, I'm using an If/ElseIf/Else on a WMI Query to capture info. However, if the "If" or even the "ElseIf" statement is true, the "Else" is somehow true as well. My thinking was that the code was supposed to check the "If" and if it is false proceed thru the "ElseIf" statements until it found one to be true. Otherwise, it uses "Else" as the catchall. The problem I've run into, is that even tho the "If" or "ElseIf" is true, the code still runs the "Else". See code below...

$objWMI = ObjGet("winmgmts:\\" & @ComputerName & "\root\HP\InstrumentedBIOS")
     If $objWMI = ("") Then Exit
     $colItems = $objWMI.ExecQuery("SELECT * FROM HPBIOS_BIOSString", "WQL", 0x20)

     If IsObj($colItems) Then
      For $objItems In $colItems
       If $objItems.Name = "Product Number" Then ; Newer laptops use this name
        $ProdNum = $objItems.Value
       ElseIf $objItems.Name = "SKU Number" Then ; Older laptops use this name
        $ProdNum = $objItems.Value
       Else
       $ProdNum = "Not Detectable"
       EndIf
      Next
     EndIf

As a work around I've had to code it this way...

$objWMI = ObjGet("winmgmts:\\" & @ComputerName & "\root\HP\InstrumentedBIOS")
     If $objWMI = ("") Then BasicSet()
     $colItems = $objWMI.ExecQuery("SELECT * FROM HPBIOS_BIOSString", "WQL", 0x20)
     If IsObj($colItems) Then
      For $objItems In $colItems
       If $objItems.Name = "Product Number" Then ; Newer laptops use this name
        $ProdNum = $objItems.Value
       ElseIf $objItems.Name = "SKU Number" Then ; Older laptops use this name
        $ProdNum = $objItems.Value
       EndIf
       If $ProdNum = "" Then $ProdNum = "Not Detectable"
      Next
     EndIf

So, am I wrong in my thinking of how If/ElseIf/Else is supposed to work? Or is something else going on?

[jdelaney]

Put in some debugging, like a ConsoleWrite prior to the inner most If statement. something like this, possibly white spaces you aren't accounting for?

ConsoleWrite ( "ObjectName= [" & $objItems.Name & "]...=? Product Number [" & ($objItems.Name = 'Product Number') & "]...=? SKU Number [" & ($objItems.Name = 'SKU Number') & "]." & @CRLF)

Also, you are doing a loop, and returning ALL values of that loop to one variable, so that variable is in effect only being set by the last $objItems.Name.

Edited June 1, 2012 by jdelaney

[water]

How about:

If IsObj($colItems) Then
    For $objItems In $colItems
        If $objItems.Name = "Product Number" Or $objItems.Name = "SKU Number" Then ; Newer laptops use this name
            $ProdNum = $objItems.Value
        Else
            $ProdNum = "Not Detectable"
        EndIf
    Next
EndIf

[Melba23]

Colyn1337,

am I wrong in my thinking of how If/ElseIf/Else is supposed to work?

No.

Or is something else going on?

Obviously, but I have no idea what.

Is that code designed for any laptop - it looks as if it is for HP only which will limit your available testers. This amended code works fine for me though:

;$objWMI = ObjGet("winmgmts:" & @ComputerName & "rootHPInstrumentedBIOS")
;If $objWMI = ("") Then Exit
;$colItems = $objWMI.ExecQuery("SELECT * FROM HPBIOS_BIOSString", "WQL", 0x20)

Global $colItems[3] = ["Product Number", "SKU Number", "fred"]

;If IsObj($colItems) Then
    For $objItems In $colItems
        If $objItems = "Product Number" Then ; Newer laptops use this name
            $ProdNum = "ProdN" ;$objItems.Value

        ElseIf $objItems = "SKU Number" Then ; Older laptops use this name
            $ProdNum = "SKUN" ;$objItems.Value
        Else
            $ProdNum = "Not Detectable"
        EndIf

        ConsoleWrite($ProdNum & @CRLF)

    Next
;EndIf

M23

[armoros]

I am on HP laptop but the code doesn't work.

ProdN

SKUN

Not Detectable

+>19:42:52 AutoIT3.exe ended.rc:0

>Exit code: 0 Time: 2.105

[Melba23]

armoros,

My script can be run anywhere - it was just to show that the If...ElseIf...Else worked.

Could you please run the code in the original post (adding the ConsoleWrite($ProdNum & @CRLF) line) and see what you get?

M23

[jdelaney]

based on his output, the function ran exactly as you supplied it, Melba23

[armoros]

armoros,

My script can be run anywhere - it was just to show that the If...ElseIf...Else worked.

Could you please run the code in the original post (adding the ConsoleWrite($ProdNum & @CRLF) line) and see what you get?

M23

yes i added the line

ConsoleWrite($ProdNum & @CRLF)

It runs ok with no error output, but nothing else..

[UEZ]

Try this:

$objWMI = ObjGet("winmgmts:" & @ComputerName & "rootHPInstrumentedBIOS")
$colItems = $objWMI.ExecQuery("SELECT * FROM HPBIOS_BIOSString", "WQL", 0x20)
If IsObj($colItems) Then
    For $objItems In $colItems
        Switch $objItems.Name
            Case "Product Number", "SKU Number"
                $ProdNum = $objItems.Value
            Case Else
                $ProdNum = "Not Detectable"
       EndSwitch
    Next
EndIf
ConsoleWrite($ProdNum & @LF)

Br,

UEZ

[Colyn1337]

Oh wow...... I just figured out what's wrong..... and boy am I an idiot

The variable $ProdNum is being overwritten because the if/elseif/else statement runs in a For/Next loop..... Whatever the last item in the query is wins on the control of that variable....... Which is never "Product Number" or "SKU Number"...

#FacePalm($MyHead)

EDIT 1:

Thank you to everyone who replied...

BTW, in our environment we have HP Probooks (6550, 6560, etc)... I'm not sure if they expose the bios in their home use products.

EDIT 2:

Figured out the solution.... ExitLoop (see below)

$objWMI = ObjGet("winmgmts:" & @ComputerName & "rootHPInstrumentedBIOS")
If $objWMI = ("") Then Exit
$colItems = $objWMI.ExecQuery("SELECT * FROM HPBIOS_BIOSString", "wql", 0x20)
If IsObj($colItems) Then
For $objItems In $colItems
  If $objItems.Name = "Serial Number" Then
   $Serial = $objItems.Value
   ExitLoop
  ElseIf $objItems.Name = "Chassis Serial Number" Then
   $Serial = $objItems.Value
   ExitLoop
  Else
  $Serial = "not detectable."
  EndIf
Next
EndIf
ConsoleWrite($Serial & @LF)

Edited June 1, 2012 by Colyn1337

[Colyn1337]

Oooooo...... That's just...... Beautiful!

EDIT: And it looked so promising... This code produces an end result of "Not Detectable"... Which is probably for the same reason my original code didn't work either......

Try this:

$objWMI = ObjGet("winmgmts:" & @ComputerName & "rootHPInstrumentedBIOS")
$colItems = $objWMI.ExecQuery("SELECT * FROM HPBIOS_BIOSString", "WQL", 0x20)
If IsObj($colItems) Then
    For $objItems In $colItems
        Switch $objItems.Name
            Case "Product Number", "SKU Number"
                $ProdNum = $objItems.Value
            Case Else
                $ProdNum = "Not Detectable"
       EndSwitch
    Next
EndIf
ConsoleWrite($ProdNum & @LF)

Br,

UEZ

Edited June 1, 2012 by Colyn1337

[armoros]

This is mine output after UEZ's suggestion

==> Variable must be of type "Object".:

$colItems = $objWMI.ExecQuery("SELECT * FROM HPBIOS_BIOSString", "WQL", 0x20)

$colItems = $objWMI^ ERROR

->20:53:03 AutoIT3.exe ended.rc:1

>Exit code: 1 Time: 2.160

[Colyn1337]

This is mine output after UEZ's suggestion

Yea, you'll get that if it couldn't find/create an object......

This is likely because you don't have the roothpinstrumentedbios namespace (not using an HP machine). Or, you didn't create/retrieve your object (e.g. $objWMI = ObjGet("winmgmts:" & @ComputerName & "rootHPInstrumentedBIOS") )

[UEZ]

$objWMI = ObjGet("winmgmts:" & @ComputerName & "rootHPInstrumentedBIOS") has not error check and probably the WMI class rootHPInstrumentedBIOS doesn't exist on your machine!

Br,

UEZ

[Colyn1337]

$objWMI = ObjGet("winmgmts:" & @ComputerName & "rootHPInstrumentedBIOS") has not error check and probably the WMI class rootHPInstrumentedBIOS doesn't exist on your machine!

Br,

UEZ

Ha, I had the same thought...... Tho, incase anyone missed it, see post #10 for the solution....

[jdelaney]

Ahem, @post number 2 (pat self on back)