IF statement processing all conditions

[Tripredacus]

I'm having a brainfart I think, made a simple mistake but I can't figure it out. I've got part of a script where I have a conditional statement inside of a For loop, and while the program *works* I end up getting MsgBox for each of the Else fallbacks. Now, ideally this wouldn't be an issue since there should only be 1 value to match against in the For loop, but in testing we may end up having multiple values. So here is basically what I have:

For $r = 1 to Ubound($data) -1
If $data[$r][6] == $var2 Then
If FileExists ($xmlFile) Then
     ; do some stuff
Else
     MsgBox (4096, "Error", "The XML file was not found")
EndIf
Else
MsgBox (4096, "Error", "values do not match")
EndIf
Next

So basically, if there are multiple values to match against, I end up getting x amount of "values do not match" MsgBoxes, and also the match condition processes as well.

What did I mess up?

Edited June 27, 2012 by Tripredacus

[JohnOne]

There is absolutely no reason at all that with that code you shown, that the both message boxes should show.

[zorphnog]

Not sure if this is a typo in the post or in your code, but $ is not a valid index. Did you intend to use $r?

If $data[$r][6] == $var2 Then

Edited June 26, 2012 by zorphnog

[Tripredacus]

Not sure if this is a typo in the post or in your code, but $ is not a valid index. Did you intend to use $r?

If $data[$r][6] == $var2 Then

It isn't a typo. The XML file can have multiple (duplicate) objects in it. So it is only the 6th child item in an object that I need. But I do not know which object it is in, so I need to read through all of them to find the correct one. The value of $var2 will never be the same between different objects, so I can use that as a compare.

Either way, that part of the code DOES work fine, its just that the mismatch condition (show error MsgBox) gets called on all the objects where the 6th child object does not match.

[zorphnog]

I understand what you are trying to do by looping through the data, the part I was referring to is that in your original post you have $data[$][6] instead of $data[$r][6]. This is a syntax error.

The logic is sound. I think I just misunderstood your question. I think you basically want one of two results: a message of that the item was found or a message that none of the rows in the data array matched. In that case you need to handle the 'no match' case outside of the for loop:

Dim $bFound = False

For $r = 1 to Ubound($data) -1
  If $data[$][6] == $var2 Then
    If FileExists ($xmlFile) Then
      ; do some stuff
      MsgBox(4096, "Found", "Found element")
      $bFound = True
      ExitLoop
    Else
      MsgBox (4096, "Error", "The XML file was not found")
    EndIf
 EndIf
Next

If Not $bFound Then MsgBox (4096, "Error", "values do not match")

Edited June 26, 2012 by zorphnog

[Tripredacus]

Oh yes, sorry it was a typo.

I will definately try that out, but first I ran into another problem! Testing this code on a result where the value of $data is only in 1 dimension, I get a subscript error. :\

[Mechaflash]

Share Moar Code.

[BrewManNH]

Oh yes, sorry it was a typo.

I will definately try that out, but first I ran into another problem! Testing this code on a result where the value of $data is only in 1 dimension, I get a subscript error. :

If there's only one dimension in the array, this code will definitely give you that error because it's written to assume that the array is 2 dimensions and that it has at least 7 elements in the second dimension. If you want it to work with arrays of varying sizes, you'll need to account for that in your code.

[zorphnog]

Testing this code on a result where the value of $data is only in 1 dimension, I get a subscript error. :

Try:

Dim $bFound = False

Switch UBound($data, 0)
    Case 1:
        If $data[6] == $var2 Then
            If FileExists ($xmlFile) Then
                ; do some stuff
                MsgBox(4096, "Found", "Found element")
                $bFound = True
            Else
                MsgBox (4096, "Error", "The XML file was not found")
            EndIf
        EndIf
    Case 2:
        For $r = 1 to Ubound($data) - 1
            If $data[$r][6] == $var2 Then
                If FileExists ($xmlFile) Then
                    ; do some stuff
                    MsgBox(4096, "Found", "Found element")
                    $bFound = True
                    ExitLoop
                Else
                    MsgBox (4096, "Error", "The XML file was not found")
                EndIf
            EndIf
        Next
EndSwitch

If Not $bFound Then MsgBox (4096, "Error", "values do not match")

Edited June 27, 2012 by zorphnog

[Tripredacus]

Strangely enough, with that code, I wasn't getting a match. So I did some MsgBox tests and found that I was getting an array size of 2 as the Ubound on data. I'm not certain how this ended up being the case (no pun intended), so I made 2 changes.

Switch Ubound($data, 0) -1
        Case 1
            If $data[$r][6] == $var2 Then
                BindData()
            EndIf
        Case 2 To 10
            For $r = 1 to Ubound($data) -1
                If $data[$r][6] == $var2 Then
                    BindData()
                EndIf
            Next
        Case 0
            MsgBox (4096, "Debug", "Case value is 0")
        Case Else
            MsgBox (4096, "Debug", "More than 10 allocations")
    EndSwitch

So the first change was to add -1 to the Ubound in the Switch statement. The second was to use the [$r] in the Case 1 compare.

PS: AutoIT doesn't like colons after the Case numbers.

[zorphnog]

Hmm...ok. If it works that's great. What is the value of $r in your Case 1 statement though?

As far as the case statements, I wish every language would adopt the same convention. Must have had my C/C++ coding hat on.

[Tripredacus]

The value of $r in Case 1 is 1. It comes from a function a co-worker wrote.