Noobie problem :)

[Unc3nZureD]

Hi guys,

Here my code is:

Func _DirGetWrongFiles()
    $ForbiddenFiles = _FileListToArray(@ScriptDir, "*", 1)
    $Count = 1

    While 1
        If StringRight($ForbiddenFiles[$Count], 3) <> "exe" or "cfg" or "ini" or "txt" Then
            $Delete = FileDelete(@ScriptDir & "/" & $ForbiddenFiles[$Count])
            If $Delete = 0 Then Msgbox(0,"","Forbidden File Found" & @CRLF & $ForbiddenFiles[$Count])
        EndIf

       $Count = $Count + 1
       If $Count = $ForbiddenFiles[0] + 1 Then ExitLoop
    WEnd
EndFunc

It will delete every file in the directory. Why?

Edited July 2, 2012 by Unc3nZureD

[Zedna]

Instead of this

If StringRight($ForbiddenFiles[$Count], 3) <> "exe" or "cfg" or "ini" or "txt" Then

use something like this

$ext = StringRight($ForbiddenFiles[$Count], 3)
If $ext <> "exe" or $ext <> "cfg" or $ext <> "ini" or $ext <> "txt" Then

EDIT: Shouldn't be there AND instead of OR?

Edited July 2, 2012 by Zedna

[Unc3nZureD]

AND? How can a 3 letter text be 'txt' and 'exe' too?! (for example)

Edited July 2, 2012 by Unc3nZureD

[DicatoroftheUSA]

"AND? How can a 3 letter text be 'txt' and 'exe' too?! (for example)"

example

ext=exe

if exe<> exe (false) or exe <>cfg (true)

The result: true or false=always true.

Edited July 2, 2012 by DicatoroftheUSA

[Unc3nZureD]

In my case I can't understand the 'AND' statement.

for example:

$ext = "exe"

If $ext <> "cfg" or "exe" Then ...

Only one has to be true. if th cfg is false it all the same I just need to get if ANY of the list is true.

EDIT: LEARNING STATEMENTS

Edit2:

Argh, still can't understand :S

Func _DirGetWrongFiles()
$ForbiddenFiles = _FileListToArray(@ScriptDir, "*", 1)
$Count = 1

While 1
$ext = StringRight($ForbiddenFiles[$Count], 3)
If $ext <> "exe" or $ext <> "cfg" or $ext <> "ini" or $ext <> "txt" Then
$Delete = FileDelete(@ScriptDir & "/" & $ForbiddenFiles[$Count])
If $Delete = 0 Then _HackFound("Forbidden Files Found" & @CRLF & $ForbiddenFiles[$Count])
EndIf

$Count = $Count + 1
If $Count = $ForbiddenFiles[0] + 1 Then ExitLoop
WEnd
EndFunc

Still not working :S

Edited July 2, 2012 by Unc3nZureD

[BrewManNH]

Here's some pseudo code to explain why it has to use AND and not OR.

$ext = "exe"
If $ext <> "exe" then delete the file ; pretty simple if it's not exe then delete
If $ext <> "exe" Or $ext <> "cfg" Then delete the file ; using Or says if Either one is true delete the file, in this case, it doesn't match "cfg" so the file is deleted
If $ext <> "exe" AND $ext <> "cfg" then delete the file ; Using AND says if ALL matches are false then delete the file, if ANY extension matches then skip it, because $ext = "exe" that comparison is true, and we don't want to delete the file

You can't just string the conditional checks together the way you did, you have to do a comparison for every extension you're looking for. So you need AND $ext <> before every case.

[DicatoroftheUSA]

Computer logic

1 = true

0 or 0 = 0

1 or 0 = 1

1 or 1 = 1

0 and 0 = 0

1 and 0 = 0

1 and 1 = 1

eg:

if exe<> exe or exe <>cfg

is logically equivalent to: 0 or 1 = 1

or another eg:

if abc<> exe or abc <>cfg

is logically equivalent to: 1 or 1 = 1

So effectively your expression is always true.

[Reg2Post]

AND? How can a 3 letter text be 'txt' and 'exe' too?! (for example)

I think you are thinking along the lines of "=" (Equal to) where your code is "<>" (Not equal to). Yes, you cannot have $ext = exe AND $ext = txt (for the sake of this conversation). But you can have $ext <> exe AND $ext <> txt.

[Exit]

If Not StringInStr("exe cfg ini txt",$ext) Then FileDelete(........)

[Mechaflash]

Using AND makes it so that ALL rules must apply. Using OR makes it so that ANY rules apply. So when you say If $ext <> exe OR $ext <> txt, they negate eachother. So if the file is a .txt, it sees the first statement "If $ext <> exe" so automatically it thinks, "It's not exe so then perform the action." If it is exe, then it looks at the first statement, "it's an exe... look at the next statement", and it sees "If $ext <> txt", "well it's not txt so then perform the action." So those first two statements alone targets all file extensions

[John]

I still make this mistake sometimes.. Luckily I don't have to ask what went wrong.