New to AutoIt - Help with an Array

[Zoreal 0]

I'm getting an error - Any help diagnosing is appreciated.

Error: "Array variable has incorrect number of subscripts or subscript dimension range exceeded."

The error happens on the "$FileHandlerArray..." line when calling this function.

Func FileHandlerArray($FileNamesArray)
   Dim $FileHandlerArray[UBound($FileNamesArray) - 1]
   For $i = 0 To UBound($FileNamesArray) - 1
 $FileHandlerArray[$i] = FileOpen($FileNamesArray[$i])
   Next
   Return $FileHandlerArray
EndFunc

The helpfile stated that prior to setting array values, you must declare it using dim. I did so using the ubound expression within brackets. The helpfile also stated expressions within array brackets was supported. I'm just not sure where I've gone wrong here.

Thank you in advance for any help...

Z

[JohnQSmith 40]

I'm not sure you can have a function and a variable named the same thing.

[Zoreal 0]

I'm not sure you can have a function and a variable named the same thing.

I verified this isn't the cause of the issue - My function is now called "_FileHandlerArray"

[Melba23 3,396]

Zoreal,

Welcome to the AutoIt forum.

You are creating the second array with one less element that you need:

Global $FileNamesArray[10] ; UBound = 10 -> 0-9

Func FileHandlerArray($FileNamesArray)
    Local $FileHandlerArray[UBound($FileNamesArray) - 1] ; created as UBound = 9 -> 0-8
    For $i = 0 To UBound($FileNamesArray) - 1 ; Here we go from 0 - 9
        $FileHandlerArray[$i] = FileOpen($FileNamesArray[$i]) ; And here we try to open $FileHandlerArray[9] which does not exist
    Next
    Return $FileHandlerArray
EndFunc   ;==>FileHandlerArray

You need to create the second array with the same number of elements:

Local $FileHandlerArray[UBound($FileNamesArray)] ; created as UBound = 10 -> 0-9

All clear?

And note I used Global/Local and not Dim - read the Variables - using Global, Local and ByRef tutorial in the Wiki to see why.

M23

[BrewManNH 1,304]

You're declaring the $FileHandlerArray with one too few elements, you're subtracting one from the $FileNamesArray and then trying to loop through the array up to its Ubound - 1, if the incoming array has for example 175 elements, you're declaring $FileHandlerArray to 174.

[Zoreal 0]

So an array declaration's number within brackets is the quantity of elements - not the highest element?

Global $Array[10] 
UBound($Array) = 10 ; True? (Elements 0-9 or 0-10)

[BrewManNH 1,304]

Correct, it's the total number of elements. Which is why you have to subtract 1 from the total when looping through an array, because in your example there are 10 elements, but they only go up to 9 (0-9).

[Melba23 3,396]

Zoreal,

Correct.

I would have chosen a different name for the UBound function, but that is what we have got.

M23