Would this be a nitpick bug in FileExists?

[John 5]

FileExists returns a false negative if the path string is quoted. Windows sometimes uses these quotes to distinguish between path and argument parts of a path string. Thus a path variable pulled from the registry must have the quotes stripped or FileExists gives a false negative. The dos exist command, comspec and the FileOpenDialog, with the "File Must Exist" flag set, also allows these quotes.

Fixing this could also provide a method of extend the utility of FileExists and FileOpenDialog's "File Must Exist" flag without breaking any existing scripts. If FileExists optionally allowed these quotes, and only validated the string within the first pair of quotes if they exist, then script developers could easily validate a files existance even when it contains arguments quotes. Such as variables defined by path strings pulled from the registry, user supplied, etc.

Of course a script developer can easily provide this functionality themselves by providing a wrapper function for FileExists.

[Bert 1,512]

John, did you do a search on how to put in quotes properly? If you did you would know the answer to your inquiry. (That it has been answered countless number of times)

[BrewManNH 1,315]

It's not an AutoIt issue, it's a Windows issue, see for an explanation and other alternative workarounds.

[John 5]

Yes, I understand how quotes work in and out of AutoIt. The point here it that when quotes are passed (as strings) in AutoIt FileExists fails, but when quotes are passed as strings from AutoIt to windows it is perfectly valid in all cases. Allowing FileExists to be passed string paths containing the quotes (as strings) then has the advantage of added functionality for working with windows and easily validating paths with arguments, which FileExists normally fails on.

Example:

$str = '"C:Program FilesWindows Media Playerwmplayer.exe"'
$test=FileExists($str)

Returns false. However:

$str = '"C:Program FilesWindows Media Playerwmplayer.exe"'
$test=Run($str)

Works fine, as it does in all cases.

This would allow strings like

'"C:Program FilesWindows Media Playerwmplayer.exe" %1'

to be properly validated as a valid path using FileExists

[John 5]

BrewManNH,

Yes, the first quotes should always be consumed by AutoIt to indicate a string. The second treated like windows treats them, as valid parameters to a path. Any beyond that is up to the script developer to deal with.

I know this is a nitpick, but also allows extended functionality if handled properly. I have used the following function as a workaround, and it finds valid paths with args even when no quotes are provided. Though after pulling some path strings from the registry it occurred to me that windows standard behavior makes requiring passing the quotes as strings, to separate paths and arguments, far superior to this method.

Func _FileExistEx($f)
$f=StringReplace($f,'"','',0,2)
Local $a=FileGetAttrib($f)
If StringInStr($a,"D",2) Then Return 1
Local $i=StringInStr($f,' ',2,1,StringInStr($f,'.',2))
Local $s=StringLeft($f,$i)
While $i<=StringLen($s)
$s=StringLeft($f,$i-1)
If FileExists($s) And Not StringInStr(FileGetAttrib($s),'D') Then Return 1
If Not StringInStr($f,' ',0,1,$i) Then Return 0
$i=StringInStr($f,' ',0,1,$i+1)
$s=StringLeft($f,$i)
WEnd
Return SetError(1) ; Shouldn't happen
EndFunc

Edited July 10, 2012 by John

[BrewManNH 1,315]

Did you even READ the thread I linked to? Because if you did you would see that it is a Windows issue and NOT an AutoIt issue. Strip the quotes before sending the string to FileExists, that is the ONLY way it's going to work. Read the whole thread and all of the discussion within it and you will see you're beating a dead horse.

[John 5]

Yes, I read the thread. In particular relevance is the _WinAPI_PathFileExists() function demonstrating a windows API handling in the same way as as FileExists. There are 2 points that moot this fact. First, AutoIt is not the windows environment, but an scripting language for interacting with the windows environment. Second, and more importantly, windows does not depend solely on this one API for validating paths, just as I am suggesting with the FileExist() function. Here's a demonstration:

FileOpenDialog ( "title", "init dir", "filter" [, options ] )

1 = File Must Exist (if user types a filename)

2 = Path Must Exist (if user types a path, ending with a backslash)

To use more than one option, add the required values together.

FileOpenDialog('Unquoted path:', @ScriptDir, "All (*.*)",3)

Now if you enter:

"C:Program FilesWindows Media Playerwmplayer.exe"

With or without quotes it comes back a valid path.

Windows is not strictly dependent on PathFileExistsW in shlwapi.dll path validation, but itself preprocesses what subset of a string to validate with that API. This is why paths and arguments are separated by individual sets of string quotes in the registry by default, so that PathFileExistsW can be applied to the proper subset of the string in relevant cases. Otherwise certain command lines would simply be too ambiguous for windows to parse.

For AutoIt, or FileExist in particular, to mimic this behavior requires validating single quoted path strings when passed as strings.

[BrewManNH 1,315]

There's a link to the BugTracker Wiki page where you can make a feature request for that, but I wouldn't hold my breath waiting for it, as there is an easy way to work around the Window's issue and the devs are reluctant to make changes to things that can be worked around if it creates more work for so very little benefit.

[John 5]

That is understandable, which is why I called it a nitpick bug. I wouldn't waste too much time simply on saving script developers a few lines of code either. It does seem a relatively straightforward and easy change though.

[John 5]

I found a description in MSDN where is is explained exactly how the quotes are used by windows and the routine windows falls back on in their absents.

http://msdn.microsoft.com/en-us/library/windows/desktop/ms682425(v=vs.85).aspx

If you are using a long file name that contains a space, use quoted strings to indicate where the file name ends and the arguments begin; otherwise, the file name is ambiguous. For example, consider the string "c:program filessub dirprogram name". This string can be interpreted in a number of ways. The system tries to interpret the possibilities in the following order:

c:program.exe filessub dirprogram name

c:program filessub.exe dirprogram name

c:program filessub dirprogram.exe name

c:program filessub dirprogram name.exe

In effect by AutoIt not accepting these quotes passed as strings as valid it forces windows to fall back into a search routine if this same sting is passed to windows by AutoIt. This can lead to an execution of the wrong program. If you have a path like:

c:program filessub dirprogram name

and a different program path exist like:

c:program filessub dir.exe

Then 'sub dir.exe' get executed in place of 'program name.exe'

This doesn't create a name collision because a 'sub dir' folder, 'sub dir.exe', and 'sub dir.bat' file can all simultaneously exist in the same folder, as well as other executable file types. 'sub.exe dir' is also a valid folder name. So windows does officially support and document the use of quotes passed as path strings. Even without any errors having these quote stings makes windows faster and more efficient without falling back on a search routine. Including the .exe doesn't in itself bypass the search routine since 'name.exe' is a perfectly valid folder name.

Edited July 25, 2012 by John

[Inverted 5]

Hmmm, the more I think about it, the more I agree with John. AutoIt could strip the extra quotes to avoid false negatives and emulate windows functions.