How to "insert" $Countlines into a loop

[xuzo]

I'm trying to have something loop the amount of lines in the text file.

So if the text file has 3 lines, I want 3 loops etc...

I'm doing something wrong with this I think:

For $numberoflines = 1 To $numberoflines Step 1

The whole thing is this:

#include <File.au3>
#include <Clipboard.au3>
Local $CountLines = _FileCountLines(@ScriptDir & "input.txt")
$numberoflines = $CountLines; $Countlines is now $numberoflines
ShellExecute("notepad.exe", @ScriptDir & "input.html")
WinWait("input - Notepad")
ShellExecute("notepad.exe", @ScriptDir & "output.html")
WinWait("output - Notepad")
WinActivate("input - Notepad")
Send("{CtrlDown}{Home}{CtrlUp}{left}")
For $numberoflines = 1 To $numberoflines Step 1
WinActivate("input - Notepad")
Send("{SHIFTDOWN}{END}{SHIFTUP}{CTRLDOWN}c{CTRLUP}")
$sclip = ClipGet()
Send("{DOWN}{HOME}")
WinActivate("output - Notepad")
Send('<a href="' & $sclip & '">' & $sclip & "</a>{enter}")
Next

Edited July 27, 2012 by xuzo

[BrewManNH]

You're using the variable $numberoflines incorrectly.

For $numberoflines = 1 To $numberoflines Step 1

You can't use it as the loop variable AND the end of the loop at the same time, change the variable name for one of them.

Also, there's no need to use Step 1 in a For Next loop, the default is to increase by 1 already, so it's redundant.

[xuzo]

Thanks Brewman but I still don't get it...I've tried all posible combinations ;(

For $Countlines

For $Countlines = $numberoflines

For $CountLines = 1

For $CountLines = 1 to $CountLines

For $CountLines = 1 to $numberoflines

What is the correct syntax to do this?

Edited July 27, 2012 by xuzo

[ajag]

xuzo,

I would name the variables more clearly.

#include <File.au3>

Local $NumOfLines = _FileCountLines(@ScriptDir & "\Test.au3") ; get number of lines
Local $Line

For $Line = 1 To $NumOfLines
; add here what to do
Next

A-Jay

[hannes08]

xuzo

your last try was okay.

In the folowing example "$i" is the counting variable.

For $i = 1 To $numberoflines
        MsgBox(0,"line", "lin number: " & $i)
Next

Edited July 27, 2012 by hannes08

[xuzo]

Thanks Ajag, this works for me:

#include
Local $NumOfLines = _FileCountLines(@ScriptDir & "input.txt") ; get number of lines
Local $Line
For $Line = 1 To $NumOfLines
MsgBox(0, "t", "The file has 3 lines and will pop up 3 times")
Next

Could it be that my mistake was this:

Local $CountLines = _FileCountLines(@ScriptDir & "input.txt")
$numberoflines = $CountLines

Instead of this:

Local $CountLines = _FileCountLines(@ScriptDir & "input.txt")
Local $numberoflines

Edited July 27, 2012 by xuzo

[JLogan3o13]

Personally I would read the file into an Array, and then manipulate the array as you need.

#include <File.au3>

Local $aArray
_FileReadToArray(@DesktopDir & "Test.txt", $aArray)

   For $i = 0 To UBound($aArray)
     MsgBox(0, "Line " & $i, "The file has " & UBound($aArray) & " lines.")
   Next

[GEOSoft]

Use the _FileReadToArray() method as pointed out by JLogan3o13 above and take a look at the For/In/Next method from the help file.

#include <File.au3>

Local $aArray, $Line
_FileReadToArray(@DesktopDir & "Test.txt", $aArray)
 
For $Line In $aArray
     ;; Do something here
Next