array var = array var multiple declarations on same line

[kor]

why does the following generate a syntax error?

Switch $sHail
    Case "StaffAdd"
        Global $aControls[9] = $aClean[$i][0], $aControls[11] = $aClean[$i][1]
EndSwitch

this works fine, but don't understand why each declaration needs to be on a separate line

Switch $sHail
    Case "StaffAdd"
        $aControls[9] = $aClean[$i][0]
        $aControls[11] = $aClean[$i][1]
EndSwitch

This also works fine. It's the same concept just not arrays.

Switch $sHail
    Case "StaffAdd"
        Local $x = 5, $y = 10
EndSwitch

[Spiff59]

When using Global or Local (or Dim, but Dim is obsolete) to declare an array you can pre-assign values to the array but those values need to be defined using brackets that match the structure of the array, i.e.:

Global $aArray[4] = [1,2,3,4]
Local $aNames[2][3] = [["bob", "tom", "joe"],["sue", "ann", "deb"]]

You can also only assign a portion of the array values. This would pre-assign values just for elements [0][0] and [1][0]:

Local $aNames[2][3] = [["bob"],["sue"]]

In declaration statements a variable such as "$aArray[9]" references (and defines) the entire array.

If not preceeded by a Global or Local (or Dim) keyword any variable such as $aArray[9] is only referencing a single element (the 9th in this case) within an array.

So, adding brackets to your first example would create an $aControls array and pre-assign a value to (just) the first element.

Global $aControls[9] = [$aClean[$i][0]]

Your second example successfully assigns a value to the 9th element of an already defined $aControls array.

There is one exception in that an entire array can be created on-the-fly without using Global/Local/Dim if you assign another array to a variable. This basically creates a copy of $aArray1:

Global $aArray1[4] = [1,2,3,4]
$aArray2 = $aArray1

Edit: remove unwanted color tags from within code tags

Edited August 9, 2012 by Spiff59

[czardas]

You don't necessarilly need to write multiple lines. If it is possible to organize your array elements in a systematic way you can often loop through the elements. With multidimensional arrays use nested loops. One problem with your first example is that you are decalring the same array twice on the same line. First you declare it to have 9 elements, then you give it a value which isn't an array, then you give a value for element number 11. Basically it's all messed up. Realise that assigning a value to a variable is not the same as declaring it.

Switch $sHail
    Case "StaffAdd"
        Global $aControls[12] = ["","","","","","","","","",$aClean[$i][0],"",$aClean[$i][1]]
EndSwitch

[kor]

I'm not defining the initial size of the array. I'm saying that Array element 9 = the value from another arrays element $i 0

Then I say that array element 11 = a value from another arrays element $i 1

The $aControls array is a 1 dimensional array that is previously declared as

Global $aControls[40]

[Melba23]

kor,

When you use the Global/Local keyword in front of an array it means you are declaring the array for the first time - you then need to place any values to be put into the array within [ ]. So this

Global $aControls[9] = [$aClean[$i][0]], $aControls[11] = [$aClean[$i][1]]

destroys any previously declared arrays with that name (and the second destroys the first) and produces a single array like this:

Element         $aControls

[0]             $aClean[$i][1]
[1]             -
...
[10]            -

Which I am sure is not what you want.

If you only want to assign values to the particular elements of the previously declared $aControls array, then just lose the initial Global:

$aControls[9] = $aClean[$i][0]
$aControls[11] = $aClean[$i][1]

Then you will get the following array:

Element         $aControls

[0]            Existing value 
[1]            Existing value
...
[9]            $aClean[$i][0]
[10]           Existing value
[11]           $aClean[$i][1]
...
[39]           Existing value

All clear?

M23

Edited August 9, 2012 by Melba23
Typo

[czardas]

I'm not defining the initial size of the array. I'm saying that Array element 9 = the value from another arrays element $i 0

Then I say that array element 11 = a value from another arrays element $i 1

The $aControls array is a 1 dimensional array that is previously declared as

Global $aControls[40]

Ah but that's what you are trying to say. When you use syntax like Global $array[9] you declare that the array has 9 elements. Like Melba said, any subsequent declarations destroy the previous array and all it's contents.

Also, you will have to assign a value to each element on a separate line unless you organize the elements in a way that enables you to assign values using a loop. The code I posted declared and assigned values to two elements of a 12 element array in one hit, and I used 12 elements because that is the minimum number required to rewrite your code accurately. However you don't need to declare the array twice, as pointed out by Melba.

Edited August 9, 2012 by czardas

[kor]

$i = 1
Global $aClean[40], $aControls[40], $sHail
_SetBulkInputs($aClean, $i)

Func _SetBulkInputs(ByRef $aClean, $i)
    Switch $sHail
        Case "StaffAdd"
            $aControls[9] = $aClean[$i][0], $aControls[11] = $aClean[$i][1]
    EndSwitch
EndFunc

C:UsersuserDesktopodinddfdf.au3(9,34) : ERROR: syntax error

$aControls[9] = $aClean[$i][0],

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^

C:UsersuserDesktopodinddfdf.au3 - 1 error(s), 0 warning(s)

[czardas]

Hmm. you declared Global $aClean[40] as a one dimensional array. Next you reference it as if it was a two dimensional array $aClean[$i][0]. Also you need to assign values for $aControls[9] and $aControls[11] on separate lines.

$i = 1
Global $aClean[40][2], $aControls[40], $sHail
_SetBulkInputs($aClean, $i)

Func _SetBulkInputs(ByRef $aClean, $i)
    Switch $sHail
        Case "StaffAdd"
            $aControls[9] = $aClean[$i][0]
            $aControls[11] = $aClean[$i][1]
    EndSwitch
EndFunc

But this code won't do anything because there's not enough of it.

Edited August 9, 2012 by czardas

[kor]

Also you need to assign values for $aControls[9] and $aControls[11] on separate lines.

thats exactly my initial question in my first post. Why do I have to assign the values on separate lines when you can assign values to other variables on the same line as referenced in my samples from my first post, but you can't do it when the variables are arrays.

[BrewManNH]

Because when you use Global/Local then you're declaring a variable/array, you're not using it to assign a value to that variable, although you can do both at the same time.

$Array1 doesn't exist, "Global $Array1[9]" = Create this array called $Array1 and give it enough space for 9 entries. Now if you want to put something into $Array1[8], you need to do it either on a separate line, or in the declaration statement as shown in post 3.

$Array1 exists, "Global $Array1[9]" = Destroy previous array, and create a new one with space for 9 entries.

[czardas]

Thanks BrewmanNH.

kor have you read the wiki article about arrays? http://www.autoitscript.com/wiki/Arrays