url + string

[jimmy999]

hi , i have this script

#include
#include

$oIE = ObjCreate("Shell.Explorer.2")

$Gui = GUICreate("Test", 615, 370, 400, 100)
GUISetBkColor(0x3399FF)
$Browser = GUICtrlCreateObj($oIE, 7, 50, 600, 300)
$Url = GUICtrlCreateInput("http://www.google.ro/search?hl=ro&sclient=psy-ab&q=", 24, 8, 457, 21)
$Start = GUICtrlCreateButton("Start", 504, 8, 89, 25)
GUISetState()

While 1
$msg = GUIGetMsg()

Select
Case $msg = $GUI_EVENT_CLOSE
Exit
Case $msg = $Start
$oIE.navigate(GUICtrlRead($Url))
EndSelect

WEnd

i have a .txt file with line 1 = test 1 , line 2 = test 2 for example, and i whant to add after q= a line variable

for example :

$oIE.navigate(GUICtrlRead($Url+line 1))

sleep 10 sec

$oIE.navigate(GUICtrlRead($Url+ line 2))

sleep 10 sec

$oIE.navigate(GUICtrlRead($Url+ line 3))

etc.

how i cand do this?

[jdelaney]

I'm guessing you want the navigation after clicking Start, so inside that case, do a _FileReadToArray, and loop through to append the value to the end of the url.

[jimmy999]

yes after clicking Start , little help with _FileReadToArray how i can read the lines with _FileReadToArray ? tnx

this code is good

Local $aRecords
If Not _FileReadToArray("myfile.log", $aRecords) Then
MsgBox(4096, "Error", " Error reading log to Array error:" & @error)
Exit
EndIf
For $x = 1 To $aRecords[0]
MsgBox(0, 'Record:' & $x, $aRecords[$x])
Next

but : Case $msg = $Start

$oIE.navigate(GUICtrlRead($Url & $x, $aRecords[$x] ) ) not work

Edited August 21, 2012 by jimmy999

[jdelaney]

$oIE.navigate(GUICtrlRead($Url) & $aRecords[$x] )

[jimmy999]

$oIE.navigate(GUICtrlRead($Url) & $aRecords[$x] )

Array variable has incorrect number of subscripts or subscript dimension range exceeded

[jdelaney]

paste in your new loop...the above loop is good.

Or, try $x = 1 to UBound($aRecords)-1

Edited August 21, 2012 by jdelaney

[jimmy999]

paste in your new loop...the above loop is good.

Or, try $x = 1 to UBound($aRecords)-1

i solved it, tnx

[Andreik]

$oIE = ObjCreate("Shell.Explorer.2")

$Gui = GUICreate("Test", 615, 370, 400, 100)
GUISetBkColor(0x3399FF)
$Browser = GUICtrlCreateObj($oIE, 7, 50, 600, 300)
$Url = GUICtrlCreateInput("http://www.google.ro/search?hl=ro&sclient=psy-ab&q=", 24, 8, 457, 21)
$Start = GUICtrlCreateButton("Start", 504, 8, 89, 25)
GUISetState()

While 1
    Switch GUIGetMsg()
        Case -3
            Exit
        Case $Start
            $hFile = FileOpen("yourfile.txt",0)
            $Index = 1
            While True
                $Line = FileReadLine($hFile,$Index)
                If @error Then
                    ExitLoop
                Else
                    $Index += 1
                EndIf
                $oIE.navigate(GUICtrlRead($Url) & $Line)
                Sleep(10000) ; Sleep 10 s
            WEnd
            FileClose($hFile)
    EndSwitch
    Sleep(10)
WEnd

[guinness]

Andreik,

Please don't use 'Magic Numbers.' The GUIConstantsEx.au3 is there for a reason, please use it.

[Andreik]

There is just an example so it's justified.

[guinness]

There is just an example so it's justified.

That's not acceptable, so you're saying that the help file should exhibit bad coding practice too?

[Andreik]

What's the relation between my script and help file? I just remove some parts for my personal readability of OP code but all changes are logical (even you can say it's bad coding). After all I don't provide full code but the important part that OP ask for.

I took note about your demands and I hope it's not necessary more posts to justify my coding.

[guinness]

What's the relation between my script and help file? I just remove some parts for my personal readability of OP code but all changes are logical (even you can say it's bad coding). After all I don't provide full code but the important part that OP ask for.

I took note about your demands and I hope it's not necessary more posts to justify my coding.

The help file provides examples to those wanting to learn AutoIt just as you did. Why use -3 when you should be using $GUI_EVENT_CLOSE for better readability.

Edit: I'm not criticising your code per say, just your use of Magic Numbers which actually raises more questions and problems in the future.

Edited August 21, 2012 by guinness

[Andreik]

This wasn't the purpose of OP question so it's a weak argument. I'll not continue anymore this discussion about my good or bad coding style. I don't think any of these users would take my or your coding style, they just want get an answers in practical issues, so let's don't be too stylish and criticized others programming style as long the problem get an answer. Please just stop, we're offtopic.