Help With controlling loops

[baamr]

I made a small script witch reads a barcode and starts different tests

depending on barcode.

Is there a smoother way of looping it?

Local $bLoop = 1

While $bLoop = 1

Global $str = InputBox ( " Test ", "Please read your Barcode with scanner", "", "", 100 , 150 ,700 ,450 )

If @error = 1 Then

SplashTextOn ( "You clicked on Cancel or Exit", "Bye Bye......", 200 , 100 )

Sleep (1500)

SplashOff()

Exitloop

Else

Local $Code_len = StringLen ($str)

Local $Partno = $Code_len - 6

Local $Partnr = StringTrimRight ($str, $Partno)

ClipPut ($str)

If $Partnr = "342323" Then

SplashTextOn ( "Info", "Starting Test 1", 200 , 100 )

Sleep (1000)

SplashOff()

ShellExecute(@ProgramFilesDir & "\something\filename1")

$bLoop = 0 ;

ElseIf $Partnr = "544376" Then

SplashTextOn ( "Info", "Starting Test 2", 200 , 100 )

Sleep (1000)

SplashOff()

ShellExecute(@ProgramFilesDir & "\something\filename2")

$bLoop = 0 ;

ElseIf $Partnr = "895762" Then

SplashTextOn ( "Info", "Starting Test 3", 200 , 100 )

Sleep (1000)

SplashOff()

ShellExecute(@ProgramFilesDir & "\something\filename3")

$bLoop = 0 ;

ElseIf $Partnr = "603444" Then

SplashTextOn ( "Info", "Starting Test 4", 200 , 100 )

Sleep (1000)

SplashOff()

ShellExecute(@ProgramFilesDir & "\something\filename4")

$bLoop = 0 ;

ElseIf $Partnr = "319824" Then

SplashTextOn ( "Info", "Starting Test 5", 200 , 100 )

Sleep (1000)

SplashOff()

ShellExecute(@ProgramFilesDir & "\something\filename5")

$bLoop = 0 ;

ElseIf $Partnr = "324400" Then

SplashTextOn ( "Info", "Starting Test 6", 200 , 100 )

Sleep (1000)

SplashOff()

ShellExecute(@ProgramFilesDir & "\something\filename6")

$bLoop = 0 ;

ElseIf $Partnr = "306713" Then

SplashTextOn ( "Info", "Starting Test 7", 200 , 100 )

Sleep (1000)

SplashOff()

ShellExecute(@ProgramFilesDir & "\something\filename7")

$bLoop = 0 ;

Endif

EndIf

WEnd

[bogQ]

i don't see why do you use loop in this code at all

maybe you can tell us what is your definition of "smoother way of looping it"

if your definition is short code and easy to understand than this can help

While 1
    $str = InputBox(" Test ", "Please read your Barcode with scanner", "", "", 100, 150, 700, 450)
    If @error Then
        SplashTextOn("You clicked on Cancel or Exit", "Bye Bye......", 200, 100)
        Sleep(1500)
        SplashOff()
        Exit
    EndIf
    $Partnr = StringTrimRight($str, StringLen($str) - 6)
    ClipPut($str)
    Switch $Partnr
        Case "342323"
            somefunc(1)
        Case "544376"
            somefunc(2)
        Case "895762"
            somefunc(3)
        Case "603444"
            somefunc(4)
        Case "319824"
            somefunc(5)
        Case "324400"
            somefunc(6)
        Case "306713"
            somefunc(7)
    EndSwitch
WEnd
Func somefunc($data)
    SplashTextOn("Info", "Starting Test "&$data, 200, 100)
    Sleep(1000)
    SplashOff()
;~ ShellExecute(@ProgramFilesDir & "somethingfilename"&$data)
    Exit
EndFunc

[baamr]

i don't see why do you use loop in this code at all

maybe you can tell us what is your definition of "smoother way of looping it"

if your definition is short code and easy to understand than this can help

While 1
$str = InputBox(" Test ", "Please read your Barcode with scanner", "", "", 100, 150, 700, 450)
If @error Then
     SplashTextOn("You clicked on Cancel or Exit", "Bye Bye......", 200, 100)
     Sleep(1500)
     SplashOff()
     Exit
EndIf
$Partnr = StringTrimRight($str, StringLen($str) - 6)
ClipPut($str)
Switch $Partnr
     Case "342323"
         somefunc(1)
     Case "544376"
         somefunc(2)
     Case "895762"
         somefunc(3)
     Case "603444"
         somefunc(4)
     Case "319824"
         somefunc(5)
     Case "324400"
         somefunc(6)
     Case "306713"
         somefunc(7)
EndSwitch
WEnd
Func somefunc($data)
SplashTextOn("Info", "Starting Test "&$data, 200, 100)
Sleep(1000)
SplashOff()
;~ ShellExecute(@ProgramFilesDir & "somethingfilename"&$data)
Exit
EndFunc

Hi BogQ,

Thanks for Your reply.

I just used the Loop because it gave me a working code :-)

I`m a newbe to programming, generally speaking so i try to learn from

This excellent site.

Reason why i used a while Loop is because i wanted a simple Inputbox

for the barcode and it should dissapear after executing correct test.

What`s the difference between using switch/Case and IF/Else IF/Else ?

[Mechaflash]

What`s the difference between using switch/Case and IF/Else IF/Else ?

Easier to read and less code to write. When programming, you want to simplify as much as possible. Remember irrational equations in algebra?

[baamr]

Easier to read and less code to write. When programming, you want to simplify as much as possible. Remember irrational equations in algebra?

I Agree,absolutely less code. And also more easy when adding functions later.

Thanks Again....