Search Files

[MilesAhead]

Afa the zero length file problem, I don't see a check of @error after calling FileGetSize(). If the file is really zero bytes it returns zero. But it there's an error it will also return zero with @error set to 1. There's no way to distinguish which is which if you don't check @error.

[stealthmsgr]

J1, i missed responding to you. Thx, I removed these 2 references. _Myfilemod ($sFilePath)

Edited September 10, 2012 by stealthmsgr

[guinness]

Nice idea Spiff59, didn't think about the DIR command. Another one could've been 'forfiles', which I'm sure I have a function for in my snippet folder.

[JohnOne]

Well you are the one in charge of your code, add an error check if you wish.

But passing an empty variable to your function, it wont matter anyway.

[BrewManNH]

BTW, the line $sFilePath = $sPath1 & '' & $aFileList[$i] is wrong, you have _RecFileListToArray configured to return the filename with the full path included, you're actually adding the full path to the file name twice this way. The returned filename is going to look like this, C:DataC:Datatest.txt after you're run that line.

[guinness]

BTW, the line $sFilePath = $sPath1 & '' & $aFileList[$i] is wrong, you have _RecFileListToArray configured to return the filename with the full path included, you're actually adding the full path to the file name twice this way. The returned filename is going to look like this, C:DataC:Datatest.txt after you're run that line.

Ah, stupid me. Sorry. I forgot to edit that part.

[stealthmsgr]

I had planned on adding error checking during clean up. With the bulk done, at this point I'm just trying to get out of the weeds.

[stealthmsgr]

Will do, thanks for the path tip.

[guinness]

stealthmsgr,

See my previous code. I fixed the issue reported by BrewManNH (thanks for that by the way.)

[stealthmsgr]

guinness - Yes, I caught that and have incorporated it also.

MilesAhead - I see your point and I'll work on that.

[Spiff59]

My prior example was not very useful in this case as the /s (include subfolders) parameter was left off the DIR command.

Inserting "/s" caused the function to fail due to it's dependence on the embedded sort-by-filesize parameter "/O-S", that will only sort at the directory level, rather than globally. So, after a few tweaks, this is version 2. I don't expect the OP to adopt it, but am willing to bet it runs circles around any options using FileGetSize(). On this PC, the 4 executions in the sample script below return between 8800 and 28400 files and all run in between 3.1 and 3.5 seconds.

expandcollapse popup

#include <Array.au3>

Local $test[4][2] = [[">", 99999],["<", 100000],[">", -1],[">", 0]]

For $x = 0 to 3
    $timer = TimerInit()
    $array = _DOSRecFLTABySize(@WindowsDir, $test[$x][0], $test[$x][1])
    $timer = TimerDiff($timer) / 1000
    _ArrayDisplay($array, "Files " & $test[$x][0] & " " & $test[$x][1] & " in " & Round($timer, 2) & " seconds") ; for testing
Next

;===================================================================================================================================
Func _DOSRecFLTABySize($sDirectory, $g_or_l, $iSize)
    Local $sStdOut, $iIndex = 0
    $PID = Run(@ComSpec & ' /c DIR /s "' & $sDirectory & '" /A-D /-C', '', @SW_HIDE, 0x2) ; 0x2 = $STDOUT_CHILD
    While Not @error
        $sStdOut &= StdoutRead($PID)
    WEnd
    $aStdOut = StringSplit($sStdOut, @CRLF)
    For $x = 1 To $aStdOut[0] ; pack and format array
        If StringMid($aStdOut[$x], 3, 1) = "/" Then
            $aStdOut[$x] = StringStripWS($aStdOut[$x], 7)
            $aStdOut[$x] = StringTrimLeft($aStdOut[$x], StringInStr($aStdOut[$x], " ", 2, 3)) ; strip date/time
            If $g_or_l = ">" Then
                If $aStdOut[$x] <= $iSize Then ContinueLoop
            Else
                If $aStdOut[$x] >= $iSize Then ContinueLoop
            EndIf
            $iIndex += 1
;          $aStdOut[$iIndex] = $aStdOut[$x] ; leave filesize intact
            $aStdOut[$iIndex] = StringTrimLeft($aStdOut[$x], StringInStr($aStdOut[$x], " ", 2, 1)) ; strip filesize
        EndIf
    Next
    $aStdOut[0] = $iIndex
    ReDim $aStdOut[$iIndex + 1]
    Return $aStdOut
EndFunc

[stealthmsgr]

Sanity check

Guys, as you know I'm working on a simple(?!?!) file size verification component of my project.

This is a new hunk of code that I was playing with to do this.

; Shows the filenames of all files in the current directory
Local $search = FileFindFirstFile("C:Data*.txt")
Global $compare, $size, $zerosize = 0, $name
; Check if the search was successful
If $search = -1 Then
MsgBox(0, "Error", "No files/directories matched the search pattern")
Exit
EndIf

While 1
Global $file = FileFindNextFile($search)
If @error Then ExitLoop
_FileCompare ($compare)

MsgBox(4096, "File:", $file)
WEnd

; Close the search handle
FileClose($search)

Func _FileCompare ($compare)
Local $size = FileGetSize($file)
If $size = $zerosize Then
$name = FileRead($file, -1)
MsgBox(0, "Info", "File Size: " & $file)
EndIf
Exit
EndFunc

Guinness, this is a somewhat variation of yours and JohnOne's.

Something I was playing with. Something screwy here though.

I seems instead of testing the actual size of the file (I was going for) it seems to test the name size, i.e. 1111.txt is smaller than 11112.txt

I didn't catch it a first because the files being generated are random and about 15-20 characters long.

Can you look at it and point out why I'm not actually testing the actual file size (say in 1K bytes, etc.). I have a suspicion but I need another quick look.

Maddening, Yikes, you wouldn't think it would be this bloody hard~!?

[BrewManNH]

Shouldn't this => MsgBox(0, "Info", "File Size: " & $file) be like this => MsgBox(0, "Info", "File Size: " & $size)?

[stealthmsgr]

Ummm....that would mean I would actually check the size if the file!?!?!

Duh?!? Wow I had a Homer Simpson moment.

Thanks BrewMan.

Maybe I could use one of those Brews right now.

Ok, maybe later.

Cheers!

[stealthmsgr]

While that was a problem, it's still not working.

Still missing something.

Just to clarify, I was using the Msgbox in this example to verify what was/was not working.

I am actually using a FileMove to copy the Zero content file to another folder.

[BrewManNH]

Try this code, the file compare function now returns TRUE if the file isn't zero bytes in size. The consolewrites are displaying the return from the function.

; Shows the filenames of all files in the current directory
Local $search = FileFindFirstFile("C:Data*.txt")
Global $compare, $size, $zerosize = 0, $name
; Check if the search was successful
If $search = -1 Then
     MsgBox(0, "Error", "No files/directories matched the search pattern")
     Exit
EndIf
While 1
     Global $file = FileFindNextFile($search)
     If @error Then ExitLoop
     $Return = _FileCompare("C:Data" & $file) ; you need the original path in front of the file name
     ConsoleWrite('@@ Debug(' & @ScriptLineNumber & ') : $Return = ' & $Return & @CRLF & '>Error code: ' & @error & @CRLF) ;### Debug Console
;~    MsgBox(4096, "File:", $file)
WEnd
; Close the search handle
FileClose($search)
Func _FileCompare($compare)
     Local $size = FileGetSize($compare)
     ; NOTE: Returns true if the file is NOT zero bytes, change to: Return Not $size <> $zerosize to return a true if file IS zero bytes
     Return $size <> $zerosize
EndFunc   ;==>_FileCompare

[stealthmsgr]

Wow. Thanks BrewMan, really I missed that one.

Ok, I going to ask a really dumb one here, but where would I position the FileMove, then?

[BrewManNH]

Here's another version that also includes the filemove. I've also included an alternate version that doesn't use the function _FileCompare, your choice.

expandcollapse popup

; Shows the filenames of all files in the current directory
$Path = "C:Data"
Local $search = FileFindFirstFile($Path & "*.txt")
Global $compare, $size, $zerosize = 0, $name
; Check if the search was successful
If $search = -1 Then
     MsgBox(0, "Error", "No files/directories matched the search pattern")
     Exit
EndIf

While 1
     Global $file = FileFindNextFile($search)
     If @error Then ExitLoop
     $file = $Path & $file
     If Not _FileCompare($file) Then ; if the file is zero bytes, this returns False, so it moves that file
          ConsoleWrite('@@ Debug(' & @ScriptLineNumber & ') : $file = ' & $file & @crlf & '>Error code: ' & @error & @crlf) ;### Debug Console
;~           FileMove($file, "<file move destination>")
     EndIf
WEnd
#cs
; Alternate version below
While 1
     Global $file = FileFindNextFile($search)
     If @error Then ExitLoop
     $file = $Path & $file
     If Not Filegetsize($file) <> $zerosize Then ; if the file is zero bytes, move that file
          ConsoleWrite('@@ Debug(' & @ScriptLineNumber & ') : $file = ' & $file & @crlf & '>Error code: ' & @error & @crlf) ;### Debug Console
;~           FileMove($file, "<file move destination>")
     EndIf
WEnd
#ce
; Close the search handle
FileClose($search)
Func _FileCompare($compare)
     Local $size = FileGetSize($compare)
     ; NOTE: Returns true if the file is NOT zero bytes, change to: Return Not $size <> $zerosize to return a true if file IS zero bytes
     Return $size <> $zerosize
EndFunc   ;==>_FileCompare

[stealthmsgr]

Works like a champ BrewMan!!

I have learned a great deal from something that I thought was going to be quick and easy!

I now have to integrate this into the rest of my code and clean it all up.

Thank you very much for the lesson.

Hopefully I can be of assistance and/or pay some of this forward.