Background process not closing

[Showtime2kX]

Hi,

I have several AutoIT scripts that run installers for me (CCleaner, Malwarebytes, etc.). If I stop and close the installer before it finishes, it closes, but the AutoIT script continues to run in the background.

I don't want to add in a timeout on my WinWaitActive commands because, to deal with computers that might be slow and are lagging, I didn't want that to accidentally time out when I'm running these on PCs that I'm repairing.

Is there some other way besides using a timeout, to make the background process of the script close when I close the installer that it's running?

Thanks in advance,

Matt

[water]

Without seeing the code it's impossible to tell what you are talking about and where the problem is.

[PlayHD]

ProcessExists ?

Edited December 27, 2012 by PlayHD

[water]

If you need to run an installer and automate the install process by using AutoIt I wouldn't allow the user to cancel the install process.

Use function BlockInput to block all user input by keyboard and mouse.

Or - the way I prefer - use the command line switches of the software to do a silent install.

The switches for CCleaner can be found here.

[Showtime2kX]

Here is an example from my Malwarebytes installer:

expandcollapse popup

$MalwareBytes = "\Applications\Installers\Security Software\Anti-Malware\Malwarebytes\Newer Versions\malwarebytes.exe"

Run($MalwareBytes)
Sleep(2000)
WinWaitActive("Select Setup Language", "English")
Sleep(2000)
WinActivate("Select Setup Language", "English")
Sleep(2000)
ProcessWait("malwarebytes.exe")
ControlClick("Select Setup Language", "OK", "TNewButton1")
Sleep(2000)
WinWaitActive("Setup - Malwarebytes Anti-Malware", "&Next >")
ControlClick("Setup - Malwarebytes Anti-Malware", "&Next >", "TNewButton1")
Sleep(2000)
WinWaitActive("Setup - Malwarebytes Anti-Malware", "License Agreement")
ControlClick("Setup - Malwarebytes Anti-Malware", "I &accept the agreement", "TNewRadioButton1")
Sleep(2000)
ControlClick("Setup - Malwarebytes Anti-Malware", "&Next >", "TNewButton2")
Sleep(2000)
WinWaitActive("Setup - Malwarebytes Anti-Malware", "Please read the following important information before continuing.")
ControlClick("Setup - Malwarebytes Anti-Malware", "&Next >", "TNewButton2")
Sleep(2000)
WinWaitActive("Setup - Malwarebytes Anti-Malware", "Select Destination Location")
ControlClick("Setup - Malwarebytes Anti-Malware", "&Next >", "TNewButton3")
Sleep(2000)
WinWaitActive("Setup - Malwarebytes Anti-Malware", "Select Start Menu Folder")
ControlClick("Setup - Malwarebytes Anti-Malware", "&Next >", "TNewButton4")
Sleep(2000)
WinWaitActive("Setup - Malwarebytes Anti-Malware", "Select Additional Tasks")
ControlClick("Setup - Malwarebytes Anti-Malware", "&Next >", "TNewButton4")
Sleep(2000)
WinWaitActive("Setup - Malwarebytes Anti-Malware", "Ready to Install")
ControlClick("Setup - Malwarebytes Anti-Malware", "&Install", "TNewButton4")
Sleep(2000)
WinWaitActive("Setup - Malwarebytes Anti-Malware", "Click Finish to exit Setup.")
Send("{TAB}")
Send("{SPACE}")
Send("{TAB}")
Send("{TAB}")
Send("{SPACE}")
ControlClick("Setup - Malwarebytes Anti-Malware", "&Finish", "TNewButton4")
Sleep(2000)
ProcessClose("malwarebytes.exe")
Sleep(3000)

Exit

And it isn't "to stop a user" from cancelling the install. It is in case I accidentally ran it and needed to stop the install before it finishes.

[water]

The return value of Run is the PID of the process that was launched.

So you could always check if the process you startet still exists:

If Not ProcessExists($PID) Then Exit

[Showtime2kX]

Thanks.

Where within the code should I place that If statement?

[water]

Guess!

[water]

.. Before every statement that would "hang" your script. That means before every WinWait* function or every other function that will wait forever when the install process is no longer available.

[Showtime2kX]

Certainly should add a bunch of extra lines to the code. I imagine there is no "cleaner" way.

Thanks.

[water]

There is: AdLibregister. Will post an example later.

[water]

This should work too:

$PID = Run(".....")
AdlibRegister("_CheckProcess", 250)

; Your code goes here

Func _CheckProcess()
    If Not ProcessExists($PID) Then exit
EndFunc

Edited December 27, 2012 by water

[JLogan3o13]

I imagine there is no "cleaner" way.

There is a much "cleaner" way, use the silent switches as Water suggested in Post 4, and get your script down to this:

ShellExecuteWait("CCleaner.exe", "/S")

[Showtime2kX]

This should work too:

$PID = Run(".....")
AdlibRegister("_CheckProcess", 250)

; Your code goes here

Func _CheckProcess()
If Not ProcessExists($PID) Then exit
EndFunc

Awesome. This works great!

Thanks a bunch,

Matt

Edited December 28, 2012 by Showtime2kX

[water]

Glad to be of service

[wangf]

Mark, it is helpful

[guinness]

Mark, it is helpful

Please refrain from doing this. If you want to 'mark' the post for later use e.g. when you get home, then use another method please instead of unnecessarily bumping.