FileOpen and @error

[hmobron]

Hello,

i have a strange problem.

When i open a bin file, created by my self and i re read it whit FileReadLine the @error is trowing a 1 in stead off -1.

_FileCountLines Shows 2 line's and that is correct.

FileGetPos Starts at 0, then to 36 and then to 104 and it stays there looping at the line If @error = -1 Then ExitLoop

I open the file whit 0+16 and contains two lines whit EncryptData write whit mode 2+16

I can change @error = -1 to @error = 1 but i don't think that's the correct way.

Any help welcome.

[FireFox]

Hi,

Can you provide a sample of your code ?

I can change @error = -1 to @error = 1 but i don't think that's the correct way.

Erm. This macro is only a "flag" that can be returned by functions to tell if this one succeeded or not. Editing this one will maybe make you feel better but it's not going to change something at the end.

Br, FireFox.

[hmobron]

Hello, this is the part thats write the data.

Func Safe()
_Crypt_Startup() ;


If GUICtrlRead ( $WWisTrue) = $GUI_CHECKED Then
$SetpassWord = "True"
Else
$SetpassWord = "False"
EndIf


Local $file = FileOpen(@ScriptDir & "\manager.cfg",2+16)

;FileWriteLine($file, $Data)
FileWriteLine($file, _Crypt_EncryptData("Password=" &GUICtrlRead ( $WW) , $Password, $CALG_AES_256 )& @CRLF)
FileWriteLine($file, _Crypt_EncryptData("PasswordTrue=" &$SetpassWord, $Password, $CALG_AES_256 )& @CRLF)

FileClose($file)



_Crypt_Shutdown()


Exit


EndFunc

This part is reading the data. Its a bit messy by testing and seeking the error.

expandcollapse popup

Func LoadConfig()
_Crypt_Startup()

MsgBox(0,"",_FileCountLines(@ScriptDir & "\manager.cfg"))

Local $file = FileOpen(@ScriptDir & "\manager.cfg", 16+0)


If $file = -1 Then
MsgBox(0, "Error", "Unable to open file.")
Exit
EndIf


While 1

MsgBox(0, "", "Position: " & FileGetPos($file) )

Local $line = FileReadLine($file)
MsgBox(0, "",$line)

$tmp = StringSplit(BinaryToString(_Crypt_DecryptData( $line, $Password, $CALG_AES_256)), "=")
local $a
$a = $a +1
if $a = 10 then Exit
; _ArrayDisplay($tmp, "$avArray set manually 1D")
;$Data[1] = $tmp[2]
If @error Then MsgBox(0,"error",@error)
If @error = -1 Then ExitLoop
MsgBox(0, "",BinaryToString(_Crypt_DecryptData( $line, $Password, $CALG_AES_256)))
WEnd
_ArrayDisplay($Data, "$avArray set manually 1D")

FileClose($file)

_Crypt_Shutdown()



EndFunc

[guinness]

@error can be changed by using SetError, but it's set if the previous function fails. Also why not just read the whole contents of the file? Instead of line by line.

[hmobron]

Hoi guinness,

I tried that, but the problem stay's. I want to now why the error is 1 instead off -1. When i save and direct open there is no problem at all.

BTW The data is correct at reading.

Edited January 22, 2013 by hmobron

[FireFox]

I don't know what's the default line if the parameter is not set for the function FileReadLine, but seems like it's the last line.

So you must set it to 1 for your example :

$line = FileReadLine($file, 1)

Code cleaned :

...


Local $line = FileReadLine($file, 1)

Local $atmp = StringSplit(BinaryToString(_Crypt_DecryptData($line, $Password, $CALG_AES_256)), "=")

_ArrayDisplay($atmp)

FileClose($file)
...

Br, FireFox.

[jchd]

The basic problem is that your logic is faulty.

Your .cfg file content is:

Password=<binary data block>

PasswordTrue=<second binary data block>

The problem is that you can't predict which bytes are in the two binary blocks (or you could break AES). There are good chances that what FIleReadLine considers a line break might be in one or both blocks. Same for your splitting by '=' as this character may well be in one or both blocks.

Mixing text and random binary is almost always a bad idea.

[FireFox]

@jchd

That's not right as he crypts the whole line.

[jchd]

Yes indeed, that just makes it worse!

[FireFox]

Yes indeed, that just makes it worse!

Yup.

@hmobron

My suggestion would to use the IniCrypt UDF or something similar in order to easily work on the data instead of reading each line, decode it, and know if it's the key you want to read.

[hmobron]

Hello Guys,

thank for the input about the crypting, but the main problem still exist.

Change the line to Local $line = FileReadLine($file,1) makes the pointer hang to position 36 off the file because the error = 1

Greeting

[jchd]

Once again, there is no meaning of a "line" in a binary file. THAT is the main problem.