Loop not looping ?

[MattX]

This works fine when the IP address is valid, however when it is not, it does loop - I can see it in the system tray but when I make the IP address live again the MsgBox won't pop up.

Can someone point me in the right direction so it does or let me know what I have done wrong ?

$IP = Ping("10.20.32.166",3000)
While 1
If $IP Then
MsgBox(64,"It's Alive","It's Alive")
Exit
If @error Then ContinueLoop
EndIf
WEnd

Edited January 23, 2013 by MattX

[Mat]

Let me indent your code:

$IP = Ping("10.20.32.166",3000)
While 1
    If $IP Then
        MsgBox(64,"It's Alive","It's Alive")
        Exit
        If @error Then ContinueLoop
    EndIf
WEnd

Now try and imagine what the code is doing line by line. There is one major logic flaw, and one line that serves no purpose.

Edited January 23, 2013 by Mat

[MattX]

I'm looking but as a thicko I need a bigger clue - also tried this:

$IP = Ping("10.20.32.166",3000)
while $IP = 0
    Sleep(100)
WEnd
MsgBox(64,"It's Alive","It's Alive")

But the same - do I have a logic flaw in that too ?

Let me indent your code:

$IP = Ping("10.20.32.166",3000)
While 1
If $IP Then
MsgBox(64,"It's Alive","It's Alive")
Exit
If @error Then ContinueLoop
EndIf
WEnd

Now try and imagine what the code is doing line by line. There is one major logic flaw, and one line that serves no purpose.

[water]

You have to put the Ping INSIDE the loop!

[MattX]

You have to put the Ping INSIDE the loop!

I thought that is what my $IP = Ping("10.20.32.166",3000) is doing ?

[water]

But it does it only ONCE. So the loop always queries the same value and hence can never be left.

[MattX]

But it does it only ONCE. So the loop always queries the same value and hence can never be left.

So how do I get it to loop and ping the IP with the same value again ? Do I need to re-set the variable and then set it again ?

[water]

Move the Ping line after the While.

[MattX]

Move the Ping line after the While.

Thanks - that has does it - still need to get my head around the fact that this now works with the ping inside the loop - maybe I've done too much stuff in setting my variables right at the start.

[water]

And now to Mats second question:

What is

If @error Then ContinueLoop

for?

[MattX]

And now to Mats second question:

What is

If @error Then ContinueLoop

for?

I can answer that !! But the answer will be wrong - because it was in the example in the help file ? I now wait to be shot down in flames.....

[water]

Then please answer. No one is going to kill you

[guinness]

I can answer that !! But the answer will be wrong - because it was in the example in the help file ? I now wait to be shot down in flames.....

Also what example please as I will fix that right away.

[MattX]

From Help - [ and yes I know it states if @error = 0 and mine was a If @error Then ContinueLoop statement ] - again I wait to get shot down in flames....

Problem I have is that I don't script as often a I should and when I go back to it I've forgotten what I learnt last time around.

$var = Ping("www.AutoItScript.com",250)

If $var Then; also possible: If @error = 0 Then ...

Msgbox(0,"Status","Online, roundtrip was:" & $var)

Else

Msgbox(0,"Status","An error occured with number: " & @error)

EndIf

[water]

That's pretty valid. According to the help file Ping "Returns 0 if host is not pingable or other network errors occurred and sets @error."

So you just took the example and didn't correctly implement it in your script.

BTW: Sorry, no flames!

[TheSaint]

And now to Mats second question:

What is

If @error Then ContinueLoop

for?

While the answer for that is indeed important, I think he needs to first consider what happens to a script when it gets to an Exit.

[guinness]

From Help

I understood that much. So the code in the first post wasn't from the help file, great!

Anyway, I will help you, but please please look at the help file and see where you were going wrong.

#include <Constants.au3>

Local $iRoundTrip = 0 ; Create a variable to store the Ping return value.
While 1
    $iRoundTrip = Ping('74.125.224.72') ; Ping a Google IP address.
    If $iRoundTrip Then ; If greater than zero then display the MsgBox.
        MsgBox($MB_SYSTEMMODAL, '', 'Ping time: ' & $iRoundTrip) ; Display round trip time in ms.
        ExitLoop ; Exit the while loop. I replaced the Exit as this will exit the script not the loop.
    EndIf
    ; This will naturally go back to the beginning and start the process again.
WEnd

Edit: The conversation was getting a little long as MattX clearly couldn't see a fault in the first post.

Edited January 23, 2013 by guinness

[guinness]

From the AutoIt beta help file.

#include <Constants.au3>

Example()

Func Example()
    ; Ping the AutoIt website with a timeout of 250ms.
    Local $iPing = Ping("autoitscript.com", 250)

    If $iPing Then ; If a value greater than 0 was returned then display the following message.
        MsgBox($MB_SYSTEMMODAL, "", "The roundtrip-time took: " & $iPing & "ms.")
    Else
        MsgBox($MB_SYSTEMMODAL, "", "An error occurred with @error value of: " & @error)
    EndIf
EndFunc   ;==>Example

[Underdogger]

$IP = Ping("10.20.32.166")
;While 1
If Not $IP = 0 Then
MsgBox(64,"It's Alive","It's Alive")
;Exit
;If @error Then ContinueLoop
Else
MsgBox(64,"","Dead")
EndIf
;WEnd

[guinness]

You're welcome MattX!