good way to determine a filecopy is complete?

[gcue]

hello world!

i have seen other examples in the forum where people have come across filecopy's not completing so the next steps fail

i am also coming across this issue with this (doesnt always happen but the file ends up deleting - guess because its in the midst of being replaced then the shellexecute command is called so it interrupts the copy? - not sure)

FileCopy($remote_file, $local_file, 1)

ShellExecute($local_file)

im curious how other people might be addressing this issue - was thinking of approaching it this way...

$copy = FileCopy($remote_file, $local_file, 1)

While 1
     If $copy Then ExitLoop
WEnd

ShellExecute($local_file)

thanks!

Edited January 24, 2013 by gcue

[BrewManNH]

You have no exit strategy for failure, if the copy fails, it's stuck in the While loop forever.

[gcue]

wont it return 0 if it fails?

maybe im misinterpreting what "if $copy then" means

i thought it meant if $copy has value then

[BrewManNH]

"If $Copy Then" means do whatever is after Then only if $Copy is not zero, it's a boolean check of the variable and you're checking it to be True.

[gcue]

so should i do if $copy = 0 or $copy = 1 then.... ?

[BrewManNH]

FileCopy pauses the script until it is done, the While loop is redundant. You should check to see if it was successful rather than pausing the script and doing the same thing. If it's successful, run the ShellExecute line, if it's not you will need to figure out why it failed.

[jdelaney]

The next line after FileCopy will not execute until it is succesfull, or fails. It seems that you are assuming that the boolean gets set asynchronously, which is not the case. Simple error handling will fix your script

If FileCopy($remote_file, $local_file, 1) Then
ShellExecute($local_file)
Else
MsgBox ( 1,1,"FileCopy failed")
EndIf

Edited January 24, 2013 by jdelaney

[gcue]

im not sure if the copy fails bc the shellexecute happens before the copy completes - its not a rights issue for sure bc it works sometimes. source is on a network file share so im thinking its taking extra long to complete the copy

[BrewManNH]

Filecopy pauses the script until it finishes, either successfully or not. If the ShellExecute is running, then FileCopy has finished, and probably failed. You need to read the return value from the FileCopy to see if it's 0 (fail) or 1 (success), and deal with it from there. Unfortunately FileCopy doesn't tell you why it failed, just that it did.

[gcue]

thanks for the help =)

[kylomas]

gcue,

You will be better off using Yashied's Copy UDF

kylomas