Problem with For loop in deleting registry key

[lolipop]

Hi members,

I'm trying to use a FOR loop to delete some registry key base on certain condition but somehow it's not working correctly.

Basically, inside registry key test1 there's a couple of other keys nested. What I want is to delete all the other keys and leave the keys I want intact. The code below seems to read and delete every alternate keys instead. TIA.

Below is an example of the code.

For $count = 1 To 1000
$var = RegEnumKey("HKEY_CURRENT_USER\test\test1\", $count)
If @error <> 0 Then ExitLoop
If $var <> "S-1-1-1-1" Or "S-1-1-1-2" Or "S-1-1-1-3" Then
$var1 = ("HKEY_CURRENT_USER\test\test1\" & $var)
RegDelete($var1)
EndIf
Next

[BrewManNH]

This line is wrong.

If $var <> "S-1-1-1-1" Or "S-1-1-1-2" Or "S-1-1-1-3" Then

It needs to be written like this.

If $var <> "S-1-1-1-1" Or $var <> "S-1-1-1-2" Or $var <> "S-1-1-1-3" Then

You have to test the comparison against something every time, you can't specify it once like you were doing.

[lolipop]

Hi BrewMan,

I have tried that as well but the code doesn't execute correctly as well. It doesn't seems to be checking the condition properly. I try changing the code as per your advise, now it delete the registry key "S-1-1-1-2" as well. The code seems to be deleting in the alternate pattern.

Read key 1

Read key 2

Delete key 2

Read key 3

Read key 4

Delete key 4

Read key 5

Read key 6

Delete key 6

etc......

[lolipop]

Hi guys,

Thanks. I have resolved the problem. Please close the thread. Thank you.

[JohnOne]

Hi guys,

Thanks. I have resolved the problem. Please close the thread. Thank you.

Just for your information:

Threads such as this are not usually closed on demand, remember, you might have started the thread but it does not belong to you.

Also, it customary, to post solutions to problems you have asked for help with, even if you solve it yourself, as other people read this too.

[lolipop]

Well, I'm not gd with explaination. Basically the for loop is giving the wrong registry key instance everytime I delete 1 of the key so I nested the for loop within a while loop and everytime I delete 1 registry key, I restart the for loop process again. Perhaps the amended code below can self explain better.

$counter = 1
While $counter
   For $count = 1 To 100
   $list = RegEnumKey("HKEY_CURRENT_USER\TEST\TEST1\List\", $count)
   If @error <> 0 Then
   $counter = 0
   ExitLoop
   EndIf
   If $list = "S-1-5-18" Then
   ElseIf $list = "S-1-5-19" Then
   ElseIf $list = "S-1-5-20" Then
   Else
   RegDelete("HKEY_CURRENT_USER\TEST\TEST1\List\" & $list )
   ExitLoop
   EndIf
   Next
WEnd

There's one thing I still can't figure out and that's the OR operators. Can't seems to get that to work properly. So instead I use If and elseif. Code not optimized but it get the job done.

[BrewManNH]

You should probably loop through the registry keys in reverse if you're deleting them. As soon as you delete one, the count is wrong.

[lolipop]

You should probably loop through the registry keys in reverse if you're deleting them. As soon as you delete one, the count is wrong.

How do you loop in reverse?

[BrewManNH]

Here's one way, using two loops, the first one gets the count of the keys, the second does the deleting.

; this loop finds out how many subkeys there are
For $i = 1 To 1000
    $var = RegEnumKey("HKEY_CURRENT_USER\test\test1\", $i)
    If @error <> 0 Then
        $Count = $i - 1
        ExitLoop
    EndIf
Next
; This loops through the keys in reverse
For $i = $Count To 1 Step -1
    If $var <> "S-1-1-1-1" Or $var <> "S-1-1-1-2" Or $var <> "S-1-1-1-3" Then
        $var1 = ("HKEY_CURRENT_USER\test\test1\" & $var)
        ConsoleWrite($var1 & @crlf)
    EndIf
Next

I changed the RegDelete to a consolewrite so you don't accidently delete anything before getting it to work right.

[AHRIMANSEFID]

Hi Plz Help For Delete Error

dele--1.au3(6,120) : ERROR: RegDelete() [built-in] called with wrong number of args.

RegDelete('HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Run','test.exe','REG_SZ',@WindowsDir & "\test.exe")
RegDelete('HKEY_CURRENT_USER\Software\Microsoft\Windows NT\CurrentVersion\AppCompatFlags\Layers','C:\Windows\test.exe','REG_SZ','~ RUNASADMIN')

[Melba23]

AHRIMANSEFID,

And how many arguments does the Help file tell you that RegDelete should have?

M23

[AHRIMANSEFID]

I read the document you had mentioned but still I have the same problem. Just try the code below:

RegDelete('HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Run','test.exe','REG_SZ',@WindowsDir & "\test.exe")
RegDelete('HKEY_CURRENT_USER\Software\Microsoft\Windows NT\CurrentVersion\AppCompatFlags\Layers','C:\Windows\test.exe','REG_SZ','~ RUNASADMIN')

when I use and trying these codes I am getting this error:

dele--1.au3(6,120) : ERROR: RegDelete() [built-in]

now can you helping me without getting angry! I appreciate any help suggestion or solution.

OR

RegDelete('HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Run','test.exe','REG_SZ','C:\Windows\test.exe')
RegDelete('HKEY_CURRENT_USER\Software\Microsoft\Windows NT\CurrentVersion\AppCompatFlags\Layers','C:\Windows\test.exe','REG_SZ','~ RUNASADMIN')

RegDelete('HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run','test.exe','REG_SZ','C:\Windows\test.exe')

Edited March 16, 2013 by AHRIMANSEFID

[Melba23]

AHRIMANSEFID,

can you helping me without getting angry!

There was no anger expressed in my previous post - so why suggest that there was?

I read the document you had mentioned

And so what is the answer to the question I asked? How many arguments does RegDelete take?

Once you have that answer then the solution to your problem becomes obvious.

M23

[AHRIMANSEFID]

Ok.

You Fix One Line Me.

[Melba23]

AHRIMANSEFID,

No - you answer the question I asked and then you can then fix all the lines yourself.

So, for the third time, how many arguments does the Help file say that you need for RegDelete?

M23

[AHRIMANSEFID]

#RequireAdmin
#Region ;**** Directives created by AutoIt3Wrapper_GUI ****
#AutoIt3Wrapper_Version=Beta
#AutoIt3Wrapper_Compile_Both=y
#EndRegion ;**** Directives created by AutoIt3Wrapper_GUI ****
RegDelete('HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Run','Test.exe','REG_SZ','C:\Windows\Test.exe')
RegDelete('HKEY_CURRENT_USER\Software\Microsoft\Windows NT\CurrentVersion\AppCompatFlags\Layers','C:\Windows\Test.exe','REG_SZ','~ RUNASADMIN')

RegDelete('HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run','Test.exe','REG_SZ','C:\Windows\Test.exe')
FileDelete(@WindowsDir & "\Test.exe")

[AHRIMANSEFID]

You Help Me For Fix Line Error.

Thanks A lot.

Me Read Page And Help Autoit.

Not Found Help.

You Help Me.

[JohnOne]

RegDelete('HKEY_CURRENT_USERSoftwareMicrosoftWindowsCurrentVersionRun','Test.exe','REG_SZ','C:WindowsTest.exe')

There are 4 arguments there. RegDelete does not take 4 arguments, as shown by M23.

[Melba23]

AHRIMANSEFID,

Not Found Help

And to what does the link I posted lead you if not the Help file page for RegDelete?

I am out of here - even my patience has been exhausted.

M23