Resolving hostname error

[Queener]

I used the example by UEZ 2011 to resolve hostname using IP. It works great, but I just notice that if it's not a computer; I get the error:

Line 65 (File Location):
 
$colItems = $objWMIService.ExecQuery("SELECT SystemName FROM Win32_NetworkAdapter WHERE NetConnectionStatus=2", "WQL", 0x30)
 
Error: Missing right bracket ')' in expression.

 

I don't think I missed a bracket.

Here's the script:

Func WMI_GetHostName($host) ;Formula to resolve hostname;
    Local $HostNameWMI, $colItems, $colItem, $ping
    $ping = Ping($host)
    If $ping Then
        $objWMIService = ObjGet("winmgmts:{impersonationLevel = impersonate}!\\" & $host & "\root\cimv2")
        $colItems = $objWMIService.ExecQuery("SELECT SystemName FROM Win32_NetworkAdapter WHERE NetConnectionStatus=2", "WQL", 0x30)
        If IsObj($colItems) Then
            For $objItem In $colItems
                If $objItem.SystemName = "" Then Return SetError(3, 0, "")
                Return $objItem.SystemName
            Next
            Return SetError(0, 0, $HostNameWMI)
        Else
            Return SetError(2, 0, "")
        EndIf
    Else
        Return SetError(1, 0, "")
    EndIf
EndFunc


Func ObjErrorHandler() ;Error handling resolving hostname;
    ConsoleWrite(   "A COM Error has occured!" & @CRLF  & @CRLF & _
                                "err.description is: "    & @TAB & $oErrorHandler.description    & @CRLF & _
                                "err.windescription:"     & @TAB & $oErrorHandler & @CRLF & _
                                "err.number is: "         & @TAB & Hex($oErrorHandler.number, 8)  & @CRLF & _
                                "err.lastdllerror is: "   & @TAB & $oErrorHandler.lastdllerror   & @CRLF & _
                                "err.scriptline is: "     & @TAB & $oErrorHandler.scriptline     & @CRLF & _
                                "err.source is: "         & @TAB & $oErrorHandler.source         & @CRLF & _
                                "err.helpfile is: "       & @TAB & $oErrorHandler.helpfile       & @CRLF & _
                                "err.helpcontext is: "    & @TAB & $oErrorHandler.helpcontext & @CRLF _
                            )
EndFunc

 

So if anyone knows a way to have it - if not pc, msgbox shows "Not a PC"

[spudw2k]

That's an odd error...I think an IsObj against the objWMIService right before the WMI query should alleviate that; but that's not really a guarantee that the IP isn't a PC. For example it could be a linux device or even a windows PC you don't have privileges to.

edit: You also have a declared but unused variable: $HostNameWMI
Not an issue, just an observation

Edited May 14, 2013 by spudw2k

[guinness]

What's wrong with TCPNameToIP?

[spudw2k]

I think that is going backwards (if I'm understanding the OPs intent).  He wants to go from IP to Hostname.

 

[guinness]

Ah, sorry. What's wrong with _TCPIpToName?

[Queener]

Ah, sorry. What's wrong with _TCPIpToName?

Have not used TCPIPTONAME. So far this is working the way I wanted; just an issue with the error I'm getting if it's not a computer. For example; my router is 192.168.1.1; if I type that in; it's gonna give me that error I mention. Unless you can write a quick simple that best fit my needs. I take a look at TCPipToName just now, it's quite confusing, but I'll look forward to challenge myself.

[guinness]

Show me what you did? Did you place TCPStartup at the start and TCPShutdown at the end?

[UEZ]

Try this:

Func WMI_GetHostName($host) ;Formula to resolve hostname;
    Local $HostNameWMI, $colItems, $colItem, $ping
    $ping = Ping($host)
    If $ping Then
        $objWMIService = ObjGet("winmgmts:{impersonationLevel = impersonate}!\\" & $host & "\root\cimv2")
        If @error Then Return SetError(3, 0, "Not a PC")
        $colItems = $objWMIService.ExecQuery("SELECT SystemName FROM Win32_NetworkAdapter WHERE NetConnectionStatus=2", "WQL", 0x30)
        If IsObj($colItems) Then
            For $objItem In $colItems
                If $objItem.SystemName = "" Then Return SetError(3, 0, "")
                Return $objItem.SystemName
            Next
            Return $HostNameWMI
        Else
            Return SetError(3, 0, "")
        EndIf
    Else
        Return SetError(1, 0, "")
    EndIf
EndFunc

The advantage of this method is the independence from DNS.

 

Br,

UEZ

[guinness]

Be aware that the Win32_NetworkAdapter class is deprecated.

Edited May 14, 2013 by guinness

[Queener]

thanks. Thats what I'm looking for. I do not intent to do multiple resolving.

[Queener]

I find something very funny about this code.

If GUICtrlRead($CheckName) = "" Then
MsgBox(0, "Error", "You must input either the hostname or ip address on input box!")
ElseIf GUICtrlRead($CheckName) = "localhost" Then
$sIP = "127.0.0.1"
$aResult = WMI_GetHostName($sIP)

GUICtrlSetData($Label, $aResult)
GUIctrlsetdata($MyIP,$sIP)
Else
$sIP = GUICtrlRead($CheckName)
$aResult = WMI_GetHostName($sIP)
$ipResult = TCPNameToIP(GUICtrlRead($CheckName))

GUICtrlSetData($Label, $aResult)
GUIctrlsetdata($MyIP, $ipResult)

 

It works if you search other PC name before your local  PC. If you search your local pc first; the IP address doesn't display on label. To get it display; I have to search other PC (other than) my local PC then search my local PC for the label to display my IP. Which I think it's kind of odd.

[BrewManNH]

Please post working code when asking for help, this is useless to help troubleshoot the issue. You don't even include the EndIf statement in it.

[spudw2k]

Also the If logic is flawed.  How it is coded currently the scan will ONLY occur on "localhost"