ElseIf and more than, less than?

[Scinner]

Can someone tell me what Im doing wrong in this script?

Local $file = FileOpen("test.txt", 0)

; Check if file opened for reading OK
If $file = -1 Then
    MsgBox(0, "Error", "Unable to open file.")
    Exit
EndIf

; Read in 4 character at a time until the EOF is reached
While 1
    Local $chars = FileRead($file, 4)
    If @error = -1 Then ExitLoop
WEnd

FileClose($file)

If $chars > 10 Then
    MsgBox(0, "Char read:", "Yes")
ElseIf $chars < 10 Then
    MsgBox(0, "Char read:", "No")
EndIf
Exit

The number in the .txt is 22 but I get MsgBox with "No"

Thanks guys!

[jdelaney]

Local $file = FileOpen(@DesktopDir & "\test.txt", 0)

; Check if file opened for reading OK
If $file = -1 Then
    MsgBox(0, "Error", "Unable to open file.")
    Exit
EndIf

; Read in 4 character at a time until the EOF is reached
$chars = ""
While 1
    $chars &= FileRead($file, 4)
    If @error = -1 Then ExitLoop
WEnd

FileClose($file)

If StringLen($chars)> 10 Then
    MsgBox(0, "Char read:", "Yes" & $chars)
Else 
   MsgBox(0, "Char read:", "No")
EndIf

Edited June 24, 2013 by jdelaney

[AdmiralAlkex]

Are you trying to count the characters? The amount of characters read is in @extended, not the return of FileRead

[Scinner]

Are you trying to count the characters? The amount of characters read is in @extended, not the return of FileRead

No I just want to check the test.txt and if the number is equal or higher than 10 I want it to say Yes, if not then No.

Local $file = FileOpen(@DesktopDir & "\test.txt", 0)

; Check if file opened for reading OK
If $file = -1 Then
    MsgBox(0, "Error", "Unable to open file.")
    Exit
EndIf

; Read in 4 character at a time until the EOF is reached
$chars = ""
While 1
    $chars &= FileRead($file, 4)
    If @error = -1 Then ExitLoop
WEnd

FileClose($file)

If StringLen($chars)> 10 Then
    MsgBox(0, "Char read:", "Yes" & $chars)
Else 
   MsgBox(0, "Char read:", "No")
EndIf

Don't work. Don't even get a MsgBox with this.

[jdelaney]

Sure it does, add a file to your desktop, or change to be a valid file...also, if you want greater or equal, you need this:

If StringLen($chars)>= 10 Then

or, since these are all integers:

If StringLen($chars)>9 Then

Edited June 24, 2013 by jdelaney

[water]

What FileRead returns is a string. If you need to comapre it to a number convert the string to a number before comparing.

If Number($chars) > 10 Then
    MsgBox(0, "Char read:", "Yes")
ElseIf Number($chars) < 10 Then
    MsgBox(0, "Char read:", "No")
EndIf

[somdcomputerguy]

Use FileReadLine instead of FileRead.

[Scinner]

Sure it does, add a file to your desktop, or change to be a valid file

You Edited the script like 10 times. The last one gives me a MsgBox but not the right answer.

[jdelaney]

what is the 'right' answer...do you want a count of groupings of 4, or a total count of chars

[Scinner]

 

What FileRead returns is a string. If you need to comapre it to a number convert the string to a number before comparing.

If Number($chars) > 10 Then
    MsgBox(0, "Char read:", "Yes")
ElseIf Number($chars) < 10 Then
    MsgBox(0, "Char read:", "No")
EndIf

This gives me No what ever number i have in the .txt

Local $file = FileOpen("test.txt", 0)

; Check if file opened for reading OK
If $file = -1 Then
    MsgBox(0, "Error", "Unable to open file.")
    Exit
EndIf

; Read in 4 character at a time until the EOF is reached
While 1
    Local $chars = FileRead($file, 4)
    If @error = -1 Then ExitLoop
WEnd

FileClose($file)

If Number($chars) > 10 Then
    MsgBox(0, "Char read:", "Yes")
ElseIf Number($chars) < 10 Then
    MsgBox(0, "Char read:", "No")
EndIf
Exit

[Scinner]

what is the 'right' answer...do you want a count of groupings of 4, or a total count of chars

22 is more than 10 so I want Yes.

9 is less than 10 so I want No

10 is equal to 10 so I want Yes

[water]

Do you want to read the last 4 characters in a file?

[jdelaney]

Check my post once more, that was an older version:

Local $file = FileOpen(@DesktopDir & "\test.txt", 0)

; Check if file opened for reading OK
If $file = -1 Then
    MsgBox(0, "Error", "Unable to open file.")
    Exit
EndIf

; Read in 4 character at a time until the EOF is reached
$chars = ""
$iCount = 0
While 1
    $chars &= FileRead($file, 4)
    If @error = -1 Then ExitLoop
    $iCount += 1
WEnd

FileClose($file)

MsgBox(1,1,"Chrs_count=[" & StringLen($chars) & "], group_count=[" & $iCount & "]")

If StringLen($chars)>= 10 Then
    MsgBox(0, "Char read:", "Yes")
Else
    MsgBox(0, "Char read:", "No")
EndIf

Edited June 24, 2013 by jdelaney

[Scinner]

Do you want to read the last 4 characters in a file?

Sometimes there is 1 char in the .txt but there can be up to 5 chars.

So everything thats equal or above 10 I want to get Yes, anything below I want No.

[Scinner]

 

Check my post once more, that was an older version:

Local $file = FileOpen(@DesktopDir & "\test.txt", 0)

; Check if file opened for reading OK
If $file = -1 Then
    MsgBox(0, "Error", "Unable to open file.")
    Exit
EndIf

; Read in 4 character at a time until the EOF is reached
$chars = ""
$iCount = 0
While 1
    $chars &= FileRead($file, 4)
    If @error = -1 Then ExitLoop
    $iCount += 1
WEnd

FileClose($file)

MsgBox(1,1,"Chrs_count=[" & StringLen($chars) & "], group_count=[" & $iCount & "]")

If StringLen($chars)>= 10 Then
    MsgBox(0, "Char read:", "Yes")
Else
    MsgBox(0, "Char read:", "No")
EndIf

Sorry, but the comments in the code is left from the example script.

[somdcomputerguy]

file.txt contains 22

 

Local $file = FileOpen("test.txt", 0)

; Check if file opened for reading OK
If $file = -1 Then
    MsgBox(0, "Error", "Unable to open file.")
    Exit
EndIf

; Read in 1 character at a time until the EOF is reached
While 1
    Local $chars = FileRead($file, 1)
    If @error = -1 Then ExitLoop
    MsgBox(0, "Char read:", $chars)
WEnd

FileClose($file)

returns 2 (# of chars in file)

Local $file = FileOpen("test.txt", 0)

; Check if file opened for reading OK
If $file = -1 Then
    MsgBox(0, "Error", "Unable to open file.")
    Exit
EndIf

; Read in 1 character at a time until the EOF is reached
While 1
    Local $chars = FileReadLine($file, 1)
    If @error = -1 Then ExitLoop
    MsgBox(0, "Char read:", $chars)
WEnd

FileClose($file)

returns 22 (value in file)

[water]

$sInput = FileRead("test.txt")
$sInput = StringStripWS($sInput, 8)
If Number($sInput) < 10 Then
    MsgBox(0, "Info", "Input is < 10")
Else
    MsgBox(0, "Info", "Input is >= 10")
EndIf

The whole file is read in one go, spaces stripped off, converted to a number and compared.

[Melba23]

Hi,

Some here seem to be getting a bit heated so let us all calm down and go back to the beginning.

Scinner,

How about providing a couple of example files - and an explanation of whether they should be classed as "Yes" or "No" - so that we can actually see what we are actually dealing with.

M23

[Scinner]

$sInput = FileRead("test.txt")
$sInput = StringStripWS($sInput, 8)
If Number($sInput) < 10 Then
    MsgBox(0, "Info", "Input is < 10")
Else
    MsgBox(0, "Info", "Input is >= 10")
EndIf

The whole file is read in one go, spaces stripped off, converted to a number and compared.

You da man! Works like a charm!

Thanks for understanding my bad English and my bad explaining!

[Scinner]

Hi,

Some here seem to be getting a bit heated so let us all calm down and go back to the beginning.

Scinner,

How about providing a couple of example files - and an explanation of whether they should be classed as "Yes" or "No" - so that we can actually see what we are actually dealing with.

M23

 

No ones getting heated Im just bad at making myself understood in English!

Sorry, and thank you guys!