Cancelling script running

[Chimaera]

Hi

Ive got a script that runs several commandline programs one after another

and i want to give a user the option to cancel the process

I started here -

and used guinness example

and it works if the gui is idle but once it is unpacking and doing stuff it wont stop the gui

I put the important part right at top of the while loop

Local $hMsg = 0
While 1
    $hMsg = GUIGetMsg()
        If _IsChecked($hCancelButton) Then ExitLoop
        Sleep(20)
    Switch $hMsg
        Case $GUI_EVENT_CLOSE
            Exit

Any suggestions plz

[Jos]

Tried using a hotkey to trigger he cancellation of the process?

[Chimaera]

erm no i havent would that work better than the checkbox/button voodoo of guiness?

[careca]

What do you mean with 'it works if the gui is idle'? I mean, if it's not running, how can it do anything/work?

EDIT: you got the code in the while loop, but i would put it in the function loop, so that after each installation is ran, it checks if you pressed cancel.

Edited June 26, 2013 by careca

[Chimaera]

By GUI idle i meant just GUI open no commands/ functions running

So basically add the

If _IsChecked($hCancelButton) Then ExitLoop
        Sleep(20)

anywhere i can after each major function choice so it intercepts the flow

[guinness]

erm no i havent would that work better than the checkbox/button voodoo of guiness?

I think Jos was talking about HotKetSet, though I could be wrong?!

Why not have a Global flag e.g.

Global $fCancel = False

If _IsChecked($hCancelButton) Then 
$fCancel = True
ExitLoop
Endif

But as you know, I need more of a working example as there are so many possibilities of what you're trying to do.

[careca]

You could do it like this:

$aApps[0][0] = "ICO"
$aApps[0][1] = "ICO.exe"
$aApps[0][2] = "IMG\ICO.ico"
$aApps[1][0] = "VLC"
$aApps[1][1] = "VLC 2.0.6.exe"
$aApps[1][2] = "IMG\vlc.ico"
$aApps[2][0] = "LAN"
$aApps[2][1] = "AutoIt LAN.exe"
$aApps[2][2] = "IMG\realtek.ico"
$aApps[3][0] = "AMD"
$aApps[3][1] = "AutoIt AMD.exe"
$aApps[3][2] = "IMG\amd.ico"
$aApps[4][0] = "Java"
$aApps[4][1] = "AutoIt Java.exe"
$aApps[4][2] = "IMG\java.ico"
$aApps[5][0] = "DX9c"
$aApps[5][1] = "AutoIt DX9c.exe"
$aApps[5][2] = "IMG\dx9c.ico"

While 1
    Switch GUIGetMsg()
        Case $GUI_EVENT_CLOSE
            Exit
        Case $hButton1 ;RUN
            For $i = 0 To 5
            If _IsChecked($hCancelButton) Then ;We check if user wants to stop, if yes exit loop.
                            $fCancel = True
                            ExitLoop
                        Endif
                If BitAND(GUICtrlRead($aRadio[$i]), $GUI_CHECKED) = $GUI_CHECKED Then
                            ShellExecuteWait($aApps[$i][1])
            EndIf
            Next
            Exit
    EndSwitch
WEnd

Its a proof of concept, doesn't work as-is.

Edited June 27, 2013 by careca

[guinness]

That line...

BitAND(GUICtrlRead($aRadio[$i]), $GUI_CHECKED) = $GUI_CHECKED

can be reduced using the already implemented _IsChecked.

[Jos]

I think Jos was talking about HotKetSet, though I could be wrong?!

 

Correct, that is much simpler that trying to put in many checks and still have a chance the script locks-up during processing.

Jos

[Chimaera]

Thanks for the clarifications

Been chatting to melba about the issue and he has identified a flaw in the procedure.

In the script when its doing a task, im using statements like this

$ProcessPID = RunWait(@ComSpec & ' /c ' & '"' & '"' & $RarTest & '"' & ' x -y -ibck ' & '"' & $aRarFile[$i] & '"' & '"', "", @SW_HIDE)

$RarTest is winrar location and $RarFile is the archives it manipulates

As melba pointed out i cant interrupt a RunWait and it needs to be Run but

I also have a load of winrar exit code checks below the above line to catch the exit values like this

ElseIf $ProcessPID = 8 Then
    TrayTip(" Memory Error ", " Not Enough Memory To Unpack Archive " & @CRLF & @CRLF & _
        " (   Unpack Code = " & $ProcessPID & "  )", 5, 16)
    Exit

If i change to Run to make the Cancel work i lose all my exit code stuff

And ill have to map exit strategy through StdoutRead

Is there a way to make Run give the exit codes as well as the $Pid ?