Basic If...Else...EndIf that make my head spin fast

[michaelslamet]

Ok, I admit this is (very) basic but currently it make my head spin fast

I have some variable like this (note: i dont want array even with array maybe it will be much simpler and easier, consider it's a flaw from the beginnning of design)

$key1="value1"
$key2="value2"
$key3="value3"
$key4="value4"
$key5="value5"
$key6="value6"

if $key1 = "" then set $condition = false and doesn't need to check other key anymore

if $key1<>"" and FileExists($key1) then $condition = true and pls check another key
if $key2<>"" and FileExists($key2)  then $condition = true and pls check another key, but if $key2<>"" but NOT FileExists($key2) then $condition=false and do not need to check another key anymore.

if $key3<>"" and FileExists($key3)  then $condition = true and pls check another key, but if $key3<>"" but NOT FileExists($key3) then $condition=false and do not need to check another key anymore.

<do that above until key6>

If NOT $condition then

   ...

EndIf

Thank you!

[TheSaint]

You seem to have a lot of what you want/need there, so why not turn what you have into code ... makes it easier for the rest of us, and you never know, you may not even need us if you have most of the logic in front of you.

Don't forget, that you can use AND and OR in your IF statements, as well as NOT or <>

[DW1]

Perhaps something like this?

Local $condition = True
For $i = 1 To 6
    Local $skey = Eval("key" & $i)
    If $skey = "" Or Not FileExists($skey) Then
        $condition = False
        ExitLoop
    EndIf
Next

[BrewManNH]

Another point, if your conditional check of If something = ""fails, there's no need to test if it's <> "" because you already know it is.

[michaelslamet]

Hi TheSaint,

I did turn that into the code, but it doesn't seem right

Global $condition = False

$key1 = "c:\file1.txt"
$key2 = "c:\file2.txt"
$key3 = "c:\file3.txt"
$key4 = "c:\file4.txt"
$key5 = "c:\file5.txt"
$key6 = "c:\file6.txt"

If $key1 = "" Then
    $condition = False
Else
    If $key1 <> "" And FileExists($key1) Then $condition = True
    If $key2 <> "" And FileExists($key2) Then $condition = True
    If $key3 <> "" And FileExists($key3) Then $condition = True
    If $key4 <> "" And FileExists($key4) Then $condition = True
    If $key5 <> "" And FileExists($key5) Then $condition = True
    If $key6 <> "" And FileExists($key6) Then $condition = True
EndIf

[michaelslamet]

 

Perhaps something like this?

Local $condition = True
For $i = 1 To 6
    Local $skey = Eval("key" & $i)
    If $skey = "" Or Not FileExists($skey) Then
        $condition = False
        ExitLoop
    EndIf
Next

 

Wow, this seems great! I never know about Eval until now.

But I need something like this:

$key1="c:file1.txt"

$key2=""

$key3="c:file3.txt"

Above will make the $condition = false because $key2=""

but this:

$key1="c:file1.txt"

$key2=""

$key3=""

$key4=""

$key5=""

$key6=""

will make $condition = true because minimal requirement for $condition = true is $key1 <> "" AND FileExists($key1) = True

while other keys can be not defined. If other keys are defined then they have to satisfy FileExists.

Also if keys are jump like this:

$key1="c:file1.txt"

$key2=""

$key3="c:file3.txt"

even if FileExist for $key1 and $key3, $condition should be false because it jump.

this will cause $condition to true if FileExists for all of them:

$key1="c:file1.txt"

$key2="c:file2.txt"

$key3="c:file3.txt"

[michaelslamet]

Hope somebody here understand what I'm trying to say with my poor english

[DW1]

Seems like this loop is making up for bad coding practices, but you seem to be aware of that already.

Local $condition = True
Local $bBlank = False
For $i = 1 To 6
    Local $skey = Eval("key" & $i)
    If $skey = "" Then
        $bBlank = True
    Else
        If $bBlank = True Or Not FileExists($skey) Then
            $condition = False
            ExitLoop
        EndIf
    EndIf
Next
MsgBox(0,'test',$condition)

Should meet all of the criteria you have given us so far.  Though it does return true if all are blank (this is a condition you have not addressed that I can see, so I don't know if it should be true or false)

EDIT: I think you actually did specify that all blanks should return false.  This will return false for all blanks

Local $condition = True
Local $iBlank = 0
For $i = 1 To 6
    Local $skey = Eval("key" & $i)
    If $skey = "" Then
        $iBlank += 1
        If $iBlank = 6 Then
            $condition = False
            ExitLoop
        EndIf
    Else
        If $iBlank > 0 Or Not FileExists($skey) Then
            $condition = False
            ExitLoop
        EndIf
    EndIf
Next
MsgBox(0,'test',$condition)

Edited July 8, 2013 by danwilli

[michaelslamet]

Hi Danwilli,

Thank you very much for your help!

This is posted at post #1: if $key1 = "" then set $condition = false and doesn't need to check other key anymore
 

So no matter what other key's value is, as long as $key1="" then $condition = false

[DW1]

Hi Danwilli,

Thank you very much for your help!

This is posted at post #1: if $key1 = "" then set $condition = false and doesn't need to check other key anymore

 

So no matter what other key's value is, as long as $key1="" then $condition = false

Ah so you did.  In that case

Local $condition = True
Local $bBlank = False
For $i = 1 To 6
    Local $skey = Eval("key" & $i)
    If $skey = "" Then
        $bBlank = True
        If $i = 1 Then
            $condition = False
            ExitLoop
        EndIf
    Else
        If $bBlank = True Or Not FileExists($skey) Then
            $condition = False
            ExitLoop
        EndIf
    EndIf
Next
MsgBox(0, 'test', $condition)

[michaelslamet]

 

Seems like this loop is making up for bad coding practices, but you seem to be aware of that already.

Local $condition = True
Local $bBlank = False
For $i = 1 To 6
    Local $skey = Eval("key" & $i)
    If $skey = "" Then
        $bBlank = True
    Else
        If $bBlank = True Or Not FileExists($skey) Then
            $condition = False
            ExitLoop
        EndIf
    EndIf
Next
MsgBox(0,'test',$condition)

Should meet all of the criteria you have given us so far.  Though it does return true if all are blank (this is a condition you have not addressed that I can see, so I don't know if it should be true or false)

EDIT: I think you actually did specify that all blanks should return false.  This will return false for all blanks

Local $condition = True
Local $iBlank = 0
For $i = 1 To 6
    Local $skey = Eval("key" & $i)
    If $skey = "" Then
        $iBlank += 1
        If $iBlank = 6 Then
            $condition = False
            ExitLoop
        EndIf
    Else
        If $iBlank > 0 Or Not FileExists($skey) Then
            $condition = False
            ExitLoop
        EndIf
    EndIf
Next
MsgBox(0,'test',$condition)

 

Tested, working very great!!

I'm not really sure how it works but it just works!!

I will learn how the code works

I spend almost 1.5 days to figure it out and u done that in 5 mins (or maybe less)

Thanks again for your help, Danwilli

[DW1]

Tested, working very great!!

I'm not really sure how it works but it just works!!

I will learn how the code works

I spend almost 1.5 days to figure it out and u done that in 5 mins (or maybe less)

Thanks again for your help, Danwilli

I commented the code so you can learn from it and understand the thought process   Glad it's working for you

;Start with $condition = True until proven false
Local $condition = True
;We will use $bBlank to track if there has been a blank value (since any non blank following a blank makes $condition = False)
Local $bBlank = False
;Loop through the 6 keys
For $i = 1 To 6
    ;Set $skey to the value of the currect key in the loop (using eval due to lack of array and naming convention allows for it)
    Local $skey = Eval("key" & $i)
    ;If the key is blank then...
    If $skey = "" Then
        ;Record that we found a blank (we can check against this later)
        $bBlank = True
        ;If we found a blank and it is the first key, we set condition to false and exit the loop (no more checks)
        If $i = 1 Then
            ;Set condition to false
            $condition = False
            ;Exit the loop (no more checks)
            ExitLoop
        EndIf
    ;If the key is NOT blank then...
    Else
        ;Check to see if we have seen a blank before (if so, we have a "jump" as you put it, and will set condition to false and exitloop).  Also checking if the file doesn't exist for this key (and if it doesn't set to false and exitloop)
        If $bBlank = True Or Not FileExists($skey) Then
            ;Set condition to false
            $condition = False
            ;Exit the loop (no more checks)
            ExitLoop
        EndIf
    EndIf
Next
MsgBox(0, 'test', $condition)

[guinness]

Just a quick reminder declaring variables in a loop will increase the execution time. Declare outside instead.

[DW1]

Just a quick reminder declaring variables in a loop will increase the execution time. Declare outside instead.

D'oh.  And in a thread where I mention coding practices.

Corrected

;Start with $condition = True until proven false
Local $condition = True
;We will use $bBlank to track if there has been a blank value (since any non blank following a blank makes $condition = False)
Local $bBlank = False
;Declase our $skey var
Local $skey
;Loop through the 6 keys
For $i = 1 To 6
    ;Set $skey to the value of the currect key in the loop (using eval due to lack of array and naming convention allows for it)
    $skey = Eval("key" & $i)
    ;If the key is blank then...
    If $skey = "" Then
        ;Record that we found a blank (we can check against this later)
        $bBlank = True
        ;If we found a blank and it is the first key, we set condition to false and exit the loop (no more checks)
        If $i = 1 Then
            ;Set condition to false
            $condition = False
            ;Exit the loop (no more checks)
            ExitLoop
        EndIf
    ;If the key is NOT blank then...
    Else
        ;Check to see if we have seen a blank before (if so, we have a "jump" as you put it, and will set condition to false and exitloop).  Also checking if the file doesn't exist for this key (and if it doesn't set to false and exitloop)
        If $bBlank = True Or Not FileExists($skey) Then
            ;Set condition to false
            $condition = False
            ;Exit the loop (no more checks)
            ExitLoop
        EndIf
    EndIf
Next
MsgBox(0, 'test', $condition)

[guinness]

No problem, we're all learning still.

[michaelslamet]

Danwilli,

Ok, understand

That is if I read the code...

If write it from beginning, it could be a different story

btw, this:

;Set $skey to the value of the currect key in the loop (using eval due to lack of array and naming convention allows for it)
Local $skey = Eval("key" & $i)

 

What if the naming convention doesn't allows for it? (the variable name is random)

Edited July 8, 2013 by michaelslamet

[michaelslamet]

No problem, we're all learning still.

 

If you guys with current skill are still learning, why should i not

[DW1]

Danwilli,

Ok, understand

That is if I read the code...

If write it from beginning, it could be a different story

btw, this:

;Set $skey to the value of the currect key in the loop (using eval due to lack of array and naming convention allows for it)
Local $skey = Eval("key" & $i)

What if the naming convention doesn't allows for it? (the variable name is random)

Then, personally, I would move all of the values of the variables in to an array prior to starting a loop.  Same basic idea, just an extra step.

[michaelslamet]

Then, personally, I would move all of the values of the variables in to an array prior to starting a loop.  Same basic idea, just an extra step.

 

Ok, roger that. Thanks again!

[guinness]

Eval, Assign and IsDeclared should be used sparingly in my humble opinion.