Bug In AssocArrays.au3

[MarkRobbins]

Somewhere out there is a UDF lib <AssocArrays.au3>

Autoit v3.3.8.1

Unless I am doing something really stupid, it has a bug. Here is the repro, does anyone have a fix?

I've attached the lib, it doesn't show a version number.

#include <AssocArrays.au3>
#include <ButtonConstants.au3>

Global $consts
    AssocArrayCreate($consts,1)
    AssocArrayAssign($consts,'Left',$BS_LEFT)
    AssocArrayAssign($consts,'Right',$BS_RIGHT)
    AssocArrayAssign($consts,'Bottom',$BS_BOTTOM)
    AssocArrayAssign($consts,'Center',$BS_CENTER)
    AssocArrayAssign($consts,'DefPushButton',$BS_DEFPUSHBUTTON)
    AssocArrayAssign($consts,'MultiLine',$BS_MULTILINE)
    AssocArrayAssign($consts,'Top',$BS_TOP)
    AssocArrayAssign($consts,'VCenter',$BS_VCENTER)
    AssocArrayAssign($consts,'Icon',$BS_ICON)
    AssocArrayAssign($consts,'Bitmap',$BS_BITMAP)
    AssocArrayAssign($consts,'Flat',$BS_FLAT)
    AssocArrayAssign($consts,'Notify',$BS_NOTIFY); NOTE: Repeating this line will make it exist

Inspect('Notify'); Says not exist, unexpected!
Inspect('Flat');Exists
Inspect('Top');Exists

Func Inspect($test)
  If Not AssocArrayExists($consts,$test) Then
    MsgBox(0,$test,'Does not exist')
  Else
    MsgBox(0,$test,'Does exist')
  EndIf
EndFunc

AssocArrays.au3

[JLogan3o13]

Hi, MarkRobbins. Normally I suggest posting in the UDF's original topic, so the creator can assist directly. I see that Nutster has not been active in a while, though.

[Melba23]

MarkRobbins,

I can see a possible reason - somewhere in the original thread it is suggested that you create the AssocArray with a prime number of elements sufficiently large to cover the expected number of items. I seem to remember that it has to do with collisons when the values produce similar hashes - but do not take my word for it.

Anyway, if I create the array with a suitable prime number of elements (I tried 19 and 29), all the keys respond "Does exist".

Does the same happen for you when you try.

M23

[MarkRobbins]

MarkRobbins,

I can see a possible reason - somewhere in the original thread it is suggested that you create the AssocArray with a prime number of elements sufficiently large to cover the expected number of items. I seem to remember that it has to do with collisons when the values produce similar hashes - but do not take my word for it.

Anyway, if I create the array with a suitable prime number of elements (I tried 19 and 29), all the keys respond "Does exist".

Does the same happen for you when you try.

M23

 

"1" is prime

I've moved on to an alternate method, since I didn't want to build on shaky ground. Check this out:

expandcollapse popup

#include <AssocArrays.au3>
#include <Array.au3>

Global $oError = ObjEvent("AutoIt.Error", "_ErrFunc")
Global $_ComObj_proxy
Global $_com
Global $_Js
JScriptInit()



;Create javascript COM objects
Global $ob = $_com.new_object("")
Global $ob2 = $_com.new_object("")



;Msg(VarGetType($ob.keys()));Object
;Msg($ob.keys().item(0));""
;Msg($ob.keys().length);0

;set a single value
$ob.set('v','a var')

;set many values
$ob.set2('one',1,'two',2)

;check if exists examples
#cs
Msg($ob.has('one'));true
Msg(VarGetType($ob.get('two')));Int32
#ce

;iterate values example

Global $x,$end=$ob.keys().length-1
Global $k=$ob.keys()
For $x=0 To $end
  Msg($k.item($x)&':'&$ob.get($k.item($x)))
Next

;store an array as a value example
#cs
Global $arr[3]=[1,2,3]
$ob2.set('arr',$arr)
Local $a=$ob2.get('arr');have to put in a var first, else error if inline
_ArrayDisplay($a)
#ce

; test and compare
Global $timer = TimerInit()
;many items
$end=1000
;insert
For $x=0 to $end
   $ob.set("val"&$x,"value"&$x)
Next

;read
Local $dum
For $x=0 to $end
   $dum=$ob.get("val"&$x)
Next
; keep time
Global $t1=TimerDiff($timer)


;compare to AssocArray
Global $aa
AssocArrayCreate($aa,1000)

;insert
$timer = TimerInit()
For $x=0 to $end
  AssocArrayAssign($aa,"val"&$x,"value"&$x)
Next

;read
For $x=0 to $end
  $dum=AssocArrayGet($aa,"val"&$x)
Next
;keep time
Global $t2=TimerDiff($timer)
;report
MsgBox(0,'insert,read of items:'&$end,'Millisecs, javascript:'&Int($t1)&@CRLF&'AssocArray:'&Int($t2))
;
;random access one item
$timer = TimerInit()
;by indexing
$ob.get("val500")
Global $t3=TimerDiff($timer)


$timer = TimerInit()
;directly!!
Local $v=$ob.val500
Global $t31=TimerDiff($timer)

; assoc
$timer = TimerInit()
AssocArrayGet($aa,"val500")
Global $t4=TimerDiff($timer)

;report
MsgBox(0,'random access,1 item of '&$end,'Millisecs, javascript by indexing:'&$t3&@CRLF&'javscript direct:'&$t31&@CRLF&' AssocArray:'&$t4)
Exit



Func _ComObj_init ($VBScriptSupport = false)
  Local $_Script
  $_Script = ObjCreate("ScriptControl")
  $_Script.Language = "JScript"
  $_Script.Timeout = 60000
  ;$_Script.AddCode("var $=this,arrays=[],vb;function set_vbscript($) {vb=$;vb.Language='VBScript';vb.AllowUI=true;}function alert(s){if(vb)vb.Eval('MsgBox(Unescape(""'+s+'""), 0, ""Autoit"")')}function get_proxy(){return $}function new_object($){$=new Function('return{'+$+'}')();$.set=function(k, v){$[k]=v};$.unset=function(k){delete $[k]};$.set_object=function(k,$){this.set(k,new_object($))};$.set_array=function(){var v=[];for(var i=0;i<arguments.length;i++)v[i]=arguments[i];$.set(v.shift(),new_array.apply(this,v))};$.set_function=function(k,p,$){this.set(k,new_function(p,$))};return $}function new_array(){var v=[];for(var i=0;i<arguments.length;i++)v[i]=arguments[i];return v}function array_get($,k){return $[k]}function array_set($,k,v){return $[k]=v}var new_function=(function(){function F(r) {return Function.apply(this,r)}F.prototype = Function.prototype;return function(p,$){p=p.split(/\s*,\s*/);p.push($);return new F(p)}})()")
  ;a[a.length]=i;
  ;function new_array(){var v=[];for(var i=0;i<arguments.length;i++)v[i]=arguments[i];return v}
  Local $more= _
  "$.get=function(k){return $[k]};" & _
  "$.has=function(n){" & _
  "  for (var i in this){" & _
  "    if (i!=n){" & _
  "      continue;" & _
  "    }" & _
  "    if (!this.hasOwnProperty(i)){" & _
  "      continue;" & _
  "    }" & _
  "    if (typeof(this[i])=='function'){" & _
  "      continue;" & _
  "    }" & _
  "    return true;" & _
  "  };" & _
  "  return false;" & _
  "};" & _
  "$.keys=function(){" & _
  "  var a=[];" & _
  "  for (var i in this){" & _
  "    if (this.hasOwnProperty(i)){" & _
  "      if (typeof(this[i])!='function'){" & _
  "        a[a.length]=i;" & _
  "      }" & _
  "    }" & _
  "  };" & _
  "  return a;" & _
  "};" & _
  "$.set2=function(){" & _
  "  for(var x=0;x<arguments.length-1;x+=2){" & _
  "    this[arguments[x]]=arguments[x+1]" & _
  "  }" & _
  "};" & _
  "Array.prototype.item=function(n){" & _
  "  return this[n];" & _
  "};" & _
  "Array.prototype.asString=function(d){" & _
  "  var s='';" & _
  "  for(x=0;x<this.length;x++){" & _
  "    if(s==''){s=this[x];}else{s+=d+this[x];}" & _
  "  }" & _
  "  return s;" & _
  "};"
  $_Script.AddCode("var $=this,arrays=[],vb;function set_vbscript($) {vb=$;vb.Language='VBScript';vb.AllowUI=true;}function alert(s){if(vb)vb.Eval('MsgBox(Unescape(""'+s+'""), 0, ""Autoit"")')}function get_proxy(){return $}function new_object($){$=new Function('return{'+$+'}')();$.set=function(k, v){$[k]=v};"&$more&"$.unset=function(k){delete $[k]};$.set_object=function(k,$){this.set(k,new_object($))};$.set_array=function(){var v=[];for(var i=0;i<arguments.length;i++)v[i]=arguments[i];$.set(v.shift(),new_array.apply(this,v))};$.set_function=function(k,p,$){this.set(k,new_function(p,$))};return $}function new_array(){var v=[];for(var i=0;i<arguments.length;i++)v[i]=arguments[i];return v}function array_get($,k){return $[k]}function array_set($,k,v){return $[k]=v}var new_function=(function(){function F(r) {return Function.apply(this,r)}F.prototype = Function.prototype;return function(p,$){p=p.split(/\s*,\s*/);p.push($);return new F(p)}})()")
  If $VBScriptSupport = true Then $_Script.Run("set_vbscript", ObjCreate("ScriptControl"))
  Return $_Script
EndFunc

Func JScriptInit()
  $_ComObj_proxy = _ComObj_init(true)
  $_com = $_ComObj_proxy.Run("get_proxy")
  $_Js = $_com.new_object("")
  ;$_Js.set_function("AIOSetProperty","o,n,v","o[n]=v;")
EndFunc


Func _ErrFunc()
    ;ConsoleWrite("COM Error, ScriptLine(" & $oError.scriptline & ") : Number 0x" & Hex($oError.number, 8) & " - " & $oError.windescription & @CRLF)
  Local $line="[COM Error]:s"&$oError.source&" ScriptLine(" & $oError.scriptline & ") : Number 0x" & Hex($oError.number, 8) & " - " & $oError.windescription
  Local $line2="" &$oError.source &':'& $oError.scriptline & ":" & $oError.windescription
  ;logerr($line)
  ;Msg($line2)
  exit
EndFunc

Func Msg($s)
  MsgBox(0,'',$s)
EndFunc

What do you think?

[guinness]

There is Scripting.Dictionary you can use.

[Melba23]

MarkRobbins,

 

"1" is prime

But what I said was:

create the AssocArray with a prime number of elements sufficiently large to cover the expected number of items

and I do not think "1" qualifies on that count (pun fully intended).

As I explained, when I used a suitably sized prime in your code to create the array everything worked as expected. And I have been using this UDF for many years without problem, so I do not think it is too "shaky".

M23

[jchd]

For the record, 1 is not a prime number by any valid known definition of "prime".

Anyway, a scripting dictionary would work irrespective of the number of entries it contains.

[JLogan3o13]

I lol'd at 1 being a prime number. Very definition of a prime number is: a natural number greater than 1 that has no positive divisors other than 1 and itself.

[jchd]

Yup, that or

p prime ⇔ τ(p) = 2, where τ (the greek letter tau) represents the number of positive divisors of p.