Sign in to follow this  
Followers 0
BinaryBrother

@ScriptDir returns trailing slash

21 posts in this topic

#1 ·  Posted (edited)

@ScriptDir

Directory containing the running script. (Result doesn't contain a trailing backslash)

I'm not really sure what's happening here. Either I'm overlooking something, or the trailing slash behavior just changed on me, mid script.

I am running AutoIt Version 3.3.8.1.

Is this behavior expected, or is this a bug?
 

Windows 7 x86

Summery: @ScriptDir is giving me, C: when it should be giving me C:.

post-25179-0-58102600-1375196913_thumb.p

 

Edited by BinaryBrother

Share this post


Link to post
Share on other sites



Yeah.. this is one of those things.. it's always been that way, but I personally consider it a bug, or at least inconsistent behavior. Maybe you should submit a Trac ticket.

Share this post


Link to post
Share on other sites

It has been like that for as long as I have been using AutoIt.


_AdapterConnections()_AlwaysRun()_AppMon()_AppMonEx()_BinaryBin()_CheckMsgBox()_CmdLineRaw()_ContextMenu()_ConvertLHWebColor()/_ConvertSHWebColor()_DesktopDimensions()_DisplayPassword()_DotNet_Load()/_DotNet_Unload()_Fibonacci()_FileCompare()_FileCompareContents()_FileNameByHandle()_FilePrefix/SRE()_FindInFile()_GetBackgroundColor()/_SetBackgroundColor()_GetConrolID()_GetCtrlClass()_GetDirectoryFormat()_GetDriveMediaType()_GetFilename()/_GetFilenameExt()_GetHardwareID()_GetIP()_GetIP_Country()_GetOSLanguage()_GetSavedSource()_GetStringSize()_GetSystemPaths()_GetURLImage()_GIFImage()_GoogleWeather()_GUICtrlCreateGroup()_GUICtrlListBox_CreateArray()_GUICtrlListView_CreateArray()_GUICtrlListView_SaveCSV()_GUICtrlListView_SaveHTML()_GUICtrlListView_SaveTxt()_GUICtrlListView_SaveXML()_GUICtrlMenu_Recent()_GUICtrlMenu_SetItemImage()_GUICtrlTreeView_CreateArray()_GUIDisable()_GUIImageList_SetIconFromHandle()_GUIRegisterMsg()_GUISetIcon()_Icon_Clear()/_Icon_Set()_IdleTime()_InetGet()_InetGetGUI()_InetGetProgress()_IPDetails()_IsFileOlder()_IsGUID()_IsHex()_IsPalindrome()_IsRegKey()_IsStringRegExp()_IsSystemDrive()_IsUPX()_IsValidType()_IsWebColor()_Language()_Log()_MicrosoftInternetConnectivity()_MSDNDataType()_PathFull/GetRelative/Split()_PathSplitEx()_PrintFromArray()_ProgressSetMarquee()_ReDim()_RockPaperScissors()/_RockPaperScissorsLizardSpock()_ScrollingCredits_SelfDelete()_SelfRename()_SelfUpdate()_SendTo()_ShellAll()_ShellFile()_ShellFolder()_SingletonHWID()_SingletonPID()_Startup()_StringCompact()_StringIsValid()_StringRegExpMetaCharacters()_StringReplaceWholeWord()_StringStripChars()_Temperature()_TrialPeriod()_UKToUSDate()/_USToUKDate()_WinAPI_Create_CTL_CODE()_WinAPI_CreateGUID()_WMIDateStringToDate()/_DateToWMIDateString()Au3 script parsingAutoIt SearchAutoIt3 PortableAutoIt3WrapperToPragmaAutoItWinGetTitle()/AutoItWinSetTitle()CodingDirToHTML5FileInstallrFileReadLastChars()GeoIP databaseGUI - Only Close ButtonGUI ExamplesGUICtrlDeleteImage()GUICtrlGetBkColor()GUICtrlGetStyle()GUIEventsGUIGetBkColor()Int_Parse() & Int_TryParse()IsISBN()LockFile()Mapping CtrlIDsOOP in AutoItParseHeadersToSciTE()PasswordValidPasteBinPosts Per DayPreExpandProtect GlobalsQueue()Resource UpdateResourcesExSciTE JumpSettings INISHELLHOOKShunting-YardSignature CreatorStack()Stopwatch()StringAddLF()/StringStripLF()StringEOLToCRLF()VSCROLLWM_COPYDATAMore Examples...

Updated: 04/09/2015

Share this post


Link to post
Share on other sites

It only happens in root directories, and really, scripts shouldn't run from there, especially with UAC. It's one of those sneaky gotchas.

1 person likes this

Share this post


Link to post
Share on other sites

#6 ·  Posted (edited)

I believe it only does it at the root of C:. I have tried it when the script is saved elsewhere, and it doesn't return the trailing slash. Maybe that is why you haven't noticed it :)

 

Edit: Too slow

Edited by JLogan3o13
1 person likes this

√-1 2^3 ∑ π, and it was delicious!

Share this post


Link to post
Share on other sites

Yep, you guys are probably right. I never run scripts from root, but I'm working on a project that's working with the root directory of a Network Drive. At first, I thought it was a Network Path bug, but then I tested on my local drive before I posted, hence the C: in the screenshot.

^_^ 

 

Share this post


Link to post
Share on other sites

Kind of a PITA, but you could wrap the macro. Also, this is the same behavior of other dynamic directory macros like @WorkingDir.

ConsoleWrite(@ScriptDir & " | " & _ScriptDir() & @CRLF)
ConsoleWrite(@WorkingDir & " | " & _WorkingDir() & @CRLF)
FileChangeDir("C:\")
ConsoleWrite(@WorkingDir & " | " & _WorkingDir() & @CRLF)

Func _ScriptDir()
    Return StringRegExpReplace(@ScriptDir, "\\+$", "")
EndFunc

Func _WorkingDir()
    Return StringRegExpReplace(@WorkingDir, "\\+$", "")
EndFunc
1 person likes this

Share this post


Link to post
Share on other sites

@ScriptDir used to return C: where C is the drive letter. But it would be an issue for some who did not check so the backslash is appended for when @ScriptDir is in the root. It was a fix to avoid problems that may occur.

19th December, 2006 - v3.2.2.0

Fixed: @ScriptDir equal @WorkingDir for rootdir (x:).

Share this post


Link to post
Share on other sites

BTW, this is completely valid as far as Windows is concerned, "C:Temp"

1 person likes this

If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

So is this...

ConsoleWrite(FileExists("C:\\\Users\\\\\\guinness\\\Desktop\\\\\\\\\\\\\\\\\\\\\\\\\\Exampel.txt") & @CRLF) ; Returns 1.
ConsoleWrite(FileExists("C:\\\Users\\\\\\guinness\\\Desktop\\\\\\\\\\\\\\\\\\\\\\\\\\ExampleNotExists.txt") & @CRLF) ; Returns 0.
1 person likes this

_AdapterConnections()_AlwaysRun()_AppMon()_AppMonEx()_BinaryBin()_CheckMsgBox()_CmdLineRaw()_ContextMenu()_ConvertLHWebColor()/_ConvertSHWebColor()_DesktopDimensions()_DisplayPassword()_DotNet_Load()/_DotNet_Unload()_Fibonacci()_FileCompare()_FileCompareContents()_FileNameByHandle()_FilePrefix/SRE()_FindInFile()_GetBackgroundColor()/_SetBackgroundColor()_GetConrolID()_GetCtrlClass()_GetDirectoryFormat()_GetDriveMediaType()_GetFilename()/_GetFilenameExt()_GetHardwareID()_GetIP()_GetIP_Country()_GetOSLanguage()_GetSavedSource()_GetStringSize()_GetSystemPaths()_GetURLImage()_GIFImage()_GoogleWeather()_GUICtrlCreateGroup()_GUICtrlListBox_CreateArray()_GUICtrlListView_CreateArray()_GUICtrlListView_SaveCSV()_GUICtrlListView_SaveHTML()_GUICtrlListView_SaveTxt()_GUICtrlListView_SaveXML()_GUICtrlMenu_Recent()_GUICtrlMenu_SetItemImage()_GUICtrlTreeView_CreateArray()_GUIDisable()_GUIImageList_SetIconFromHandle()_GUIRegisterMsg()_GUISetIcon()_Icon_Clear()/_Icon_Set()_IdleTime()_InetGet()_InetGetGUI()_InetGetProgress()_IPDetails()_IsFileOlder()_IsGUID()_IsHex()_IsPalindrome()_IsRegKey()_IsStringRegExp()_IsSystemDrive()_IsUPX()_IsValidType()_IsWebColor()_Language()_Log()_MicrosoftInternetConnectivity()_MSDNDataType()_PathFull/GetRelative/Split()_PathSplitEx()_PrintFromArray()_ProgressSetMarquee()_ReDim()_RockPaperScissors()/_RockPaperScissorsLizardSpock()_ScrollingCredits_SelfDelete()_SelfRename()_SelfUpdate()_SendTo()_ShellAll()_ShellFile()_ShellFolder()_SingletonHWID()_SingletonPID()_Startup()_StringCompact()_StringIsValid()_StringRegExpMetaCharacters()_StringReplaceWholeWord()_StringStripChars()_Temperature()_TrialPeriod()_UKToUSDate()/_USToUKDate()_WinAPI_Create_CTL_CODE()_WinAPI_CreateGUID()_WMIDateStringToDate()/_DateToWMIDateString()Au3 script parsingAutoIt SearchAutoIt3 PortableAutoIt3WrapperToPragmaAutoItWinGetTitle()/AutoItWinSetTitle()CodingDirToHTML5FileInstallrFileReadLastChars()GeoIP databaseGUI - Only Close ButtonGUI ExamplesGUICtrlDeleteImage()GUICtrlGetBkColor()GUICtrlGetStyle()GUIEventsGUIGetBkColor()Int_Parse() & Int_TryParse()IsISBN()LockFile()Mapping CtrlIDsOOP in AutoItParseHeadersToSciTE()PasswordValidPasteBinPosts Per DayPreExpandProtect GlobalsQueue()Resource UpdateResourcesExSciTE JumpSettings INISHELLHOOKShunting-YardSignature CreatorStack()Stopwatch()StringAddLF()/StringStripLF()StringEOLToCRLF()VSCROLLWM_COPYDATAMore Examples...

Updated: 04/09/2015

Share this post


Link to post
Share on other sites

I was just about to ask that, BrewManNH.
Being as Windows will accept these paths, gracefully, I guess I'll just leave it. ^.^
 

Share this post


Link to post
Share on other sites

It's worth noting that "C:" and "C:" are very different paths. "C:" returns the current working directory in the C drive where as "C:" is the root directory of the C drive.

This is why *nix paths are so much easier with no namespaces.

1 person likes this

Share this post


Link to post
Share on other sites

Hi,

As I did the mod long time ago,

@Scripdir mus be the same as @workingdir for the root.

Just think what happens if you use in a FileChangeDir(@Scriptdir) for a script being in the root

No change will occur if no "" for root

JP

Share this post


Link to post
Share on other sites

FileChangeDir would actually work fine with C: according to the API for SetCurrentDirectory so I don't think that was why it changed.

http://msdn.microsoft.com/en-us/library/windows/desktop/aa365530(v=vs.85).aspx

 

The string must not exceed MAX_PATH characters, including the terminating null character. The final character before the null character must be a backslash (''). If you do not specify the backslash, it will be added for you;

 

That said vbscript has the exact same behaviour where it only adds on a backslash at the root, so I'm inclined to leave it alone.

Set objShell = CreateObject("Wscript.Shell")
Set objFSO = CreateObject("Scripting.FileSystemObject")

strPath = Wscript.ScriptFullName
WScript.Echo strPath

Set objFile = objFSO.GetFile(strPath)
strFolder = objFSO.GetParentFolderName(objFile) 

WScript.Echo strFolder

Share this post


Link to post
Share on other sites

CreateFile
"When opening a volume or removable media drive (for example, a floppy disk drive or flash memory thumb drive), the lpFileName string should be the following form: ".X:". Do not use a trailing backslash (), which indicates the root directory of a drive."

Share this post


Link to post
Share on other sites

KaFu, that path requirement is for opening drives as an I/O device, which is a different beast altogether.  Paths for them are very much governed by the device type.. 

I've actually >used that method before ;)

Share this post


Link to post
Share on other sites

Yeah, I know. The important part is the second one: Do not use a trailing backslash (), which indicates the root directory of a drive.

So "x:" refers to drive itself (e.g. for accessing the MFT) and "x:" refers to the root directory of the drive.

Share this post


Link to post
Share on other sites

Yeah, I know. The important part is the second one: Do not use a trailing backslash (), which indicates the root directory of a drive.

So "x:" refers to drive itself (e.g. for accessing the MFT) and "x:" refers to the root directory of the drive.

However, this is unrelated to the current discussion as you would never use the working directory or script directory with the assumption that it is a drive root.

1 person likes this

Share this post


Link to post
Share on other sites

However, this is unrelated to the current discussion as you would never use the working directory or script directory with the assumption that it is a drive root.

but some put script under the root !!!

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0